ACPR/android_system_core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge "adb: fix flakiness in PTY shell protocol."

Browse source
This commit is contained in:
Josh Gao 2020-05-20 21:01:23 +00:00 • committed by Gerrit Code Review
commit b27365510d
1 changed files with 9 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
adb/daemon/shell_service.cpp
View file

@ -646,15 +646,21 @@ unique_fd* Subprocess::PollLoop(SubprocessPollfds* pfds) {
} }
// After handling all of the events we've received, check to see if any fds have died. // After handling all of the events we've received, check to see if any fds have died.
if (stdinout_pfd.revents & (POLLHUP | POLLRDHUP | POLLERR | POLLNVAL)) { auto poll_finished = [](int events) {
// Don't return failure until we've read out all of the fd's incoming data.
return (events & POLLIN) == 0 &&
(events & (POLLHUP | POLLRDHUP | POLLERR | POLLNVAL)) != 0;
};
if (poll_finished(stdinout_pfd.revents)) {
return &stdinout_sfd_; return &stdinout_sfd_;
} }
if (stderr_pfd.revents & (POLLHUP | POLLRDHUP | POLLERR | POLLNVAL)) { if (poll_finished(stderr_pfd.revents)) {
return &stderr_sfd_; return &stderr_sfd_;
} }
if (protocol_pfd.revents & (POLLHUP | POLLRDHUP | POLLERR | POLLNVAL)) { if (poll_finished(protocol_pfd.revents)) {
return &protocol_sfd_; return &protocol_sfd_;
} }
} // while (!dead_sfd) } // while (!dead_sfd)