diff --git a/liblog/logd_reader.cpp b/liblog/logd_reader.cpp index 6865c14a5..82ed6b2b5 100644 --- a/liblog/logd_reader.cpp +++ b/liblog/logd_reader.cpp @@ -35,8 +35,6 @@ #include -#include -#include #include #include "logger.h" diff --git a/liblog/logd_writer.cpp b/liblog/logd_writer.cpp index 9a085ec6d..f49c59efe 100644 --- a/liblog/logd_writer.cpp +++ b/liblog/logd_writer.cpp @@ -34,7 +34,6 @@ #include -#include #include #include @@ -113,7 +112,7 @@ int LogdWrite(log_id_t logId, struct timespec* ts, struct iovec* vec, size_t nr) } /* logd, after initialization and priv drop */ - if (__android_log_uid() == AID_LOGD) { + if (getuid() == AID_LOGD) { /* * ignore log messages we send to ourself (logd). * Such log messages are often generated by libraries we depend on diff --git a/liblog/logger.h b/liblog/logger.h index 65b411df9..078e778d1 100644 --- a/liblog/logger.h +++ b/liblog/logger.h @@ -18,7 +18,6 @@ #include -#include #include #include "log_portability.h" @@ -49,18 +48,4 @@ inline bool android_logger_is_logd(struct logger* logger) { return reinterpret_cast(logger) & LOGGER_LOGD; } -/* OS specific dribs and drabs */ - -#if defined(_WIN32) -#include -typedef uint32_t uid_t; -static inline uid_t __android_log_uid() { - return AID_SYSTEM; -} -#else -static inline uid_t __android_log_uid() { - return getuid(); -} -#endif - __END_DECLS diff --git a/liblog/logger_read.cpp b/liblog/logger_read.cpp index 0d383ff7b..a13ab3673 100644 --- a/liblog/logger_read.cpp +++ b/liblog/logger_read.cpp @@ -27,8 +27,6 @@ #include #include -#include -#include #include "log_portability.h" #include "logd_reader.h" diff --git a/liblog/logger_write.cpp b/liblog/logger_write.cpp index f55f4354c..77be58153 100644 --- a/liblog/logger_write.cpp +++ b/liblog/logger_write.cpp @@ -15,7 +15,6 @@ */ #include -#include #include #include #include @@ -42,7 +41,7 @@ #if defined(__ANDROID__) static int check_log_uid_permissions() { - uid_t uid = __android_log_uid(); + uid_t uid = getuid(); /* Matches clientHasLogCredentials() in logd */ if ((uid != AID_SYSTEM) && (uid != AID_ROOT) && (uid != AID_LOG)) { diff --git a/liblog/pmsg_reader.cpp b/liblog/pmsg_reader.cpp index 9390fecae..64a92b7ce 100644 --- a/liblog/pmsg_reader.cpp +++ b/liblog/pmsg_reader.cpp @@ -23,7 +23,7 @@ #include #include -#include +#include #include #include "logger.h" diff --git a/liblog/pmsg_writer.cpp b/liblog/pmsg_writer.cpp index e2fd00041..319360f63 100644 --- a/liblog/pmsg_writer.cpp +++ b/liblog/pmsg_writer.cpp @@ -26,7 +26,6 @@ #include #include -#include #include #include "log_portability.h" @@ -113,7 +112,7 @@ int PmsgWrite(log_id_t logId, struct timespec* ts, struct iovec* vec, size_t nr) pmsgHeader.magic = LOGGER_MAGIC; pmsgHeader.len = sizeof(pmsgHeader) + sizeof(header); - pmsgHeader.uid = __android_log_uid(); + pmsgHeader.uid = getuid(); pmsgHeader.pid = getpid(); header.id = logId;