ACPR/android_system_core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

init: Document which class Service members are not modified

Browse source 
It is nontrivial to derive from the implementation of class Service
which members are not modified. Hence this CL that documents this by
declaring these members 'const'.

Change-Id: I27b907a1c7044376d5c5393a29050c66cbdab7bf
Signed-off-by: Bart Van Assche <bvanassche@google.com>
This commit is contained in:
Bart Van Assche 2022-11-14 11:24:12 -08:00
parent 5d18891e60
commit bfcf4374ed
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
init/service.h
View file

@ -143,7 +143,7 @@ class Service {
flags_ &= ~SVC_ONESHOT;
}
}
Subcontext* subcontext() const { return subcontext_; }
const Subcontext* subcontext() const { return subcontext_; }
const std::string& filename() const { return filename_; }
void set_filename(const std::string& name) { filename_ = name; }
@ -162,7 +162,7 @@ class Service {
static std::chrono::time_point<std::chrono::steady_clock> exec_service_started_;
static pid_t exec_service_pid_;
std::string name_;
const std::string name_;
std::set<std::string> classnames_;
unsigned flags_;
@ -186,7 +186,7 @@ class Service {
// Environment variables that only get applied to the next run.
std::vector<std::pair<std::string, std::string>> once_environment_vars_;
Subcontext* subcontext_;
const Subcontext* const subcontext_;
Action onrestart_; // Commands to execute on restart.
std::vector<std::string> writepid_files_;
@ -220,7 +220,7 @@ class Service {
bool updatable_ = false;
std::vector<std::string> args_;
const std::vector<std::string> args_;
std::vector<std::function<void(const siginfo_t& siginfo)>> reap_callbacks_;