From 507209ba55ba431806f7a60ec28fad4fc866c903 Mon Sep 17 00:00:00 2001 From: Steven Moreland Date: Wed, 7 Dec 2022 20:55:35 +0000 Subject: [PATCH] ignore error -> log Current code ignores an error, which is a code rot risk. Bug: 261700511 Change-Id: I04ca7046dc42d761ecaaf56f6100c96cc8298ec5 Test: N/A --- init/service.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/init/service.cpp b/init/service.cpp index 2ce81a0ad..4e2226bbc 100644 --- a/init/service.cpp +++ b/init/service.cpp @@ -868,6 +868,8 @@ void Service::StopOrReset(int how) { if ((how != SVC_DISABLED) && (how != SVC_RESET) && (how != SVC_RESTART)) { // An illegal flag: default to SVC_DISABLED. + LOG(ERROR) << "service '" << name_ << "' requested unknown flag " << how + << ", defaulting to disabling it."; how = SVC_DISABLED; }