ACPR/android_system_core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge "[adb] Check for null in mdns connect info."

Browse source
This commit is contained in:
Joshua Duong 2020-06-17 01:23:54 +00:00 • committed by Gerrit Code Review
commit cf88259783
1 changed files with 7 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
adb/client/transport_mdns.cpp
View file

@ -680,6 +680,13 @@ std::string mdns_list_discovered_services() {
std::optional<MdnsInfo> mdns_get_connect_service_info(std::string_view name) { std::optional<MdnsInfo> mdns_get_connect_service_info(std::string_view name) {
CHECK(!name.empty()); CHECK(!name.empty());
// only adb server creates these registries
if (!ResolvedService::sAdbTransportServices && !ResolvedService::sAdbSecureConnectServices) {
return std::nullopt;
}
CHECK(ResolvedService::sAdbTransportServices);
CHECK(ResolvedService::sAdbSecureConnectServices);
auto mdns_instance = mdns::mdns_parse_instance_name(name); auto mdns_instance = mdns::mdns_parse_instance_name(name);
if (!mdns_instance.has_value()) { if (!mdns_instance.has_value()) {
D("Failed to parse mDNS name [%s]", name.data()); D("Failed to parse mDNS name [%s]", name.data());