From cfb5ec3c283bb0fd5a99d6ed282a508be309d291 Mon Sep 17 00:00:00 2001 From: Rom Lemarchand Date: Fri, 11 Jan 2013 14:56:44 -0800 Subject: [PATCH] logwrap: remove unnecessary call to setuid/setgid Android allows all users to write to log. The setuid/setgid call is unneeded and could cause unintended side effects when called from daemons or programs that need to run as root. Change-Id: I3bdb26eaa4363ef037615e45a1a5cb1ceb4088f3 --- logwrapper/logwrap.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/logwrapper/logwrap.c b/logwrapper/logwrap.c index 09f8b814c..ef457def5 100644 --- a/logwrapper/logwrap.c +++ b/logwrapper/logwrap.c @@ -262,12 +262,6 @@ int logwrap(int argc, char* argv[], int *status) { signal_fd_write = sockets[0]; - // switch user and group to "log" - // this may fail if we are not root, - // but in that case switching user/group is unnecessary - setgid(AID_LOG); - setuid(AID_LOG); - rc = parent(argv[0], parent_ptty, sockets[1], pid, status); }