From d1e4c263c42691ff72e52ce9fe368d88fa778e2d Mon Sep 17 00:00:00 2001 From: Michael Hoisie Date: Wed, 6 Mar 2024 17:22:45 +0000 Subject: [PATCH] Remove the redundant libcutils_sockets_test 'sockets_test.cpp' also runs as part of libcutils_test and libcutils_static_test, so it is redundant to have it be a separate target. Test: libcutils_test Test: libcutils_static_test Bug: 317884162 Change-Id: Ib2c2f74feb79d1436ca67ae9aca18d3eb7acf5a0 --- libcutils/Android.bp | 26 ++++---------------------- 1 file changed, 4 insertions(+), 22 deletions(-) diff --git a/libcutils/Android.bp b/libcutils/Android.bp index 8ae7d9e59..b7752d902 100644 --- a/libcutils/Android.bp +++ b/libcutils/Android.bp @@ -116,27 +116,6 @@ cc_library { }, } -cc_test { - name: "libcutils_sockets_test", - test_suites: ["device-tests"], - static_libs: ["libbase", "libcutils_sockets"], - cflags: [ - "-Wall", - "-Wextra", - "-Werror", - ], - - srcs: ["sockets_test.cpp"], - target: { - android: { - srcs: [ - "android_get_control_file_test.cpp", - "android_get_control_socket_test.cpp", - ], - }, - }, -} - // some files must not be compiled when building against Mingw // they correspond to features not used by our host development tools // which are also hard or even impossible to port to native Win32 @@ -347,7 +326,10 @@ cc_test { cc_test { name: "KernelLibcutilsTest", - test_suites: ["general-tests", "vts"], + test_suites: [ + "general-tests", + "vts", + ], defaults: ["libcutils_test_static_defaults"], test_config: "KernelLibcutilsTest.xml", }