diff --git a/adb/adb_client.cpp b/adb/adb_client.cpp index db9b71087..d29c08e83 100644 --- a/adb/adb_client.cpp +++ b/adb/adb_client.cpp @@ -50,6 +50,15 @@ void adb_set_transport(TransportType type, const char* serial) __adb_serial = serial; } +void adb_get_transport(TransportType* type, const char** serial) { + if (type) { + *type = __adb_transport; + } + if (serial) { + *serial = __adb_serial; + } +} + void adb_set_tcp_specifics(int server_port) { __adb_server_port = server_port; diff --git a/adb/adb_client.h b/adb/adb_client.h index a9df4d7a6..d5cd9220a 100644 --- a/adb/adb_client.h +++ b/adb/adb_client.h @@ -39,6 +39,9 @@ bool adb_query(const std::string& service, std::string* _Nonnull result, // Set the preferred transport to connect to. void adb_set_transport(TransportType type, const char* _Nullable serial); +// Get the preferred transport to connect to. +void adb_get_transport(TransportType* _Nullable type, const char* _Nullable* _Nullable serial); + // Set TCP specifics of the transport to use. void adb_set_tcp_specifics(int server_port); diff --git a/adb/commandline.cpp b/adb/commandline.cpp index 37d114605..056b8c16f 100644 --- a/adb/commandline.cpp +++ b/adb/commandline.cpp @@ -1072,6 +1072,51 @@ static bool wait_for_device(const char* service, TransportType t, const char* se return adb_command(cmd); } +static bool adb_root(const char* command) { + std::string error; + ScopedFd fd; + + fd.Reset(adb_connect(android::base::StringPrintf("%s:", command), &error)); + if (!fd.valid()) { + fprintf(stderr, "adb: unable to connect for %s: %s\n", command, error.c_str()); + return false; + } + + // Figure out whether we actually did anything. + char buf[256]; + char* cur = buf; + ssize_t bytes_left = sizeof(buf); + while (bytes_left > 0) { + ssize_t bytes_read = adb_read(fd.fd(), cur, bytes_left); + if (bytes_read == 0) { + break; + } else if (bytes_read < 0) { + fprintf(stderr, "adb: error while reading for %s: %s\n", command, strerror(errno)); + return false; + } + cur += bytes_read; + bytes_left -= bytes_read; + } + + if (bytes_left == 0) { + fprintf(stderr, "adb: unexpected output length for %s\n", command); + return false; + } + + fflush(stdout); + WriteFdExactly(STDOUT_FILENO, buf, sizeof(buf) - bytes_left); + if (cur != buf && strstr(buf, "restarting") == nullptr) { + return true; + } + + // Give adbd 500ms to kill itself, then wait-for-device for it to come back up. + adb_sleep_ms(500); + TransportType type; + const char* serial; + adb_get_transport(&type, &serial); + return wait_for_device("wait-for-device", type, serial); +} + // Connects to the device "shell" service with |command| and prints the // resulting output. static int send_shell_command(TransportType transport_type, const char* serial, @@ -1632,8 +1677,6 @@ int adb_commandline(int argc, const char **argv) { !strcmp(argv[0], "reboot") || !strcmp(argv[0], "reboot-bootloader") || !strcmp(argv[0], "usb") || - !strcmp(argv[0], "root") || - !strcmp(argv[0], "unroot") || !strcmp(argv[0], "disable-verity") || !strcmp(argv[0], "enable-verity")) { std::string command; @@ -1645,8 +1688,9 @@ int adb_commandline(int argc, const char **argv) { command = android::base::StringPrintf("%s:", argv[0]); } return adb_connect_command(command); - } - else if (!strcmp(argv[0], "bugreport")) { + } else if (!strcmp(argv[0], "root") || !strcmp(argv[0], "unroot")) { + return adb_root(argv[0]) ? 0 : 1; + } else if (!strcmp(argv[0], "bugreport")) { if (argc != 1) return usage(); // No need for shell protocol with bugreport, always disable for // simplicity.