ACPR/android_system_core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

adbconnection: silence logspam.

Browse source 
Userdebug devices enable JDWP for every process, so if adbd is turned
off manually, we get an error message for every single process on the
system.

Bug: http://b/154319466
Test: manual
Change-Id: Ia702974d371e35497573c31e22cfb2b572334590
This commit is contained in:
Josh Gao 2020-04-17 14:42:25 -07:00
parent 04e9d07490
commit d81a805a4c
1 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
adb/libs/adbconnection/adbconnection_client.cpp
View file

@ -140,7 +140,13 @@ AdbConnectionClientContext* adbconnection_client_new(
int rc = connect(ctx->control_socket_.get(), reinterpret_cast<sockaddr*>(&addr), addr_len);
if (rc != 0) {
PLOG(ERROR) << "failed to connect to jdwp control socket";
if (errno == ECONNREFUSED) {
// On userdebug devices, every Java process is debuggable, so if adbd is explicitly turned
// off, this would spew enormous amounts of red-herring errors.
LOG(DEBUG) << "failed to connect to jdwp control socket, adbd not running?";
} else {
PLOG(ERROR) << "failed to connect to jdwp control socket";
}
return nullptr;
}