From dbf62d939a0faa0ecf5a55c8633b1c6bf2182d03 Mon Sep 17 00:00:00 2001 From: Bowgo Tsai Date: Mon, 3 Oct 2022 16:15:21 +0800 Subject: [PATCH] simg_dump.py: fix error for CHUNK_TYPE_FILL In python3, division of two integers produces a float, which cannot be used to multiply a bytes sequence. Using // to produce an integer quotient. Bug: 245257511 Test: ./system/core/libsparse/simg_dump.py -sv path/to/image Change-Id: Ibe95056409ac3676a68f5e7693331ca4a66e9fb7 --- libsparse/simg_dump.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libsparse/simg_dump.py b/libsparse/simg_dump.py index 8811a52fc..47537caf6 100755 --- a/libsparse/simg_dump.py +++ b/libsparse/simg_dump.py @@ -158,7 +158,7 @@ def main(): curtype = format("Fill with 0x%08X" % (fill)) if showhash: h = hashlib.sha1() - data = fill_bin * (blk_sz / 4); + data = fill_bin * (blk_sz // 4); for block in range(chunk_sz): h.update(data) curhash = h.hexdigest()