ACPR/android_system_core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

system/core: Make Thread::run threadName argument required

Browse source 
Bug: 27557176
Change-Id: Iae83a1e5489c86c2858fc8481f246b8480f0eec4
This commit is contained in:
Brian Carlstrom 2016-03-12 16:08:12 -08:00
parent 1ef5bf839e
commit e71b914775
3 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
include/utils/Thread.h
View file

@ -45,7 +45,7 @@ public:
virtual ~Thread(); virtual ~Thread();
// Start the thread in threadLoop() which needs to be implemented. // Start the thread in threadLoop() which needs to be implemented.
virtual status_t run( const char* name = 0, virtual status_t run( const char* name,
int32_t priority = PRIORITY_DEFAULT, int32_t priority = PRIORITY_DEFAULT,
size_t stack = 0); size_t stack = 0);

2
libutils/Threads.cpp
View file

@ -668,6 +668,8 @@ status_t Thread::readyToRun()
status_t Thread::run(const char* name, int32_t priority, size_t stack) status_t Thread::run(const char* name, int32_t priority, size_t stack)
{ {
LOG_ALWAYS_FATAL_IF(name == nullptr, "thread name not provided to Thread::run");
Mutex::Autolock _l(mLock); Mutex::Autolock _l(mLock);
if (mRunning) { if (mRunning) {

4
libutils/tests/Looper_test.cpp
View file

@ -138,7 +138,7 @@ TEST_F(LooperTest, PollOnce_WhenNonZeroTimeoutAndAwokenBeforeWaiting_Immediately
TEST_F(LooperTest, PollOnce_WhenNonZeroTimeoutAndAwokenWhileWaiting_PromptlyReturns) { TEST_F(LooperTest, PollOnce_WhenNonZeroTimeoutAndAwokenWhileWaiting_PromptlyReturns) {
sp<DelayedWake> delayedWake = new DelayedWake(100, mLooper); sp<DelayedWake> delayedWake = new DelayedWake(100, mLooper);
delayedWake->run(); delayedWake->run("LooperTest");
StopWatch stopWatch("pollOnce"); StopWatch stopWatch("pollOnce");
int result = mLooper->pollOnce(1000); int result = mLooper->pollOnce(1000);
@ -251,7 +251,7 @@ TEST_F(LooperTest, PollOnce_WhenNonZeroTimeoutAndSignalledFDWhileWaiting_Promptl
sp<DelayedWriteSignal> delayedWriteSignal = new DelayedWriteSignal(100, & pipe); sp<DelayedWriteSignal> delayedWriteSignal = new DelayedWriteSignal(100, & pipe);
handler.setCallback(mLooper, pipe.receiveFd, Looper::EVENT_INPUT); handler.setCallback(mLooper, pipe.receiveFd, Looper::EVENT_INPUT);
delayedWriteSignal->run(); delayedWriteSignal->run("LooperTest");
StopWatch stopWatch("pollOnce"); StopWatch stopWatch("pollOnce");
int result = mLooper->pollOnce(1000); int result = mLooper->pollOnce(1000);