diff --git a/logd/LogBufferElement.h b/logd/LogBufferElement.h index ca2c3a62c..4877939c6 100644 --- a/logd/LogBufferElement.h +++ b/logd/LogBufferElement.h @@ -25,27 +25,6 @@ #include #include -// Hijack this header as a common include file used by most all sources -// to report some utilities defined here and there. - -namespace android { - -// Furnished in main.cpp. Caller must own and free returned value -char *uidToName(uid_t uid); - -// Furnished in LogStatistics.cpp. Caller must own and free returned value -char *pidToName(pid_t pid); -char *tidToName(pid_t tid); - -// Furnished in main.cpp. Thread safe. -const char *tagToName(uint32_t tag); - -} - -static inline bool worstUidEnabledForLogid(log_id_t id) { - return (id != LOG_ID_CRASH) && (id != LOG_ID_KERNEL) && (id != LOG_ID_EVENTS); -} - class LogBuffer; #define EXPIRE_HOUR_THRESHOLD 24 // Only expire chatty UID logs to preserve diff --git a/logd/LogStatistics.h b/logd/LogStatistics.h index 61000d284..20e630eb7 100644 --- a/logd/LogStatistics.h +++ b/logd/LogStatistics.h @@ -26,6 +26,7 @@ #include #include "LogBufferElement.h" +#include "LogUtils.h" #define log_id_for_each(i) \ for (log_id_t i = LOG_ID_MIN; i < LOG_ID_MAX; i = (log_id_t) (i + 1)) diff --git a/logd/LogUtils.h b/logd/LogUtils.h new file mode 100644 index 000000000..117bc59e5 --- /dev/null +++ b/logd/LogUtils.h @@ -0,0 +1,45 @@ +/* + * Copyright (C) 2012-2015 The Android Open Source Project + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#ifndef _LOGD_LOG_UTILS_H__ +#define _LOGD_LOG_UTILS_H__ + +#include + +#include + +// Hijack this header as a common include file used by most all sources +// to report some utilities defined here and there. + +namespace android { + +// Furnished in main.cpp. Caller must own and free returned value +char *uidToName(uid_t uid); + +// Furnished in LogStatistics.cpp. Caller must own and free returned value +char *pidToName(pid_t pid); +char *tidToName(pid_t tid); + +// Furnished in main.cpp. Thread safe. +const char *tagToName(uint32_t tag); + +} + +static inline bool worstUidEnabledForLogid(log_id_t id) { + return (id != LOG_ID_CRASH) && (id != LOG_ID_KERNEL) && (id != LOG_ID_EVENTS); +} + +#endif // _LOGD_LOG_UTILS_H__ diff --git a/logd/LogWhiteBlackList.h b/logd/LogWhiteBlackList.h index 00e1cad2d..6f17402a4 100644 --- a/logd/LogWhiteBlackList.h +++ b/logd/LogWhiteBlackList.h @@ -22,7 +22,7 @@ #include #include -#include +#include "LogBufferElement.h" // White and Blacklist diff --git a/logd/main.cpp b/logd/main.cpp index 837c2ce33..2ed52be08 100644 --- a/logd/main.cpp +++ b/logd/main.cpp @@ -47,6 +47,7 @@ #include "LogListener.h" #include "LogAudit.h" #include "LogKlog.h" +#include "LogUtils.h" #define KMSG_PRIORITY(PRI) \ '<', \