ACPR/android_system_core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge "libutils: disallow extending lifetime on stack"

Browse source
This commit is contained in:
Steven Moreland 2022-07-28 23:17:35 +00:00 • committed by Gerrit Code Review
commit ea25b4ba5b
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
libutils/RefBase.cpp
View file

@ -797,6 +797,8 @@ RefBase::~RefBase()
void RefBase::extendObjectLifetime(int32_t mode) void RefBase::extendObjectLifetime(int32_t mode)
{ {
check_not_on_stack(this);
// Must be happens-before ordered with respect to construction or any // Must be happens-before ordered with respect to construction or any
// operation that could destroy the object. // operation that could destroy the object.
mRefs->mFlags.fetch_or(mode, std::memory_order_relaxed); mRefs->mFlags.fetch_or(mode, std::memory_order_relaxed);