From ebbf9753e9520e9ae6e789b7463eb6d201bd0f07 Mon Sep 17 00:00:00 2001 From: Kiyoung Kim Date: Wed, 29 Nov 2023 13:55:54 +0900 Subject: [PATCH] Deprecate android_is_in_vendor_process android_is_in_vnedor_process previously checked if current process is in system(-ish) section by trying to open vndk namespace. However, this would not work once VNDK is deprecated. As there is no clear way to replace this, and there is few usage on this API, it would be better deprecated, and be implemented from each module if required. Bug: 300366609 Test: AOSP CF build and boot succeeded Change-Id: I70c70efb36199e12d4877ea4ecb39dbf94653551 --- libvndksupport/include/vndksupport/linker.h | 11 ++--------- libvndksupport/libvndksupport.map.txt | 2 +- 2 files changed, 3 insertions(+), 10 deletions(-) diff --git a/libvndksupport/include/vndksupport/linker.h b/libvndksupport/include/vndksupport/linker.h index 5f48c3974..684513565 100644 --- a/libvndksupport/include/vndksupport/linker.h +++ b/libvndksupport/include/vndksupport/linker.h @@ -20,15 +20,8 @@ extern "C" { #endif -/* - * Returns whether the current process is a vendor process. - * - * Note that this is only checking what process is running and has nothing to - * do with what namespace the caller is loaded at. For example, a VNDK-SP - * library loaded by SP-HAL calling this function may still get a 'false', - * because it is running in a system process. - */ -int android_is_in_vendor_process(); +int android_is_in_vendor_process() __attribute__(( + deprecated("This function would not give exact result if VNDK is deprecated."))); void* android_load_sphal_library(const char* name, int flag); diff --git a/libvndksupport/libvndksupport.map.txt b/libvndksupport/libvndksupport.map.txt index 1d94b9dcb..fc2502dcb 100644 --- a/libvndksupport/libvndksupport.map.txt +++ b/libvndksupport/libvndksupport.map.txt @@ -1,6 +1,6 @@ LIBVNDKSUPPORT { global: - android_is_in_vendor_process; # llndk systemapi + android_is_in_vendor_process; # systemapi android_load_sphal_library; # llndk systemapi android_unload_sphal_library; # llndk systemapi local: