From ec0c886da6ff8a1f2855f496b40fd4459c74e7ea Mon Sep 17 00:00:00 2001 From: Chenjie Yu Date: Thu, 7 Sep 2017 08:06:15 -0700 Subject: [PATCH] add aid check when writting into logd stats buffer. For now we require aid to be system. Change-Id: I9e701a3146c3269d7e3f315c1182391de5e8cc63 Test: will add tests later --- logd/LogListener.cpp | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/logd/LogListener.cpp b/logd/LogListener.cpp index d2df68eef..0bd4008b1 100644 --- a/logd/LogListener.cpp +++ b/logd/LogListener.cpp @@ -101,6 +101,14 @@ bool LogListener::onDataAvailable(SocketClient* cli) { return false; } + if (header->id == LOG_ID_STATS) { + // Only accept logging from *ManagerService in system server + // Will add more later as we see fit. + if (cred->uid != AID_SYSTEM && cred->gid != AID_SYSTEM) { + return false; + } + } + // Check credential validity, acquire corrected details if not supplied. if (cred->pid == 0) { cred->pid = logbuf ? logbuf->tidToPid(header->tid)