diff --git a/libnativeloader/include/nativeloader/native_loader.h b/libnativeloader/include/nativeloader/native_loader.h index da072530e..2dec71f1e 100644 --- a/libnativeloader/include/nativeloader/native_loader.h +++ b/libnativeloader/include/nativeloader/native_loader.h @@ -19,6 +19,9 @@ #include "jni.h" #include +#if defined(__ANDROID__) +#include +#endif namespace android { @@ -27,6 +30,13 @@ void* OpenNativeLibrary(JNIEnv* env, int32_t target_sdk_version, const char* pat jobject class_loader, bool is_shared, jstring library_path, jstring permitted_path); +#if defined(__ANDROID__) +// Look up linker namespace by class_loader. Returns nullptr if +// there is no namespace associated with the class_loader. +__attribute__((visibility("default"))) +android_namespace_t* FindNamespaceByClassLoader(JNIEnv* env, jobject class_loader); +#endif + }; // namespace android #endif // NATIVE_BRIDGE_H_ diff --git a/libnativeloader/native_loader.cpp b/libnativeloader/native_loader.cpp index a2d79e1f5..8b8dee3b2 100644 --- a/libnativeloader/native_loader.cpp +++ b/libnativeloader/native_loader.cpp @@ -81,10 +81,10 @@ class LibraryNamespaces { std::lock_guard guard(mutex_); - auto it = FindNamespaceByClassLoader(env, class_loader); + android_namespace_t* ns = FindNamespaceByClassLoader(env, class_loader); - if (it != namespaces_.end()) { - return it->second; + if (ns != nullptr) { + return ns; } uint64_t namespace_type = ANDROID_NAMESPACE_TYPE_ISOLATED; @@ -92,20 +92,27 @@ class LibraryNamespaces { namespace_type |= ANDROID_NAMESPACE_TYPE_SHARED; } - android_namespace_t* ns = - android_create_namespace("classloader-namespace", - nullptr, - library_path.c_str(), - namespace_type, - java_permitted_path != nullptr ? - permitted_path.c_str() : - nullptr); + ns = android_create_namespace("classloader-namespace", + nullptr, + library_path.c_str(), + namespace_type, + java_permitted_path != nullptr ? + permitted_path.c_str() : + nullptr); namespaces_.push_back(std::make_pair(env->NewWeakGlobalRef(class_loader), ns)); return ns; } + android_namespace_t* FindNamespaceByClassLoader(JNIEnv* env, jobject class_loader) { + auto it = std::find_if(namespaces_.begin(), namespaces_.end(), + [&](const std::pair& value) { + return env->IsSameObject(value.first, class_loader); + }); + return it != namespaces_.end() ? it->second : nullptr; + } + private: void PreloadPublicLibraries() { // android_init_namespaces() expects all the public libraries @@ -133,14 +140,6 @@ class LibraryNamespaces { return initialized_; } - std::vector>::const_iterator - FindNamespaceByClassLoader(JNIEnv* env, jobject class_loader) { - return std::find_if(namespaces_.begin(), namespaces_.end(), - [&](const std::pair& value) { - return env->IsSameObject(value.first, class_loader); - }); - } - bool initialized_; std::mutex mutex_; std::vector> namespaces_; @@ -180,4 +179,10 @@ void* OpenNativeLibrary(JNIEnv* env, int32_t target_sdk_version, const char* pat #endif } +#if defined(__ANDROID__) +android_namespace_t* FindNamespaceByClassLoader(JNIEnv* env, jobject class_loader) { + return g_namespaces->FindNamespaceByClassLoader(env, class_loader); +} +#endif + }; // android namespace