ACPR/android_system_core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

crash_sender: upload oldest crashes first

Browse source 
The current logic is sorting crashes by date (which is good), except it
sorts it such that the newest is first (which is bad).

This means if a new process continues to crash, old crash reports will
be perpetually stalled (it's a stack).  Instead, let's start with the
oldest first (like a fifo).

BUG=chromium:326583
TEST=`cbuildbot x86-generic-full` passes VMTests

Change-Id: Ifadedba80cb8c602c094c91d419e4d9645abda51
Reviewed-on: https://chromium-review.googlesource.com/179210
Reviewed-by: Ben Chan <benchan@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
This commit is contained in:
Mike Frysinger 2013-12-06 18:19:01 -05:00 • committed by chrome-internal-fetch
parent 9f3bf88120
commit f4c39b09f4
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
crash_reporter/crash_sender
View file

@ -490,7 +490,7 @@ send_crashes() {
done
# Look through all metadata (*.meta) files, if any exist.
for meta_path in $(ls -1t "${dir}"/*.meta 2>/dev/null); do
for meta_path in $(ls -1tr "${dir}"/*.meta 2>/dev/null); do
lecho "Considering metadata ${meta_path}."
local kind=$(get_kind "${meta_path}")