ACPR/android_system_core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

bootstat: Fix a potential unhandled exception for malformed input.

Browse source 
In rare cases the hardware storage on the device may be hosed and return
garbage.  Use ParseInt which handles bad input instead of stoi.

BUG: 29334139
Change-Id: I91aedc169df110bea8097775f73dda11def22311
(cherry picked from commit 4dded613b3)
This commit is contained in:
James Hawkins 2016-07-28 11:50:23 -07:00
parent a6cb3062ff
commit f85554e12f
2 changed files with 14 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
bootstat/boot_event_record_store.cpp
View file

@ -25,6 +25,7 @@
#include <utility>
#include <android-base/file.h>
#include <android-base/logging.h>
#include <android-base/parseint.h>
#include "histogram_logger.h"
#include "uptime_parser.h"
@ -57,8 +58,10 @@ bool ParseRecordEventTime(const std::string& path, int32_t* uptime) {
// Ignore existing bootstat records (which do not contain file content).
if (!content.empty()) {
int32_t value = std::stoi(content);
bootstat::LogHistogram("bootstat_mtime_matches_content", value == *uptime);
int32_t value;
if (android::base::ParseInt(content.c_str(), &value)) {
bootstat::LogHistogram("bootstat_mtime_matches_content", value == *uptime);
}
}
return true;

10
bootstat/bootstat.cpp
View file

@ -28,6 +28,7 @@
#include <memory>
#include <string>
#include <android-base/logging.h>
#include <android-base/parseint.h>
#include <cutils/properties.h>
#include <log/log.h>
#include "boot_event_record_store.h"
@ -147,7 +148,10 @@ std::string CalculateBootCompletePrefix() {
std::string boot_complete_prefix = "boot_complete";
std::string build_date_str = GetProperty("ro.build.date.utc");
int32_t build_date = std::stoi(build_date_str);
int32_t build_date;
if (!android::base::ParseInt(build_date_str.c_str(), &build_date)) {
return std::string();
}
BootEventRecordStore boot_event_store;
BootEventRecordStore::BootEventRecord record;
@ -171,6 +175,10 @@ void RecordBootComplete() {
// ota_boot_complete. The latter signifies that the device is booting after
// a system update.
std::string boot_complete_prefix = CalculateBootCompletePrefix();
if (boot_complete_prefix.empty()) {
// The system is hosed because the build date property could not be read.
return;
}
// post_decrypt_time_elapsed is only logged on encrypted devices.
if (boot_event_store.GetBootEvent("post_decrypt_time_elapsed", &record)) {