From cdf919d1f0a6aec03f4aebcf0c0b9b52781492f2 Mon Sep 17 00:00:00 2001 From: Pirama Arumuga Nainar Date: Wed, 25 Aug 2021 22:14:50 -0700 Subject: [PATCH] [fs_mgr] Use shared libutils for remount Bug: http://b/197965342 remount depends on libbinder.so which already depends on libutils.so. When linking remount with libutils.a, the linker tries to fetch objects from libutils.a to redefine undefined symbols in libbinder.so. This causes linker failure with upstream LLD. Switching to shared libutils.so instead doesn't increase the dependency closure for remount. Test: build with aosp/1809741 which has lld with the above behavior. Change-Id: I858042a08babe2c2db1fc8c7eeb5de62dda5f328 --- fs_mgr/Android.bp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs_mgr/Android.bp b/fs_mgr/Android.bp index 7ae526f72..cb74ae09b 100644 --- a/fs_mgr/Android.bp +++ b/fs_mgr/Android.bp @@ -215,7 +215,6 @@ cc_binary { static_libs: [ "libavb_user", "libgsid", - "libutils", "libvold_binder", ], shared_libs: [ @@ -230,6 +229,7 @@ cc_binary { "liblog", "liblp", "libselinux", + "libutils", ], header_libs: [ "libcutils_headers",