From fbbf27da028964d3057382b4aa305cf785173777 Mon Sep 17 00:00:00 2001 From: Tom Cherry Date: Thu, 26 Oct 2017 10:50:20 -0700 Subject: [PATCH] Add test for android::base::Split with a trailing empty part. Test: this new unit test Change-Id: Ia14ba878f2866e333a69f1e6f7f56b66a7e657a5 --- base/strings_test.cpp | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/base/strings_test.cpp b/base/strings_test.cpp index 7ed5b2b08..121197cab 100644 --- a/base/strings_test.cpp +++ b/base/strings_test.cpp @@ -51,6 +51,14 @@ TEST(strings, split_with_empty_part) { ASSERT_EQ("bar", parts[2]); } +TEST(strings, split_with_trailing_empty_part) { + std::vector parts = android::base::Split("foo,bar,", ","); + ASSERT_EQ(3U, parts.size()); + ASSERT_EQ("foo", parts[0]); + ASSERT_EQ("bar", parts[1]); + ASSERT_EQ("", parts[2]); +} + TEST(strings, split_null_char) { std::vector parts = android::base::Split(std::string("foo\0bar", 7), std::string("\0", 1));