ACPR/android_system_core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge "adb: treat non-successful inc-server runs as failures"

Browse source
This commit is contained in:
Treehugger Robot 2020-06-03 21:28:53 +00:00 • committed by Gerrit Code Review
commit ff502379b7
1 changed files with 9 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
adb/client/incremental.cpp
View file

@ -180,7 +180,7 @@ std::optional<Process> install(const Files& files, const Args& passthrough_args,
int print_fds[2];
if (adb_socketpair(print_fds) != 0) {
if (!silent) {
fprintf(stderr, "Failed to create socket pair for child to print to parent\n");
fprintf(stderr, "adb: failed to create socket pair for child to print to parent\n");
}
return {};
}
@ -207,10 +207,15 @@ std::optional<Process> install(const Files& files, const Args& passthrough_args,
Result result = wait_for_installation(pipe_read_fd);
adb_close(pipe_read_fd);
if (result == Result::Success) {
// adb client exits now but inc-server can continue
serverKiller.release();
if (result != Result::Success) {
if (!silent) {
fprintf(stderr, "adb: install command failed");
}
return {};
}
// adb client exits now but inc-server can continue
serverKiller.release();
return child;
}