ACPR/android_system_core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge "Cleanup some trivial TODOs."

Browse source
This commit is contained in:
Tom Cherry 2020-04-13 15:39:49 +00:00 • committed by Gerrit Code Review
commit ffe39ea541
4 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
base/properties.cpp
View file

@ -133,7 +133,6 @@ static void DurationToTimeSpec(timespec& ts, const std::chrono::milliseconds d)
ts.tv_nsec = ns.count();
}
// TODO: boot_clock?
using AbsTime = std::chrono::time_point<std::chrono::steady_clock>;
static void UpdateTimeSpec(timespec& ts, std::chrono::milliseconds relative_timeout,

2
init/parser.cpp
View file

@ -41,7 +41,7 @@ void Parser::AddSingleLineParser(const std::string& prefix, LineCallback callbac
}
void Parser::ParseData(const std::string& filename, std::string* data) {
data->push_back('\n'); // TODO: fix tokenizer
data->push_back('\n');
data->push_back('\0');
parse_state state;

2
init/tokenizer_test.cpp
View file

@ -28,7 +28,7 @@ namespace {
void RunTest(const std::string& data, const std::vector<std::vector<std::string>>& expected_tokens) {
auto data_copy = std::string{data};
data_copy.push_back('\n'); // TODO: fix tokenizer
data_copy.push_back('\n');
data_copy.push_back('\0');
parse_state state;

1
init/ueventd.cpp
View file

@ -285,7 +285,6 @@ int ueventd_main(int argc, char** argv) {
// Keep the current product name base configuration so we remain backwards compatible and
// allow it to override everything.
// TODO: cleanup platform ueventd.rc to remove vendor specific device node entries (b/34968103)
auto hardware = android::base::GetProperty("ro.hardware", "");
auto ueventd_configuration = ParseConfig({"/system/etc/ueventd.rc", "/vendor/ueventd.rc",