Josh Gao
c2102a7b8f
Merge "adb: fix progress percentage when pulling symlinks."
...
am: 453db013b0
2016-11-18 02:17:56 +00:00
Treehugger Robot
453db013b0
Merge "adb: fix progress percentage when pulling symlinks."
2016-11-18 02:13:19 +00:00
Josh Gao
da1f279509
adb: fix progress percentage when pulling symlinks.
...
The adb protocol currently only supports lstat with no way of finding
the target of a symlink, so pulling a symlink that points to a file
looks like pulling a file with length equal to the length of path to
the symlink's target. Pulling a file that's sufficiently large can
overflow the int used to calculate percentage, and result in a bogus
completion percentage being displayed.
Bug: http://b/29277448
Test: adb pull /dev/block/platform/soc.0/f9824900.sdhci/by-name/system
Change-Id: I42d180550ac2aa9e4705676ccbb20f5db789fb8d
2016-11-17 16:17:07 -08:00
Elliott Hughes
8e5fb5a0e7
Merge "Remove dead code."
...
am: 3bde05d928
2016-11-17 20:39:22 +00:00
Treehugger Robot
3bde05d928
Merge "Remove dead code."
2016-11-17 20:29:10 +00:00
Elliott Hughes
284f07bd9d
Remove dead code.
...
At this point, we can't write to oom_score_adj anyway.
Bug: https://code.google.com/p/android/issues/detail?id=227721
Test: boots, adb shell still works
Change-Id: I07e6ad32765f6582f316973547a3a3d552808287
2016-11-17 10:32:16 -08:00
Josh Gao
27bbe8bfb2
Merge "adb: add sysdeps/chrono.h for chrono literals on Win32."
...
am: e631e470e0
2016-11-16 22:29:30 +00:00
Josh Gao
4602adbcd3
adb: add sysdeps/chrono.h for chrono literals on Win32.
...
Bug: http://b/32878766
Test: mma
Change-Id: Iaa89d4eadf07e63d6d7205057435a6c7fb5d4ec5
2016-11-16 12:14:59 -08:00
Elliott Hughes
2278b50f24
Merge "Switch adb over to <chrono>."
...
am: 59826ddee5
2016-11-16 20:14:20 +00:00
Elliott Hughes
dbe91eee26
Switch adb over to <chrono>.
...
Clearer code, and lets us lose some more portability cruft.
Bug: http://b/32878766
Test: manual
Change-Id: Ie44928bbf8d68a74127aaf76e7e0060e25fa2cc8
2016-11-16 09:12:12 -08:00
Jin Qian
c6fbcd7579
Merge "Set file capabilities after writing file data"
...
am: dd4e5ae943
2016-11-03 17:29:31 +00:00
Jin Qian
d0515e7165
Set file capabilities after writing file data
...
File capabilities will be cleared if we set them before writing file data.
Bug: 32543395
Change-Id: I88cc0a0ec23cd6fc6dbe86c93a76914809d7e5f9
2016-11-02 16:37:11 -07:00
Josh Gao
1d51d6d6aa
Merge "adb: add adb reconnect offline to reconnect offline devices."
...
am: 0945380e36
2016-10-31 21:33:19 +00:00
Josh Gao
0945380e36
Merge "adb: add adb reconnect offline to reconnect offline devices."
2016-10-31 21:26:23 +00:00
Josh Gao
22d2b3e1c2
adb: add adb reconnect offline to reconnect offline devices.
...
Add a command to reconnect offline/unauthorized devices, mainly for use
with the inotify-monitoring of vendor key directories added by 2e671202http://b/29273531
Test: manually tested with a sailfish + copying vendor keys
Change-Id: If34cccee4ae553ada65d128b57d03cba8c0d7c46
2016-10-27 17:13:23 -07:00
Elliott Hughes
a4f497e0a2
Merge "Make "adb logcat" pass $ANDROID_LOG_TAGS through again."
...
am: b838ff65d9
2016-10-27 01:10:07 +00:00
Elliott Hughes
90390302d5
Make "adb logcat" pass $ANDROID_LOG_TAGS through again.
...
But not for Windows, because even dealing with environment variables is
too hard there (and no Windows user has complained yet).
Bug: http://b/30184452
Test: manual
Change-Id: I2d60049ed0049a9532414a7cdecbd0687e06aba7
2016-10-26 15:12:14 -07:00
Elliott Hughes
66321bc889
Merge "Improve "adb install" diagnostics."
...
am: a16ae8717c
2016-10-26 18:37:34 +00:00
Treehugger Robot
a16ae8717c
Merge "Improve "adb install" diagnostics."
2016-10-26 18:25:59 +00:00
Elliott Hughes
02ee1725ae
Merge "Make "adb bugreport"'s .zip check case-insensitive."
...
am: da6fe65000
2016-10-26 15:39:50 +00:00
Elliott Hughes
7acce1b0ab
Make "adb bugreport"'s .zip check case-insensitive.
...
Bug: TODO
Test: manual
Change-Id: I0ece7d8dcb708e3755477f7df5ff03807fd227f2
2016-10-25 17:24:54 -07:00
Elliott Hughes
7288478443
Improve "adb install" diagnostics.
...
Bug: http://b/32094640
Test: manual testing
Change-Id: I661936eabd3bdd8aa7ee8cc0e398a7cc7d4ddbbb
2016-10-25 17:23:40 -07:00
Elliott Hughes
e060cdadc8
Merge "Allow multiple tcp adb connection to same device."
...
am: 4818194a25
2016-10-24 23:36:44 +00:00
Elliott Hughes
4818194a25
Merge "Allow multiple tcp adb connection to same device."
2016-10-24 23:31:14 +00:00
Josh Gao
8baf1198ee
adb: fix test_sighup.
...
am: 470622f064
2016-10-24 21:18:58 +00:00
Josh Gao
a06580956e
adb: fix race condition in test_non_interactive_sigint.
...
am: e76b9f3dde
2016-10-24 21:18:51 +00:00
Josh Gao
63660add3f
Merge changes I34ba5757,Ie65a762a
...
* changes:
adb: fix test_sighup.
adb: fix race condition in test_non_interactive_sigint.
2016-10-24 21:13:18 +00:00
Josh Gao
470622f064
adb: fix test_sighup.
...
Bug: http://b/32336914
Test: python test_device.py
Change-Id: I34ba5757b5e650d79327dc6779064acd850ce28e
2016-10-24 13:34:20 -07:00
Josh Gao
e76b9f3dde
adb: fix race condition in test_non_interactive_sigint.
...
Fix race condition in the test_non_interactive_sigint test by
looping for a while.
Bug: http://b/32336914
Test: python test_device.py
Change-Id: Ie65a762ad6f04815231add5444762c4c0ffd31cb
2016-10-24 13:34:17 -07:00
Tao Wu
043912ec11
Allow multiple tcp adb connection to same device.
...
This worked before Kitkat, and then we lost this feature in Kitkat.
Now I make the register logic in server_socket_thread as same as qemu_socket_thread.
Test: manual - build emulator image and connect from different adb client.
Bug: 32341562
Change-Id: I7b4831d280048d2a3796be3522bd3b8fbc1ade6b
Signed-off-by: Tao Wu <lepton@google.com>
2016-10-22 12:54:30 -07:00
Elliott Hughes
f58d06a918
Merge "Move "adb shell" over to getopt(3), and allow -tt on old devices."
...
am: 620469a4ac
2016-10-22 18:11:44 +00:00
Elliott Hughes
cabfa1177f
Move "adb shell" over to getopt(3), and allow -tt on old devices.
...
From the bug:
Say we run a new adb against an old device (like KitKat). Even with a new
client ADB, in this configuration, "adb shell" will create a remove tty
unconditionally. So if the user runs "adb shell -t -t", we shouldn't fail
with a message about the remote device not supporting -tT options --- the
user asked to create a tty unconditionally, and since we're going to create
a tty unconditionally, we should just succeed. (That it's going to succeed
due to protocol inadequacy instead of succeeding on purpose is irrelevant.)
That adb fails in this case makes scripts more complicated, since they can't
just pass "-t -t" unconditionally if they want a tty and to work on all
device versions, even if the script requires a new-ish adb locally.
Bug: http://b/32216152
Bug: http://b/32219151
Test: test_device.py
Change-Id: I8ab7c8dfa212209a7ab43c1f0832eeac26d2e42f
2016-10-21 14:22:40 -07:00
Ting-Yuan Huang
e02e11835d
Merge "adb: fix undefined behavior"
...
am: 1edd61ce5d
2016-10-20 04:38:12 +00:00
Ting-Yuan Huang
ef57d54f80
adb: fix undefined behavior
...
system/core/adb/shell_service_protocol_test.cpp:94:14: warning: Null
passed to a callee that requires a non-null 1st parameter
!memcmp(data, protocol->data(), data_length));
C99 requires memcmp() to take non-null pointers.
Bug: none
Test: clang-tidy doesn't complain
Change-Id: I77b8d9373fa257a070ffc7fd318231c2c9ea84c3
2016-10-19 19:39:44 -07:00
Mark Salyzyn
8648bddf24
adb: use __android_log_is_debuggable()
...
am: 97787a00e6
2016-10-18 16:46:15 +00:00
Mark Salyzyn
97787a00e6
adb: use __android_log_is_debuggable()
...
Test: compile and months of adb functionality use
Bug: 27566046
Bug: 31456426
Change-Id: I6568eea0eda8dc67dec2ba34cd4c3f56fb0ff0e9
2016-10-14 11:12:24 -07:00
Elliott Hughes
19340be9fe
Merge "Rely on the platform -std default." am: 955648a915 am: 4594f50635
...
am: f1dffe0501
2016-10-14 02:56:09 +00:00
Elliott Hughes
f1dffe0501
Merge "Rely on the platform -std default." am: 955648a915
...
am: 4594f50635
2016-10-14 02:47:44 +00:00
Elliott Hughes
4594f50635
Merge "Rely on the platform -std default."
...
am: 955648a915
2016-10-14 02:45:03 +00:00
Treehugger Robot
955648a915
Merge "Rely on the platform -std default."
2016-10-14 02:28:38 +00:00
Tao Wu
4b9774fe97
Merge "Fallback to IPv6 when IPv4 is not available in adb" am: c32d7fd66f am: 5b7c6772b0
...
am: 27c6c4cf04
2016-10-14 01:51:54 +00:00
Elliott Hughes
a4398c1abe
Merge "Move off std::sto* function which abort on failure."
2016-10-14 01:51:10 +00:00
Tao Wu
27c6c4cf04
Merge "Fallback to IPv6 when IPv4 is not available in adb" am: c32d7fd66f
...
am: 5b7c6772b0
2016-10-14 01:46:26 +00:00
Tao Wu
5b7c6772b0
Merge "Fallback to IPv6 when IPv4 is not available in adb"
...
am: c32d7fd66f
2016-10-14 01:43:55 +00:00
Elliott Hughes
da46b392f1
Move off std::sto* function which abort on failure.
...
Bug: http://b/31403370
Test: builds, boots, libbase tests pass
Change-Id: I89cd7ca3d8f1c8a1bad0ddf3043439449d19a293
2016-10-13 15:34:05 -07:00
Tao Wu
7b700763f5
Fallback to IPv6 when IPv4 is not available in adb
...
Test: manual - make sure it works in both IPv4/IPv6 env.
BUG: 31537253
Change-Id: Ica492bff34a8c0441516a213d0e8b78fcdfd3282
Signed-off-by: Tao Wu <lepton@google.com>
2016-10-13 08:54:43 -07:00
Elliott Hughes
fc485e4488
Merge "Start retiring socket_loopback_client." am: 58f7f61266 am: cd0e8cfd33
...
am: aa509a3e9d
2016-10-13 15:00:24 +00:00
Elliott Hughes
aa509a3e9d
Merge "Start retiring socket_loopback_client." am: 58f7f61266
...
am: cd0e8cfd33
2016-10-13 14:50:50 +00:00
Elliott Hughes
cd0e8cfd33
Merge "Start retiring socket_loopback_client."
...
am: 58f7f61266
2016-10-13 14:43:05 +00:00
Elliott Hughes
58f7f61266
Merge "Start retiring socket_loopback_client."
2016-10-13 14:38:48 +00:00
