android_system_core

ACPR/android_system_core

Fork 0

Commit graph

Author	SHA1	Message	Date
Tom Cherry	f274e78eeb	fs_mgr/init: use unique_ptr + CLO_EXEC for setmntent()/fopen() We ran into an issue with an fd leaking due to missing both CLO_EXEC and fclose() in related code, so let's make sure we're safe here too. Test: boot Change-Id: Ief893c936859815c78fa6d7e06cb88ad34aadbac	2018-10-03 13:19:04 -07:00
Mark Salyzyn	eba4706a2e	fs_mgr: Add support in fs_mgr_read_fstab_file for /proc/mounts Generate fstab from /proc/mounts. Basically like any regular fstab minus the requirement for the Android fs_mgr_flags. Added a unit test to confirm that fs_mgr_read_fstab("/proc/mounts") matches the setmntent("/proc/mounts")+getmntent() content. As a result, discovered a bug in parse_flags that would report "ro" if the "rootcontext=..." flag was referenced. Test: fs_mgr_unit_test Bug: 109821005 Change-Id: I635ee979e11ee089b09adbedb5f42b6ba78026de	2018-06-27 14:49:06 -07:00
Mark Salyzyn	596fac3c6d	fs_mgr: fs_mgr_get_boot_config_from_kernel_cmdline deal with quote Spans quoted with " are dealt with atomically, and are stripped from the key/value results when parsing the kernel cmdline. Test: compile, device boot, fs_mgr_unit_test Bug: 109821005 Change-Id: I45f3d7395f34295edefdeaafa4c15c6ee25cc4da	2018-06-08 16:04:17 -07:00

Author

SHA1

Message

Date

Tom Cherry

f274e78eeb

fs_mgr/init: use unique_ptr + CLO_EXEC for setmntent()/fopen()

We ran into an issue with an fd leaking due to missing both CLO_EXEC
and fclose() in related code, so let's make sure we're safe here too.

Test: boot
Change-Id: Ief893c936859815c78fa6d7e06cb88ad34aadbac

2018-10-03 13:19:04 -07:00

Mark Salyzyn

eba4706a2e

fs_mgr: Add support in fs_mgr_read_fstab_file for /proc/mounts

Generate fstab from /proc/mounts.  Basically like any regular fstab
minus the requirement for the Android fs_mgr_flags.  Added a unit
test to confirm that fs_mgr_read_fstab("/proc/mounts") matches the
setmntent("/proc/mounts")+getmntent() content.

As a result, discovered a bug in parse_flags that would report "ro"
if the "rootcontext=..." flag was referenced.

Test: fs_mgr_unit_test
Bug: 109821005
Change-Id: I635ee979e11ee089b09adbedb5f42b6ba78026de

2018-06-27 14:49:06 -07:00

Mark Salyzyn

596fac3c6d

fs_mgr: fs_mgr_get_boot_config_from_kernel_cmdline deal with quote

Spans quoted with " are dealt with atomically, and are stripped from
the key/value results when parsing the kernel cmdline.

Test: compile, device boot, fs_mgr_unit_test
Bug: 109821005
Change-Id: I45f3d7395f34295edefdeaafa4c15c6ee25cc4da

2018-06-08 16:04:17 -07:00

3 commits