Hans Boehm
a1709d5269
Merge "Make RefBase more robust and debuggable" am: daac359be7 am: 7bf3d21fde am: 7dddf9433c
...
am: 2d3545fe82
2016-08-25 00:14:54 +00:00
Hans Boehm
2d3545fe82
Merge "Make RefBase more robust and debuggable" am: daac359be7 am: 7bf3d21fde
...
am: 7dddf9433c
2016-08-24 23:52:14 +00:00
Hans Boehm
7dddf9433c
Merge "Make RefBase more robust and debuggable" am: daac359be7
...
am: 7bf3d21fde
2016-08-24 23:49:14 +00:00
Hans Boehm
daac359be7
Merge "Make RefBase more robust and debuggable"
2016-08-24 23:36:13 +00:00
Andy Hung
e131ea2a25
Fix Mutex::timedLock to properly handle relative time am: 604ba48220 am: 708b9d118a am: 47e5ca61e2
...
am: 8ec6753d61
2016-08-24 23:08:27 +00:00
Andy Hung
8ec6753d61
Fix Mutex::timedLock to properly handle relative time am: 604ba48220 am: 708b9d118a
...
am: 47e5ca61e2
2016-08-24 22:50:00 +00:00
Andy Hung
604ba48220
Fix Mutex::timedLock to properly handle relative time
...
Bug: 31008450
Change-Id: Ie6c17e17b7a8c3d8a087c47be535e9d04f285380
2016-08-24 22:29:11 +00:00
Mark Salyzyn
0b6f5ea819
Merge "liblog: add __android_log_close()" am: 812d1c7ea2 am: 6322efe522 am: ed421af68d
...
am: e5bda4d0ec
2016-08-24 16:18:56 +00:00
Mark Salyzyn
309122d798
Merge "logger: validate hdr_size field in logger entry" am: fcf7ab8b1b am: 2d562c9dce am: 098b5887c6
...
am: af3623281f
2016-08-24 16:18:56 +00:00
Mark Salyzyn
e60a17a9db
Merge "libcutils: Add ashmem_valid() function" am: d00c7470ea am: 8b1f7b595c am: da07f7880c
...
am: 8e5cb037c4
2016-08-24 16:18:55 +00:00
Mark Salyzyn
e5bda4d0ec
Merge "liblog: add __android_log_close()" am: 812d1c7ea2 am: 6322efe522
...
am: ed421af68d
2016-08-24 16:10:09 +00:00
Mark Salyzyn
af3623281f
Merge "logger: validate hdr_size field in logger entry" am: fcf7ab8b1b am: 2d562c9dce
...
am: 098b5887c6
2016-08-24 16:10:08 +00:00
Mark Salyzyn
ed421af68d
Merge "liblog: add __android_log_close()" am: 812d1c7ea2
...
am: 6322efe522
2016-08-24 16:07:39 +00:00
Mark Salyzyn
098b5887c6
Merge "logger: validate hdr_size field in logger entry" am: fcf7ab8b1b
...
am: 2d562c9dce
2016-08-24 16:07:38 +00:00
Mark Salyzyn
6322efe522
Merge "liblog: add __android_log_close()"
...
am: 812d1c7ea2
2016-08-24 16:05:05 +00:00
Mark Salyzyn
2d562c9dce
Merge "logger: validate hdr_size field in logger entry"
...
am: fcf7ab8b1b
2016-08-24 16:05:04 +00:00
Treehugger Robot
812d1c7ea2
Merge "liblog: add __android_log_close()"
2016-08-24 15:58:48 +00:00
Treehugger Robot
fcf7ab8b1b
Merge "logger: validate hdr_size field in logger entry"
2016-08-24 15:56:23 +00:00
Mark Salyzyn
8e5cb037c4
Merge "libcutils: Add ashmem_valid() function" am: d00c7470ea am: 8b1f7b595c
...
am: da07f7880c
2016-08-24 15:54:08 +00:00
Mark Salyzyn
da07f7880c
Merge "libcutils: Add ashmem_valid() function" am: d00c7470ea
...
am: 8b1f7b595c
2016-08-24 15:51:08 +00:00
Mark Salyzyn
8b1f7b595c
Merge "libcutils: Add ashmem_valid() function"
...
am: d00c7470ea
2016-08-24 15:48:55 +00:00
Mark Salyzyn
ee431112ff
libcutils: Add ashmem_valid() function
...
Bug: 30310689
Change-Id: I14c52c5d52745a725799652b87c86281ac214899
2016-08-23 15:29:28 -07:00
Mark Salyzyn
df7a4c6bae
liblog: add __android_log_close()
...
Bug: 30963384
Change-Id: I901e6ac2cc3c601bbecc2d64e00a98e2ab448210
2016-08-23 15:25:03 -07:00
Mark Salyzyn
305374cf0f
logger: validate hdr_size field in logger entry
...
- check hdr_size to make sure it is in the expected range
from sizeof entry_v1 to entry (entry_v4).
- alter msg() method to report NULL on invalid hdr_size
- alter all users of msg() method.
Bug: 30947841
Change-Id: I9bc1740d7aa9f37df5be966c18de1fb9de63d5dd
2016-08-23 14:51:50 -07:00
Connor O'Brien
7d7f5399d4
Fix vold vulnerability in FrameworkListener am: 470484d2a2 am: e9e046df6c am: 109024f74a am: b906ad88b9 am: 2fadbb93a4 am: e04054d9bb am: 9745b11db1 am: 2f78b2c3d6 am: 2b5e6d8ffc am: 2427a462c0 am: 6b155c1cc4 am: 2f16eeede6
...
am: 233c9902cf
2016-08-19 22:57:38 +00:00
Connor O'Brien
233c9902cf
Fix vold vulnerability in FrameworkListener am: 470484d2a2 am: e9e046df6c am: 109024f74a am: b906ad88b9 am: 2fadbb93a4 am: e04054d9bb am: 9745b11db1 am: 2f78b2c3d6 am: 2b5e6d8ffc am: 2427a462c0 am: 6b155c1cc4
...
am: 2f16eeede6
2016-08-19 22:53:32 +00:00
Connor O'Brien
af8d67e032
Fix vold vulnerability in FrameworkListener am: 470484d2a2 am: e9e046df6c am: 109024f74a am: b906ad88b9 am: 2fadbb93a4 am: e04054d9bb am: 9745b11db1 am: 2f78b2c3d6 am: 2b5e6d8ffc am: 2427a462c0 am: 6b155c1cc4
...
am: 2f16eeede6
2016-08-19 22:53:32 +00:00
Connor O'Brien
2f16eeede6
Fix vold vulnerability in FrameworkListener am: 470484d2a2 am: e9e046df6c am: 109024f74a am: b906ad88b9 am: 2fadbb93a4 am: e04054d9bb am: 9745b11db1 am: 2f78b2c3d6 am: 2b5e6d8ffc am: 2427a462c0
...
am: 6b155c1cc4
2016-08-19 22:50:00 +00:00
Connor O'Brien
2f78b2c3d6
Fix vold vulnerability in FrameworkListener am: 470484d2a2 am: e9e046df6c am: 109024f74a am: b906ad88b9 am: 2fadbb93a4 am: e04054d9bb
...
am: 9745b11db1
2016-08-19 22:36:29 +00:00
Connor O'Brien
9745b11db1
Fix vold vulnerability in FrameworkListener am: 470484d2a2 am: e9e046df6c am: 109024f74a am: b906ad88b9 am: 2fadbb93a4
...
am: e04054d9bb
2016-08-19 22:34:46 +00:00
Connor O'Brien
2fadbb93a4
Fix vold vulnerability in FrameworkListener am: 470484d2a2 am: e9e046df6c am: 109024f74a
...
am: b906ad88b9
2016-08-19 22:14:57 +00:00
Connor O'Brien
b906ad88b9
Fix vold vulnerability in FrameworkListener am: 470484d2a2 am: e9e046df6c
...
am: 109024f74a
2016-08-19 22:11:27 +00:00
Connor O'Brien
109024f74a
Fix vold vulnerability in FrameworkListener am: 470484d2a2
...
am: e9e046df6c
2016-08-19 22:08:22 +00:00
Connor O'Brien
470484d2a2
Fix vold vulnerability in FrameworkListener
...
Modify FrameworkListener to ignore commands that exceed the maximum
buffer length and send an error message.
Bug: 29831647
Change-Id: I9e57d1648d55af2ca0191bb47868e375ecc26950
Signed-off-by: Connor O'Brien <connoro@google.com>
(cherry picked from commit baa126dc15
2016-08-19 17:05:25 +00:00
Dmitriy Filchenko
6e2743ec04
Merge "Remove process_name.c" am: e5b7ad1c39 am: 97e3cb7074 am: de9e6fb4b0
...
am: ceca7afbc7
2016-08-19 01:39:06 +00:00
Dmitriy Filchenko
ceca7afbc7
Merge "Remove process_name.c" am: e5b7ad1c39 am: 97e3cb7074
...
am: de9e6fb4b0
2016-08-19 01:36:31 +00:00
Dmitriy Filchenko
de9e6fb4b0
Merge "Remove process_name.c" am: e5b7ad1c39
...
am: 97e3cb7074
2016-08-19 01:33:31 +00:00
Dmitriy Filchenko
97e3cb7074
Merge "Remove process_name.c"
...
am: e5b7ad1c39
2016-08-19 01:30:34 +00:00
Dmitriy Filchenko
1bb49f483b
Remove process_name.c
...
BUG: 29824203
Change-Id: I88d67cafb8ec0c4eea3db047bac0671de698ba02
2016-08-18 23:54:46 +00:00
Connor O'Brien
baa126dc15
Fix vold vulnerability in FrameworkListener
...
Modify FrameworkListener to ignore commands that exceed the maximum
buffer length and send an error message.
Bug: 29831647
Change-Id: I9e57d1648d55af2ca0191bb47868e375ecc26950
Signed-off-by: Connor O'Brien <connoro@google.com>
2016-08-18 14:52:39 -07:00
Hans Boehm
23c857ebd6
Make RefBase more robust and debuggable
...
This prevents two different kinds of client errors from causing
undetected memory corruption, and helps with the detection of others:
1. We no longer deallocate objects when the weak count goes to zero
and there have been no strong references. This otherwise causes
us to return a garbage object from a constructor if the constructor
allocates and deallocates a weak pointer to this. And we do know
that clients allocate such weak pointers in constructors and their
lifetime is hard to trace.
2. We abort if a RefBase object is explicitly destroyed while
the weak count is nonzero. Otherwise a subsequent decrement
would cause a write to potentially reallocated memory.
3. We check counter values returned by atomic decrements for
plausibility, and fail immediately if they are not plausible.
We unconditionally log any cases in which 1 changes behavior
from before. We abort in cases in which 2 changes behavior, since
those reflect clear bugs.
In case 1, a log message now indicates a possible leak. We have
not seen such a message in practice.
The third point introduces a small amount of overhead into the
reference count decrement path. But this should be negligible
compared to the actual decrement cost.
Add a test for promote/attemptIncStrong that tries to check for
both (1) above and concurrent operation of attemptIncStrong.
Add some additional warnings and explanations to the RefBase
documentation.
Bug: 30503444
Bug: 30292291
Bug: 30292538
Change-Id: Ida92b9a2e247f543a948a75d221fbc0038dea66c
2016-08-13 11:17:51 -07:00
Hans Boehm
9fb33735be
Merge "Improve RefBase documentation, especially for clients." am: 0f39fe22ae am: df6c464e9a am: f997434b06
...
am: e725c79831
2016-08-10 16:33:00 +00:00
Hans Boehm
e725c79831
Merge "Improve RefBase documentation, especially for clients." am: 0f39fe22ae am: df6c464e9a
...
am: f997434b06
2016-08-10 16:29:59 +00:00
Hans Boehm
f997434b06
Merge "Improve RefBase documentation, especially for clients." am: 0f39fe22ae
...
am: df6c464e9a
2016-08-10 16:26:59 +00:00
Hans Boehm
df6c464e9a
Merge "Improve RefBase documentation, especially for clients."
...
am: 0f39fe22ae
2016-08-10 16:24:01 +00:00
Hans Boehm
0f39fe22ae
Merge "Improve RefBase documentation, especially for clients."
2016-08-10 16:16:22 +00:00
Hans Boehm
9ba7192c1f
Improve RefBase documentation, especially for clients.
...
Add basic interface documentation to RefBase.h.
Much, but not all, of this is cut-and-pasted from an email message
from Mathias Agopian. The rest is reconstructed from the code.
Delete some, now redundant, text from Refbase.cpp, and add a bit
more about the implementation strategy.
Some minor fixes to internal comments.
Bug: 30292291
Change-Id: I56518ae5553bc6de0cc2331778e7fcf2e6c4fd87
2016-08-09 15:12:19 -07:00
Chih-Hung Hsieh
94aa3aaee0
Merge "Fix google-explicit-constructor warnings in utils." am: 5b7e3b9a2a am: 4d031d6358 am: e1fff2572c
...
am: d8ced2029b
2016-08-04 21:55:59 +00:00
Chih-Hung Hsieh
d8ced2029b
Merge "Fix google-explicit-constructor warnings in utils." am: 5b7e3b9a2a am: 4d031d6358
...
am: e1fff2572c
2016-08-04 21:53:19 +00:00
Chih-Hung Hsieh
e1fff2572c
Merge "Fix google-explicit-constructor warnings in utils." am: 5b7e3b9a2a
...
am: 4d031d6358
2016-08-04 21:51:20 +00:00
