No description
Find a file
Akilesh Kailash 4375229588 snapuserd: Address alignment fault on 32-bit systems
When the scratch space is mmap'ed, the metadata buffer
will be un-aligned. This may lead to alignment fault
on 32-bit systems. Address this by temporarily copying
it to buffer.

No perf impact as this code path is not in I/O path
and the copy is a for the size of metadata buffer which
is 8k.

Bug: 206426215
Test: Full and Incremental OTA on pixel
1: Compile snapuserd as 32 bit and reproduced the bug on pixel.
2: With fix - OTA applied successfully.
3: Reboot the device when merge was in-flight as the fix is primarily
in that path.
4: Verify merge completion and data integrity post merge.

Signed-off-by: Akilesh Kailash <akailash@google.com>
Change-Id: Icd4a21d6a61f1ab36e65994c06a4d049a2ee741c
Merged-In: I63c0d862057ebf138c9d1696a942030e30598739
2021-12-01 20:37:56 +00:00
bootstat Use libgtest_prod_headers. 2021-04-20 15:22:02 -07:00
cli-test [LSC] Add LOCAL_LICENSE_KINDS to system/core 2021-02-19 12:59:05 -08:00
code_coverage [LSC] Add LOCAL_LICENSE_KINDS to system/core 2021-02-19 12:59:05 -08:00
debuggerd [MTE] Add a HWASan-style tag dump to tombstones. 2021-06-29 16:17:58 -07:00
diagnose_usb [LSC] Add LOCAL_LICENSE_KINDS to system/core 2021-02-19 12:59:05 -08:00
fastboot fastbootd: Delete all VAB partitions during "flashall". 2021-08-11 00:29:07 +00:00
fs_mgr snapuserd: Address alignment fault on 32-bit systems 2021-12-01 20:37:56 +00:00
gatekeeperd Keystore 2.0: Remove references to Keystore 1.0 2021-03-18 15:32:19 -07:00
healthd [LSC] Add LOCAL_LICENSE_KINDS to system/core 2021-02-19 12:59:05 -08:00
include Remove include/backtrace symlink. 2020-10-20 12:46:14 -07:00
init init: introduce ro.kernel.version property 2021-10-06 16:12:41 +00:00
janitors Add the two best build system janitors. 2019-03-25 10:25:13 -07:00
libappfuse [LSC] Add LOCAL_LICENSE_KINDS to system/core 2021-02-19 12:59:05 -08:00
libasyncio [LSC] Add LOCAL_LICENSE_KINDS to system/core 2021-02-19 12:59:05 -08:00
libbinderwrapper [LSC] Add LOCAL_LICENSE_KINDS to system/core 2021-02-19 12:59:05 -08:00
libcrypto_utils Revert "Completely migrate init first stage to Soong" 2021-07-01 06:50:40 +00:00
libcutils Revert "Add systrace tag for system property" 2021-07-22 04:52:40 +00:00
libdiskconfig [LSC] Add LOCAL_LICENSE_KINDS to system/core 2021-02-19 12:59:05 -08:00
libgrallocusage [LSC] Add LOCAL_LICENSE_KINDS to system/core 2021-02-19 12:59:05 -08:00
libkeyutils Revert "Completely migrate init first stage to Soong" 2021-07-01 06:50:40 +00:00
libmodprobe Revert "Completely migrate init first stage to Soong" 2021-07-01 06:50:40 +00:00
libnetutils [LSC] Add LOCAL_LICENSE_KINDS to system/core 2021-02-19 12:59:05 -08:00
libpackagelistparser [LSC] Add LOCAL_LICENSE_KINDS to system/core 2021-02-19 12:59:05 -08:00
libprocessgroup Merge "init.rc: Create a new group for dex2oat" into sc-v2-dev 2021-10-26 07:09:28 +00:00
libqtaguid [LSC] Add LOCAL_LICENSE_KINDS to system/core 2021-02-19 12:59:05 -08:00
libsparse [LSC] Add LOCAL_LICENSE_KINDS to system/core 2021-02-19 12:59:05 -08:00
libstats Use libgtest_prod_headers. 2021-04-20 15:22:02 -07:00
libsuspend [LSC] Add LOCAL_LICENSE_KINDS to system/core 2021-02-19 12:59:05 -08:00
libsync Replace llndk_library with llndk clause in cc_library 2021-04-21 19:13:41 -07:00
libsystem [LSC] Add LOCAL_LICENSE_KINDS to system/core 2021-02-19 12:59:05 -08:00
libsysutils [LSC] Add LOCAL_LICENSE_KINDS to system/core 2021-02-19 12:59:05 -08:00
libusbhost [LSC] Add LOCAL_LICENSE_KINDS to system/core 2021-02-19 12:59:05 -08:00
libutils libutils: use system_background for low prio tasks in framework 2021-10-07 17:58:44 +00:00
libvndksupport Replace llndk_library with llndk clause in cc_library 2021-04-21 19:13:41 -07:00
llkd llkd: Disable in userdebug builds by default 2021-11-11 01:45:06 +00:00
mini_keyctl Separate out libkeyutils and mini_keyctl. 2021-03-16 17:39:00 -07:00
mkbootfs Rename system/cote/cpio/ -> system/core/mkbootfs/ 2021-05-05 19:03:36 +08:00
property_service [LSC] Add LOCAL_LICENSE_KINDS to system/core 2021-02-19 12:59:05 -08:00
reboot [LSC] Add LOCAL_LICENSE_KINDS to system/core 2021-02-19 12:59:05 -08:00
rootdir Merge "init.rc: Create a new group for dex2oat" into sc-v2-dev 2021-10-26 07:09:28 +00:00
run-as [LSC] Add LOCAL_LICENSE_KINDS to system/core 2021-02-19 12:59:05 -08:00
sdcard [LSC] Add LOCAL_LICENSE_KINDS to system/core 2021-02-19 12:59:05 -08:00
set-verity-state [LSC] Add LOCAL_LICENSE_KINDS to system/core 2021-02-19 12:59:05 -08:00
shell_and_utilities [LSC] Add LOCAL_LICENSE_KINDS to system/core 2021-02-19 12:59:05 -08:00
storaged [LSC] Add LOCAL_LICENSE_KINDS to system/core 2021-02-19 12:59:05 -08:00
toolbox Update owners for modprobe.c 2021-04-01 12:42:21 -07:00
trusty storageproxyd: discard writes when checkpointing, if necessary 2021-10-13 19:35:18 +00:00
usbd [LSC] Add LOCAL_LICENSE_KINDS to system/core 2021-02-19 12:59:05 -08:00
watchdogd [LSC] Add LOCAL_LICENSE_KINDS to system/core 2021-02-19 12:59:05 -08:00
.clang-format Add a 2 width option of clang format. 2017-03-10 13:01:39 -08:00
.clang-format-2 Move clang-formats to build. 2019-01-18 14:26:33 -08:00
.clang-format-4 Move clang-formats to build. 2019-01-18 14:26:33 -08:00
.gitignore Ignore adb/*.pyc files 2015-08-11 12:59:58 -07:00
CleanSpec.mk snapshotctl don't auto-merge. 2020-03-03 13:19:49 -08:00
METADATA Add METADATA to system/core: Apache2+BSD=NOTICE 2020-04-29 13:16:41 -07:00
MODULE_LICENSE_APACHE2
OWNERS Remove baligh@ from owners. CodeShuffle done. 2020-10-17 00:28:10 +00:00
PREUPLOAD.cfg Add AOSP preupload hook. 2020-04-23 11:02:00 -07:00
TEST_MAPPING Clean up cc_test TEST_MAPPING after default update 2021-02-19 20:07:05 +00:00