69d2f98197
This commit fixes two somewhat related issues in shell_service.
- The fd returned by StartSubprocess is owned by a unique_fd
contained in the Subprocess object, but also gets closed by the
caller. Resolve this by duping the returned file descriptor.
- A Subprocess object can be destroyed immediately after its initial
construction in StartSubprocess if we're sufficiently unlucky.
Split up the fork/exec and "start management thread" steps, so that
we can safely do everything we need to do on the Subprocess before
handing it over to the thread that'll eventually destroy it.
Also includes squashed patches from AOSP master that allow for use of
unique_fd inside adb.
Bug: http://b/29254462
Change-Id: Id9cf0b7e7a7293bee7176919edc758597691c636
(cherry picked from commit c0e6e40cc9)
(cherry picked from commit 54c72aaccc)
(cherry picked from commit 2c5d1d7cd9)
(cherry picked from commit 2a7b86337f)
(cherry picked from commit 13ea01db45)
(cherry picked from commit 344778da41)
73 lines
2.2 KiB
C++
73 lines
2.2 KiB
C++
/*
|
|
* Copyright (C) 2015 The Android Open Source Project
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
#ifndef ANDROID_BASE_PARSEINT_H
|
|
#define ANDROID_BASE_PARSEINT_H
|
|
|
|
#include <errno.h>
|
|
#include <stdlib.h>
|
|
|
|
#include <limits>
|
|
|
|
namespace android {
|
|
namespace base {
|
|
|
|
// Parses the unsigned decimal integer in the string 's' and sets 'out' to
|
|
// that value. Optionally allows the caller to define a 'max' beyond which
|
|
// otherwise valid values will be rejected. Returns boolean success.
|
|
template <typename T>
|
|
bool ParseUint(const char* s, T* out,
|
|
T max = std::numeric_limits<T>::max()) {
|
|
int base = (s[0] == '0' && s[1] == 'x') ? 16 : 10;
|
|
errno = 0;
|
|
char* end;
|
|
unsigned long long int result = strtoull(s, &end, base);
|
|
if (errno != 0 || s == end || *end != '\0') {
|
|
return false;
|
|
}
|
|
if (max < result) {
|
|
return false;
|
|
}
|
|
*out = static_cast<T>(result);
|
|
return true;
|
|
}
|
|
|
|
// Parses the signed decimal integer in the string 's' and sets 'out' to
|
|
// that value. Optionally allows the caller to define a 'min' and 'max
|
|
// beyond which otherwise valid values will be rejected. Returns boolean
|
|
// success.
|
|
template <typename T>
|
|
bool ParseInt(const char* s, T* out,
|
|
T min = std::numeric_limits<T>::min(),
|
|
T max = std::numeric_limits<T>::max()) {
|
|
int base = (s[0] == '0' && s[1] == 'x') ? 16 : 10;
|
|
errno = 0;
|
|
char* end;
|
|
long long int result = strtoll(s, &end, base);
|
|
if (errno != 0 || s == end || *end != '\0') {
|
|
return false;
|
|
}
|
|
if (result < min || max < result) {
|
|
return false;
|
|
}
|
|
*out = static_cast<T>(result);
|
|
return true;
|
|
}
|
|
|
|
} // namespace base
|
|
} // namespace android
|
|
|
|
#endif // ANDROID_BASE_PARSEINT_H
|