53089aa25c
The content parameter of write_file() previously took a char* that was then converted to a std::string in WriteStringToFd(). One unfortunate effect of this, is that it is impossible to write data that contains '\0' within it, as the new string will only contain characters up until the '\0'. This changes write_file() to take an std::string, such that std::string::size() is used to determine the length of the string, allowing it to contain null characters. Also change the path parameter of read_file() and write_file() for consistency. Lastly, add a test for handling strings with '\0' in them. Bug: 36726045 Test: Boot bullhead, run unit tests Change-Id: Idad60e4228ee2de741ab3ab6a4917065b5e63cd8
62 lines
1.8 KiB
C++
62 lines
1.8 KiB
C++
/*
|
|
* Copyright (C) 2015 The Android Open Source Project
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
#include "util.h"
|
|
|
|
#include <errno.h>
|
|
|
|
#include <android-base/test_utils.h>
|
|
#include <gtest/gtest.h>
|
|
|
|
TEST(util, read_file_ENOENT) {
|
|
std::string s("hello");
|
|
errno = 0;
|
|
EXPECT_FALSE(read_file("/proc/does-not-exist", &s));
|
|
EXPECT_EQ(ENOENT, errno);
|
|
EXPECT_EQ("", s); // s was cleared.
|
|
}
|
|
|
|
TEST(util, read_file_success) {
|
|
std::string s("hello");
|
|
EXPECT_TRUE(read_file("/proc/version", &s));
|
|
EXPECT_GT(s.length(), 6U);
|
|
EXPECT_EQ('\n', s[s.length() - 1]);
|
|
s[5] = 0;
|
|
EXPECT_STREQ("Linux", s.c_str());
|
|
}
|
|
|
|
TEST(util, write_file_binary) {
|
|
std::string contents("abcd");
|
|
contents.push_back('\0');
|
|
contents.push_back('\0');
|
|
contents.append("dcba");
|
|
ASSERT_EQ(10u, contents.size());
|
|
|
|
TemporaryFile tf;
|
|
ASSERT_TRUE(tf.fd != -1);
|
|
EXPECT_TRUE(write_file(tf.path, contents)) << strerror(errno);
|
|
|
|
std::string read_back_contents;
|
|
EXPECT_TRUE(read_file(tf.path, &read_back_contents)) << strerror(errno);
|
|
EXPECT_EQ(contents, read_back_contents);
|
|
EXPECT_EQ(10u, read_back_contents.size());
|
|
}
|
|
|
|
TEST(util, decode_uid) {
|
|
EXPECT_EQ(0U, decode_uid("root"));
|
|
EXPECT_EQ(UINT_MAX, decode_uid("toot"));
|
|
EXPECT_EQ(123U, decode_uid("123"));
|
|
}
|