This CL moves the network address parsing function from adb to libbase
so that it can be used by fastboot as well as adb.
libbase seemed like the right choice because:
1. It already has some parsing functions (parseint)
2. The net address parsing function uses the libbase string
functions so we have a libbase dependency anyway.
The parsing function has been modified slightly to make the canonical
address optional, and debug logging on success has been removed.
For adb the only functional difference is that parsing a network
address will no longer print the result to the debug log, which seemed
unnecessary.
Bug: http://b/26236380
Change-Id: Ife6df02937225fc66de87884d3572d79c092c522
145 lines
4.4 KiB
C++
145 lines
4.4 KiB
C++
/*
|
|
* Copyright (C) 2015 The Android Open Source Project
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
#include "adb_utils.h"
|
|
|
|
#ifdef _WIN32
|
|
#include <windows.h>
|
|
#include <userenv.h>
|
|
#endif
|
|
|
|
#include <string>
|
|
|
|
#include <gtest/gtest.h>
|
|
|
|
#include <stdlib.h>
|
|
#include <string.h>
|
|
|
|
#include "sysdeps.h"
|
|
|
|
#include <android-base/macros.h>
|
|
#include <android-base/test_utils.h>
|
|
|
|
#ifdef _WIN32
|
|
static std::string subdir(const char* parent, const char* child) {
|
|
std::string str(parent);
|
|
str += OS_PATH_SEPARATOR;
|
|
str += child;
|
|
return str;
|
|
}
|
|
#endif
|
|
|
|
TEST(adb_utils, directory_exists) {
|
|
#ifdef _WIN32
|
|
char profiles_dir[MAX_PATH];
|
|
DWORD cch = arraysize(profiles_dir);
|
|
|
|
// On typical Windows 7, returns C:\Users
|
|
ASSERT_TRUE(GetProfilesDirectoryA(profiles_dir, &cch));
|
|
|
|
ASSERT_TRUE(directory_exists(profiles_dir));
|
|
|
|
// On modern (English?) Windows, this is a directory symbolic link to
|
|
// C:\ProgramData. Symbolic links are rare on Windows and the user requires
|
|
// a special permission (by default granted to Administrative users) to
|
|
// create symbolic links.
|
|
ASSERT_FALSE(directory_exists(subdir(profiles_dir, "All Users")));
|
|
|
|
// On modern (English?) Windows, this is a directory junction to
|
|
// C:\Users\Default. Junctions are used throughout user profile directories
|
|
// for backwards compatibility and they don't require any special permissions
|
|
// to create.
|
|
ASSERT_FALSE(directory_exists(subdir(profiles_dir, "Default User")));
|
|
|
|
ASSERT_FALSE(directory_exists(subdir(profiles_dir, "does-not-exist")));
|
|
#else
|
|
ASSERT_TRUE(directory_exists("/proc"));
|
|
ASSERT_FALSE(directory_exists("/proc/self")); // Symbolic link.
|
|
ASSERT_FALSE(directory_exists("/proc/does-not-exist"));
|
|
#endif
|
|
}
|
|
|
|
TEST(adb_utils, escape_arg) {
|
|
ASSERT_EQ(R"('')", escape_arg(""));
|
|
|
|
ASSERT_EQ(R"('abc')", escape_arg("abc"));
|
|
|
|
ASSERT_EQ(R"(' abc')", escape_arg(" abc"));
|
|
ASSERT_EQ(R"(''\''abc')", escape_arg("'abc"));
|
|
ASSERT_EQ(R"('"abc')", escape_arg("\"abc"));
|
|
ASSERT_EQ(R"('\abc')", escape_arg("\\abc"));
|
|
ASSERT_EQ(R"('(abc')", escape_arg("(abc"));
|
|
ASSERT_EQ(R"(')abc')", escape_arg(")abc"));
|
|
|
|
ASSERT_EQ(R"('abc abc')", escape_arg("abc abc"));
|
|
ASSERT_EQ(R"('abc'\''abc')", escape_arg("abc'abc"));
|
|
ASSERT_EQ(R"('abc"abc')", escape_arg("abc\"abc"));
|
|
ASSERT_EQ(R"('abc\abc')", escape_arg("abc\\abc"));
|
|
ASSERT_EQ(R"('abc(abc')", escape_arg("abc(abc"));
|
|
ASSERT_EQ(R"('abc)abc')", escape_arg("abc)abc"));
|
|
|
|
ASSERT_EQ(R"('abc ')", escape_arg("abc "));
|
|
ASSERT_EQ(R"('abc'\''')", escape_arg("abc'"));
|
|
ASSERT_EQ(R"('abc"')", escape_arg("abc\""));
|
|
ASSERT_EQ(R"('abc\')", escape_arg("abc\\"));
|
|
ASSERT_EQ(R"('abc(')", escape_arg("abc("));
|
|
ASSERT_EQ(R"('abc)')", escape_arg("abc)"));
|
|
}
|
|
|
|
TEST(adb_utils, adb_basename) {
|
|
EXPECT_EQ("sh", adb_basename("/system/bin/sh"));
|
|
EXPECT_EQ("sh", adb_basename("sh"));
|
|
EXPECT_EQ("sh", adb_basename("/system/bin/sh/"));
|
|
}
|
|
|
|
TEST(adb_utils, adb_dirname) {
|
|
EXPECT_EQ("/system/bin", adb_dirname("/system/bin/sh"));
|
|
EXPECT_EQ(".", adb_dirname("sh"));
|
|
EXPECT_EQ("/system/bin", adb_dirname("/system/bin/sh/"));
|
|
}
|
|
|
|
void test_mkdirs(const std::string basepath) {
|
|
EXPECT_TRUE(mkdirs(basepath));
|
|
EXPECT_NE(-1, adb_creat(basepath.c_str(), 0600));
|
|
EXPECT_FALSE(mkdirs(basepath + "/subdir/"));
|
|
}
|
|
|
|
TEST(adb_utils, mkdirs) {
|
|
TemporaryDir td;
|
|
|
|
// Absolute paths.
|
|
test_mkdirs(std::string(td.path) + "/dir/subdir/file");
|
|
|
|
// Relative paths.
|
|
ASSERT_EQ(0, chdir(td.path)) << strerror(errno);
|
|
test_mkdirs(std::string("relative/subrel/file"));
|
|
}
|
|
|
|
#if !defined(_WIN32)
|
|
TEST(adb_utils, set_file_block_mode) {
|
|
int fd = adb_open("/dev/null", O_RDWR | O_APPEND);
|
|
ASSERT_GE(fd, 0);
|
|
int flags = fcntl(fd, F_GETFL, 0);
|
|
ASSERT_EQ(O_RDWR | O_APPEND, (flags & (O_RDWR | O_APPEND)));
|
|
ASSERT_TRUE(set_file_block_mode(fd, false));
|
|
int new_flags = fcntl(fd, F_GETFL, 0);
|
|
ASSERT_EQ(flags | O_NONBLOCK, new_flags);
|
|
ASSERT_TRUE(set_file_block_mode(fd, true));
|
|
new_flags = fcntl(fd, F_GETFL, 0);
|
|
ASSERT_EQ(flags, new_flags);
|
|
ASSERT_EQ(0, adb_close(fd));
|
|
}
|
|
#endif
|