ACPR/android_system_core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
android_system_core/libunwindstack/tests/RegsTest.cpp
Christopher Ferris fd6b7284ee Fix null pointer dereference in RegsArm. 
Fix RegsArm::GetPcAdjustment to check for an invalid elf before trying
to read memory.
Modify the tests for this so it crashes without this change.

Also modify the GetPcAdjustment for all different architectures so
that unless the relative pc is too small, it will return the minimum
amount that should be adjusted. This is to handle cases where we still
want to adjust the pc but it's in an invalid elf. Mostly this is for
handling cases when the pc is in jit gdb debug code so that we use the
right unwind information.

Bug: 77233204

Test: Passes unit tests for libbacktrace/libunwindstack.
Change-Id: Id73609adaf3b80a583584441de228156fec3afa7
(cherry picked from commit 6dbc28ece3)
2018-03-28 20:52:52 -07:00

289 lines
9.2 KiB
C++
Raw Blame History

/*
* Copyright (C) 2017 The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
#include <stdint.h>
#include <gtest/gtest.h>
#include <unwindstack/Elf.h>
#include <unwindstack/ElfInterface.h>
#include <unwindstack/MapInfo.h>
#include <unwindstack/RegsArm.h>
#include <unwindstack/RegsArm64.h>
#include <unwindstack/RegsX86.h>
#include <unwindstack/RegsX86_64.h>
#include <unwindstack/RegsMips.h>
#include <unwindstack/RegsMips64.h>
#include "ElfFake.h"
#include "MemoryFake.h"
#include "RegsFake.h"
namespace unwindstack {
class RegsTest : public ::testing::Test {
protected:
void SetUp() override {
memory_ = new MemoryFake;
elf_.reset(new ElfFake(memory_));
elf_interface_ = new ElfInterfaceFake(elf_->memory());
elf_->FakeSetInterface(elf_interface_);
}
ElfInterfaceFake* elf_interface_;
MemoryFake* memory_;
std::unique_ptr<ElfFake> elf_;
};
TEST_F(RegsTest, regs32) {
RegsImplFake<uint32_t> regs32(50);
ASSERT_EQ(50U, regs32.total_regs());
uint32_t* raw = reinterpret_cast<uint32_t*>(regs32.RawData());
for (size_t i = 0; i < 50; i++) {
raw[i] = 0xf0000000 + i;
}
regs32.set_pc(0xf0120340);
regs32.set_sp(0xa0ab0cd0);
for (size_t i = 0; i < 50; i++) {
ASSERT_EQ(0xf0000000U + i, regs32[i]) << "Failed comparing register " << i;
}
ASSERT_EQ(0xf0120340U, regs32.pc());
ASSERT_EQ(0xa0ab0cd0U, regs32.sp());
regs32[32] = 10;
ASSERT_EQ(10U, regs32[32]);
}
TEST_F(RegsTest, regs64) {
RegsImplFake<uint64_t> regs64(30);
ASSERT_EQ(30U, regs64.total_regs());
uint64_t* raw = reinterpret_cast<uint64_t*>(regs64.RawData());
for (size_t i = 0; i < 30; i++) {
raw[i] = 0xf123456780000000UL + i;
}
regs64.set_pc(0xf123456780102030UL);
regs64.set_sp(0xa123456780a0b0c0UL);
for (size_t i = 0; i < 30; i++) {
ASSERT_EQ(0xf123456780000000U + i, regs64[i]) << "Failed reading register " << i;
}
ASSERT_EQ(0xf123456780102030UL, regs64.pc());
ASSERT_EQ(0xa123456780a0b0c0UL, regs64.sp());
regs64[8] = 10;
ASSERT_EQ(10U, regs64[8]);
}
TEST_F(RegsTest, rel_pc) {
RegsArm64 arm64;
EXPECT_EQ(4U, arm64.GetPcAdjustment(0x10, elf_.get()));
EXPECT_EQ(4U, arm64.GetPcAdjustment(0x4, elf_.get()));
EXPECT_EQ(0U, arm64.GetPcAdjustment(0x3, elf_.get()));
EXPECT_EQ(0U, arm64.GetPcAdjustment(0x2, elf_.get()));
EXPECT_EQ(0U, arm64.GetPcAdjustment(0x1, elf_.get()));
EXPECT_EQ(0U, arm64.GetPcAdjustment(0x0, elf_.get()));
RegsX86 x86;
EXPECT_EQ(1U, x86.GetPcAdjustment(0x100, elf_.get()));
EXPECT_EQ(1U, x86.GetPcAdjustment(0x2, elf_.get()));
EXPECT_EQ(1U, x86.GetPcAdjustment(0x1, elf_.get()));
EXPECT_EQ(0U, x86.GetPcAdjustment(0x0, elf_.get()));
RegsX86_64 x86_64;
EXPECT_EQ(1U, x86_64.GetPcAdjustment(0x100, elf_.get()));
EXPECT_EQ(1U, x86_64.GetPcAdjustment(0x2, elf_.get()));
EXPECT_EQ(1U, x86_64.GetPcAdjustment(0x1, elf_.get()));
EXPECT_EQ(0U, x86_64.GetPcAdjustment(0x0, elf_.get()));
RegsMips mips;
EXPECT_EQ(8U, mips.GetPcAdjustment(0x10, elf_.get()));
EXPECT_EQ(8U, mips.GetPcAdjustment(0x8, elf_.get()));
EXPECT_EQ(0U, mips.GetPcAdjustment(0x7, elf_.get()));
EXPECT_EQ(0U, mips.GetPcAdjustment(0x6, elf_.get()));
EXPECT_EQ(0U, mips.GetPcAdjustment(0x5, elf_.get()));
EXPECT_EQ(0U, mips.GetPcAdjustment(0x4, elf_.get()));
EXPECT_EQ(0U, mips.GetPcAdjustment(0x3, elf_.get()));
EXPECT_EQ(0U, mips.GetPcAdjustment(0x2, elf_.get()));
EXPECT_EQ(0U, mips.GetPcAdjustment(0x1, elf_.get()));
EXPECT_EQ(0U, mips.GetPcAdjustment(0x0, elf_.get()));
RegsMips64 mips64;
EXPECT_EQ(8U, mips64.GetPcAdjustment(0x10, elf_.get()));
EXPECT_EQ(8U, mips64.GetPcAdjustment(0x8, elf_.get()));
EXPECT_EQ(0U, mips64.GetPcAdjustment(0x7, elf_.get()));
EXPECT_EQ(0U, mips64.GetPcAdjustment(0x6, elf_.get()));
EXPECT_EQ(0U, mips64.GetPcAdjustment(0x5, elf_.get()));
EXPECT_EQ(0U, mips64.GetPcAdjustment(0x4, elf_.get()));
EXPECT_EQ(0U, mips64.GetPcAdjustment(0x3, elf_.get()));
EXPECT_EQ(0U, mips64.GetPcAdjustment(0x2, elf_.get()));
EXPECT_EQ(0U, mips64.GetPcAdjustment(0x1, elf_.get()));
EXPECT_EQ(0U, mips64.GetPcAdjustment(0x0, elf_.get()));
}
TEST_F(RegsTest, rel_pc_arm) {
RegsArm arm;
// Check fence posts.
elf_->FakeSetLoadBias(0);
EXPECT_EQ(2U, arm.GetPcAdjustment(0x5, elf_.get()));
EXPECT_EQ(2U, arm.GetPcAdjustment(0x4, elf_.get()));
EXPECT_EQ(2U, arm.GetPcAdjustment(0x3, elf_.get()));
EXPECT_EQ(2U, arm.GetPcAdjustment(0x2, elf_.get()));
EXPECT_EQ(0U, arm.GetPcAdjustment(0x1, elf_.get()));
EXPECT_EQ(0U, arm.GetPcAdjustment(0x0, elf_.get()));
elf_->FakeSetLoadBias(0x100);
EXPECT_EQ(0U, arm.GetPcAdjustment(0x1, elf_.get()));
EXPECT_EQ(2U, arm.GetPcAdjustment(0x2, elf_.get()));
EXPECT_EQ(2U, arm.GetPcAdjustment(0xff, elf_.get()));
EXPECT_EQ(2U, arm.GetPcAdjustment(0x105, elf_.get()));
EXPECT_EQ(2U, arm.GetPcAdjustment(0x104, elf_.get()));
EXPECT_EQ(2U, arm.GetPcAdjustment(0x103, elf_.get()));
EXPECT_EQ(2U, arm.GetPcAdjustment(0x102, elf_.get()));
EXPECT_EQ(0U, arm.GetPcAdjustment(0x101, elf_.get()));
EXPECT_EQ(0U, arm.GetPcAdjustment(0x100, elf_.get()));
// Check thumb instructions handling.
elf_->FakeSetLoadBias(0);
memory_->SetData32(0x2000, 0);
EXPECT_EQ(2U, arm.GetPcAdjustment(0x2005, elf_.get()));
memory_->SetData32(0x2000, 0xe000f000);
EXPECT_EQ(4U, arm.GetPcAdjustment(0x2005, elf_.get()));
elf_->FakeSetLoadBias(0x400);
memory_->SetData32(0x2100, 0);
EXPECT_EQ(2U, arm.GetPcAdjustment(0x2505, elf_.get()));
memory_->SetData32(0x2100, 0xf111f111);
EXPECT_EQ(4U, arm.GetPcAdjustment(0x2505, elf_.get()));
}
TEST_F(RegsTest, elf_invalid) {
RegsArm regs_arm;
RegsArm64 regs_arm64;
RegsX86 regs_x86;
RegsX86_64 regs_x86_64;
RegsMips regs_mips;
RegsMips64 regs_mips64;
MapInfo map_info(0x1000, 0x2000);
Elf* invalid_elf = new Elf(nullptr);
map_info.elf.reset(invalid_elf);
regs_arm.set_pc(0x1500);
EXPECT_EQ(0x500U, invalid_elf->GetRelPc(regs_arm.pc(), &map_info));
EXPECT_EQ(2U, regs_arm.GetPcAdjustment(0x500U, invalid_elf));
EXPECT_EQ(2U, regs_arm.GetPcAdjustment(0x511U, invalid_elf));
regs_arm64.set_pc(0x1600);
EXPECT_EQ(0x600U, invalid_elf->GetRelPc(regs_arm64.pc(), &map_info));
EXPECT_EQ(4U, regs_arm64.GetPcAdjustment(0x600U, invalid_elf));
regs_x86.set_pc(0x1700);
EXPECT_EQ(0x700U, invalid_elf->GetRelPc(regs_x86.pc(), &map_info));
EXPECT_EQ(1U, regs_x86.GetPcAdjustment(0x700U, invalid_elf));
regs_x86_64.set_pc(0x1800);
EXPECT_EQ(0x800U, invalid_elf->GetRelPc(regs_x86_64.pc(), &map_info));
EXPECT_EQ(1U, regs_x86_64.GetPcAdjustment(0x800U, invalid_elf));
regs_mips.set_pc(0x1900);
EXPECT_EQ(0x900U, invalid_elf->GetRelPc(regs_mips.pc(), &map_info));
EXPECT_EQ(8U, regs_mips.GetPcAdjustment(0x900U, invalid_elf));
regs_mips64.set_pc(0x1a00);
EXPECT_EQ(0xa00U, invalid_elf->GetRelPc(regs_mips64.pc(), &map_info));
EXPECT_EQ(8U, regs_mips64.GetPcAdjustment(0xa00U, invalid_elf));
}
TEST_F(RegsTest, arm_verify_sp_pc) {
RegsArm arm;
uint32_t* regs = reinterpret_cast<uint32_t*>(arm.RawData());
regs[13] = 0x100;
regs[15] = 0x200;
EXPECT_EQ(0x100U, arm.sp());
EXPECT_EQ(0x200U, arm.pc());
}
TEST_F(RegsTest, arm64_verify_sp_pc) {
RegsArm64 arm64;
uint64_t* regs = reinterpret_cast<uint64_t*>(arm64.RawData());
regs[31] = 0xb100000000ULL;
regs[32] = 0xc200000000ULL;
EXPECT_EQ(0xb100000000U, arm64.sp());
EXPECT_EQ(0xc200000000U, arm64.pc());
}
TEST_F(RegsTest, x86_verify_sp_pc) {
RegsX86 x86;
uint32_t* regs = reinterpret_cast<uint32_t*>(x86.RawData());
regs[4] = 0x23450000;
regs[8] = 0xabcd0000;
EXPECT_EQ(0x23450000U, x86.sp());
EXPECT_EQ(0xabcd0000U, x86.pc());
}
TEST_F(RegsTest, x86_64_verify_sp_pc) {
RegsX86_64 x86_64;
uint64_t* regs = reinterpret_cast<uint64_t*>(x86_64.RawData());
regs[7] = 0x1200000000ULL;
regs[16] = 0x4900000000ULL;
EXPECT_EQ(0x1200000000U, x86_64.sp());
EXPECT_EQ(0x4900000000U, x86_64.pc());
}
TEST_F(RegsTest, mips_verify_sp_pc) {
RegsMips mips;
uint32_t* regs = reinterpret_cast<uint32_t*>(mips.RawData());
regs[29] = 0x100;
regs[32] = 0x200;
EXPECT_EQ(0x100U, mips.sp());
EXPECT_EQ(0x200U, mips.pc());
}
TEST_F(RegsTest, mips64_verify_sp_pc) {
RegsMips64 mips64;
uint64_t* regs = reinterpret_cast<uint64_t*>(mips64.RawData());
regs[29] = 0xb100000000ULL;
regs[32] = 0xc200000000ULL;
EXPECT_EQ(0xb100000000U, mips64.sp());
EXPECT_EQ(0xc200000000U, mips64.pc());
}
TEST_F(RegsTest, machine_type) {
RegsArm arm_regs;
EXPECT_EQ(ARCH_ARM, arm_regs.Arch());
RegsArm64 arm64_regs;
EXPECT_EQ(ARCH_ARM64, arm64_regs.Arch());
RegsX86 x86_regs;
EXPECT_EQ(ARCH_X86, x86_regs.Arch());
RegsX86_64 x86_64_regs;
EXPECT_EQ(ARCH_X86_64, x86_64_regs.Arch());
RegsMips mips_regs;
EXPECT_EQ(ARCH_MIPS, mips_regs.Arch());
RegsMips64 mips64_regs;
EXPECT_EQ(ARCH_MIPS64, mips64_regs.Arch());
}
} // namespace unwindstack
Reference in a new issue View git blame Copy permalink