f0c82e7bad
The function StepIfSignalHandler assumed that the rel_pc passed to it was actually an elf offset. A new version of clang created a libc.so that has a load bias, so tests unwinding through a signal handler would fail on arm. On other ABIs, there is unwind information that could be used instead, so the unwind still worked. The fix is to subtract the load bias from the rel_pc to get an elf offset to pass to the Register StepIfSignalHandler functions. Change all of the Register funtions to make it clear what the first parameter means. Add a unit test for this new code. Also, add an offline test for this case. Bug: 145683525 Test: Ran unit tests using the new clang and the old clang. Change-Id: I3e249653b79bcad6d3a56411a7911fde4888e9d6
62 lines
1.6 KiB
C++
62 lines
1.6 KiB
C++
/*
|
|
* Copyright (C) 2017 The Android Open Source Project
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
#ifndef _LIBUNWINDSTACK_REGS_MIPS_H
|
|
#define _LIBUNWINDSTACK_REGS_MIPS_H
|
|
|
|
#include <stdint.h>
|
|
|
|
#include <functional>
|
|
|
|
#include <unwindstack/Elf.h>
|
|
#include <unwindstack/Regs.h>
|
|
|
|
namespace unwindstack {
|
|
|
|
// Forward declarations.
|
|
class Memory;
|
|
|
|
class RegsMips : public RegsImpl<uint32_t> {
|
|
public:
|
|
RegsMips();
|
|
virtual ~RegsMips() = default;
|
|
|
|
ArchEnum Arch() override final;
|
|
|
|
uint64_t GetPcAdjustment(uint64_t rel_pc, Elf* elf) override;
|
|
|
|
bool SetPcFromReturnAddress(Memory* process_memory) override;
|
|
|
|
bool StepIfSignalHandler(uint64_t elf_offset, Elf* elf, Memory* process_memory) override;
|
|
|
|
void IterateRegisters(std::function<void(const char*, uint64_t)>) override final;
|
|
|
|
uint64_t pc() override;
|
|
uint64_t sp() override;
|
|
|
|
void set_pc(uint64_t pc) override;
|
|
void set_sp(uint64_t sp) override;
|
|
|
|
Regs* Clone() override final;
|
|
|
|
static Regs* Read(void* data);
|
|
|
|
static Regs* CreateFromUcontext(void* ucontext);
|
|
};
|
|
|
|
} // namespace unwindstack
|
|
|
|
#endif // _LIBUNWINDSTACK_REGS_MIPS_H
|