android_system_core/adb
Mayank Rana f7451e6782 adbd: Fix check against valid payload size
block->payload and its size are not valid when it is used to check
against bytes_left due to std::move() performed on its just prior
to the check. Hence check will always fail to detect the case where
received data is more than expected. To detect this condition and
allow error handling with std::move(), remove extra payload variable
and directly use block->payload.

Bug: http://b/168917244
Change-Id: I992bbba9d9a9861a195834f69d62e69b90658210
(cherry picked from commit 71a33cfa67)
2020-09-18 12:27:14 -07:00
..
apex Add min_sdk_version:R to updatable apexes 2020-04-02 03:02:16 +09:00
client Optimizing install-multi-package to use ABB. 2020-05-19 04:26:42 +00:00
crypto Statically link libadbd into minadbd. 2020-03-31 19:16:08 -07:00
daemon adbd: Fix check against valid payload size 2020-09-18 12:27:14 -07:00
fastdeploy adbd: remove static dependency on libcutils. 2020-02-24 17:58:06 -08:00
fdevent [adb] Optimize fdevent machinery 2020-03-18 23:20:00 -07:00
libs Set apex_available property 2020-04-20 16:07:35 +09:00
pairing_auth Fix pairing aes_128_gcm key initialization. 2020-03-26 02:17:34 +00:00
pairing_connection Statically link libadbd into minadbd. 2020-03-31 19:16:08 -07:00
proto Statically link libadbd into minadbd. 2020-03-31 19:16:08 -07:00
sysdeps Allow the adb server to bind on ::1 2019-11-07 08:32:01 -08:00
tls Statically link libadbd into minadbd. 2020-03-31 19:16:08 -07:00
tools check_ms_os_desc: fix buffer overflow. 2020-06-03 15:32:06 -07:00
.clang-format
adb.bash Adb and fastboot completion supports zsh users. 2018-07-17 14:19:35 +08:00
adb.cpp adb: change mdns tls service names (RFC 6763). 2020-04-20 21:03:15 +00:00
adb.h Move adbd's legacy USB implementation to fastboot. 2020-03-31 16:05:36 -07:00
adb_auth.h [adbwifi] Add A_STLS command. 2020-02-21 21:07:13 +00:00
adb_integration_test_adb.xml Add adb integration test to general-tests 2018-08-08 12:08:50 -07:00
adb_integration_test_device.xml Add adb_integration_test_device to general-tests 2018-10-12 13:48:14 -07:00
adb_io.cpp Revert "Revert "Add a way to turn off unique_fd's operator int."" 2019-05-06 16:18:02 -07:00
adb_io.h Revert "Revert "Add a way to turn off unique_fd's operator int."" 2019-05-06 16:18:02 -07:00
adb_io_test.cpp switch to using android-base/file.h instead of android-base/test_utils.h 2018-11-14 09:35:34 -08:00
adb_listeners.cpp adb: convert more stuff to unique_fd. 2019-01-23 17:11:13 -08:00
adb_listeners.h
adb_listeners_test.cpp adb: move fdevent to its own folder. 2019-07-08 14:37:27 -07:00
adb_mdns.h adb: change mdns tls service names (RFC 6763). 2020-04-20 21:03:15 +00:00
adb_test.xml Add test config for adbd_test and apply MainlineTestModuleController to it 2020-05-08 16:47:07 -07:00
adb_trace.cpp Incremental installations in adb, client/host side. 2020-02-19 08:01:06 -08:00
adb_trace.h adbd: remove static dependency on libcutils. 2020-02-24 17:58:06 -08:00
adb_unique_fd.cpp adb: actually enable fdsan. 2018-08-06 18:50:10 -07:00
adb_unique_fd.h Revert "Revert "Add a way to turn off unique_fd's operator int."" 2019-05-06 16:18:02 -07:00
adb_utils.cpp Allow overriding the log path. 2019-07-30 12:26:31 -07:00
adb_utils.h [adb] Use STL for ParseUInt() implementation 2019-08-02 11:33:41 -07:00
adb_utils_test.cpp Revert "Revert "Add a way to turn off unique_fd's operator int."" 2019-05-06 16:18:02 -07:00
adb_wifi.h [adbwifi] Add adbwifi_libs, TLS connection, and MDNS implementation. 2020-02-21 21:06:40 +00:00
Android.bp Merge "adbd: remove ifdefs guarding root/secure." into rvc-dev 2020-06-09 21:42:05 +00:00
benchmark_device.py adb: add benchmarks for sink/source. 2019-02-28 15:53:48 -08:00
brotli_utils.h adb: implement compression for file sync. 2020-03-26 16:08:41 -07:00
bugreport_test.cpp adb: Avoid extra std::string copies 2019-03-26 12:00:19 -07:00
file_sync_protocol.h adb: implement compression for file sync. 2020-03-26 16:08:41 -07:00
mdns_test.cpp adb: change mdns tls service names (RFC 6763). 2020-04-20 21:03:15 +00:00
MODULE_LICENSE_APACHE2
NOTICE Revert "Revert "Revert "adb: append the libwinpthread COPYING to adb's NOTICE.""" 2018-11-29 23:14:02 +00:00
OVERVIEW.TXT adb: fix obsolete documentation. 2018-06-22 13:12:19 -07:00
OWNERS Add OWNERS. 2017-12-07 13:30:03 -08:00
protocol.txt [adbwifi] Add A_STLS command. 2020-02-21 21:07:13 +00:00
security_log_tags.h
services.cpp [adbwifi] Add adbwifi_libs, TLS connection, and MDNS implementation. 2020-02-21 21:06:40 +00:00
services.h Support adb rescue wipe command 2019-04-29 15:21:50 -07:00
SERVICES.TXT adb: fix obsolete documentation. 2018-06-22 13:12:19 -07:00
shell_protocol.h Revert "Revert "Add a way to turn off unique_fd's operator int."" 2019-05-06 16:18:02 -07:00
shell_service_protocol.cpp Revert "Revert "Add a way to turn off unique_fd's operator int."" 2019-05-06 16:18:02 -07:00
shell_service_protocol_test.cpp adb: split shell_service.h into client/daemon/protocol parts. 2018-07-25 18:08:44 -07:00
SOCKET-ACTIVATION.txt Revert "Revert "Support socket activation of adb server"" 2019-12-11 08:20:20 +00:00
socket.h adb: move fdevent to its own folder. 2019-07-08 14:37:27 -07:00
socket_spec.cpp Merge "Enable "localfilesystem" UNIX domain socket for ADB." 2019-12-18 05:34:30 +00:00
socket_spec.h Enable "localfilesystem" UNIX domain socket for ADB. 2019-12-04 10:05:05 +09:00
socket_spec_test.cpp Enable "localfilesystem" UNIX domain socket for ADB. 2019-12-04 10:05:05 +09:00
socket_test.cpp adb: move fdevent to its own folder. 2019-07-08 14:37:27 -07:00
sockets.cpp Enable "localfilesystem" UNIX domain socket for ADB. 2019-12-04 10:05:05 +09:00
sockets.dia
SYNC.TXT Fix typos in ADB documentation 2017-11-30 10:57:51 -08:00
sysdeps.h Add missing static for macOS inline. 2020-04-13 17:17:31 -07:00
sysdeps_test.cpp adb: win32: silence wine test failure. 2019-07-16 15:22:51 -07:00
sysdeps_unix.cpp Incremental installations in adb, client/host side. 2020-02-19 08:01:06 -08:00
sysdeps_win32.cpp [adbwifi] Add adbwifi_libs, TLS connection, and MDNS implementation. 2020-02-21 21:06:40 +00:00
sysdeps_win32_test.cpp switch to using android-base/file.h instead of android-base/test_utils.h 2018-11-14 09:35:34 -08:00
test_adb.py adb: don't hardcode ports in test_adb. 2020-03-02 12:44:50 -08:00
test_device.py adbd: add a perfunctory abb test. 2020-02-07 15:59:49 -08:00
trace.sh
transport.cpp adb: change mdns tls service names (RFC 6763). 2020-04-20 21:03:15 +00:00
transport.h adbd: check auth id. 2020-06-24 16:25:49 -07:00
transport_benchmark.cpp Revert "adb: make benchmarks build on the host." 2018-11-13 11:28:29 -08:00
transport_fd.cpp [adbwifi] Add A_STLS command. 2020-02-21 21:07:13 +00:00
transport_local.cpp [adbwifi] Add A_STLS command. 2020-02-21 21:07:13 +00:00
transport_test.cpp adb: move fdevent to its own folder. 2019-07-08 14:37:27 -07:00
types.cpp [adb] Optimize adbd's usb reading 2019-11-28 18:24:01 -08:00
types.h adb: implement compression for file sync. 2020-03-26 16:08:41 -07:00
types_test.cpp [adb] Optimize adbd's usb reading 2019-11-28 18:24:01 -08:00