No description
Find a file
Spencer Low c8ad0ca69d adb: really make kill-server wait for server death
It doesn't seem like b3c14ec693 was really
waiting for adb server death because the server would write OKAY to the
socket, causing the client to return from ReadOrderlyShutdown() before
the socket was actually closed.

The fix is to read the OKAY and then call ReadOrderlyShutdown() which
will then wait for the socket to be closed.

Test: Made the server hang in adb_server_cleanup() during kill-server
and kill-server would hang (as desired).
Test: To test resilience, tried preventing the server from sending OKAY and
adb kill-server still worked properly.

Change-Id: I4f0f11b86bbdc983670273ef5d3bb1dff7ab3697
Signed-off-by: Spencer Low <CompareAndSwap@gmail.com>
2018-08-29 15:46:47 -07:00
adb adb: really make kill-server wait for server death 2018-08-29 15:46:47 -07:00
adf Make libadf, libsync_recovery recovery_available. 2018-08-07 10:53:07 -07:00
base base: remove execute bit from utf8.h 2018-08-11 12:28:39 -07:00
bootstat bootstat: duplicate boot reason entries 2018-08-07 09:57:32 -07:00
cpio Possible null pointer miss on realloc 2017-03-23 22:41:14 +01:00
debuggerd debuggerd: delete accidentally merged log spam. 2018-08-21 13:54:31 -07:00
demangle Build adbd for recovery 2018-05-24 14:11:11 +09:00
diagnose_usb Build adbd for recovery 2018-05-24 14:11:11 +09:00
fastboot s/product-services/product_services/g 2018-08-20 17:46:42 +00:00
fs_mgr Merge "fs_mgr: Drop some unneeded dependencies." 2018-08-15 18:14:16 +00:00
gatekeeperd Add OWNERS file to gatekeeperd 2018-07-25 15:02:38 -07:00
healthd charger: screen blank on disconnect and 0% not displayed 2018-08-17 03:58:19 +00:00
include Move android_filesystem_config.h => fs_config.h 2017-08-02 16:31:19 -07:00
init s/product-services/product_services/g 2018-08-20 17:46:42 +00:00
libappfuse Stop using SO_SNDBUFFORCE 2018-03-15 14:22:27 +09:00
libasyncio Build adbd for recovery 2018-05-24 14:11:11 +09:00
libbacktrace Revert^2 "Prepare to fail in RefBase destructor if count is untouched" 2018-08-08 16:30:12 -07:00
libbinderwrapper Make libbinderwrapper available in /vendor partition 2018-04-06 08:41:21 +09:00
libcrypto_utils Build adbd for recovery 2018-05-24 14:11:11 +09:00
libcutils s/product-services/product_services/g 2018-08-20 17:46:42 +00:00
libdiskconfig Rename target.linux[_x86[_64]] to target.linux_glibc[_x86[_64]] 2017-10-02 10:44:29 -07:00
libgrallocusage Use -Werror in system/core 2017-11-01 11:32:55 -07:00
libion libion: cleanup logging 2018-03-07 10:56:06 -08:00
libkeyutils Build adbd for recovery 2018-05-24 14:11:11 +09:00
liblog liblog: Add functions to reset log context 2018-08-02 00:55:01 +00:00
libmemtrack Add OWNERS. 2017-12-07 13:30:03 -08:00
libmemunreachable Move libbacktrace off cutils. 2018-07-11 13:55:07 -07:00
libmetricslogger Merge "Add cwren to libmetricslogger OWNERS" into pi-dev 2018-05-24 01:30:58 +00:00
libnativebridge bpfmt. 2018-02-16 17:58:14 -08:00
libnativeloader Separate namespace acquisition from library loading 2018-07-12 15:44:35 +02:00
libnetutils Merge "Add OWNERS." am: 3289b9c928 2017-12-07 23:51:13 +00:00
libpackagelistparser Mark as recovery_available: true 2018-05-15 09:47:04 +09:00
libpixelflinger Remove dead gglFastDivx. 2018-08-02 16:18:24 -07:00
libprocessgroup Add recovery_available: true to init dependencies 2018-07-24 13:45:50 -07:00
libprocinfo libprocinfo: return error msg instead of printing it. 2018-07-24 14:34:06 -07:00
libqtaguid Redirect qtaguid native call to netd fwmark client 2017-11-09 18:02:22 -08:00
libsparse Revert "libsparse: Add sparse typed callback" 2018-07-26 05:23:45 +00:00
libstats Remove a redundant check in statsd socket code. 2018-05-22 16:06:21 -07:00
libsuspend Remove libsuspend from VNDK. 2018-08-14 13:39:55 -07:00
libsync Merge libsync_recovery rules into libsync. 2018-08-07 11:00:50 -07:00
libsystem Camera: add DISABLE error code 2018-05-31 15:12:19 -07:00
libsysutils [libsysutils] Modernize codebase by replacing NULL with nullptr 2018-07-24 16:34:27 -07:00
libunwindstack Merge "Allow to get raw register data on all platforms." 2018-08-08 21:37:46 +00:00
libusbhost Merge "Remove urb request size maximum." am: 1cb765c867 am: 1ab6e9d018 2018-02-13 09:02:38 +00:00
libutils Merge "Check sp<>::clear() for data races" 2018-08-17 22:20:39 +00:00
libvndksupport bpfmt. 2018-02-16 17:58:14 -08:00
libziparchive Merge changes from topic "looper_unique_fd" 2018-07-23 14:36:43 -07:00
llkd llkd: llkSplit should prevent empty entries 2018-08-13 14:43:30 +00:00
lmkd Merge "lmkd: Do not downgrade/ignore events when swap is full" 2018-08-14 21:31:56 +00:00
logcat add event log range for audioserver 2018-07-10 14:21:38 -07:00
logd Replace (unsigned) short with (u)int16_t. 2018-08-13 14:24:33 -07:00
logwrapper Build adbd for recovery 2018-05-24 14:11:11 +09:00
mkbootimg Add recovery_available: true to init dependencies 2018-07-24 13:45:50 -07:00
property_service Add recovery_available: true to init dependencies 2018-07-24 13:45:50 -07:00
qemu_pipe Build adbd for recovery 2018-05-24 14:11:11 +09:00
reboot reboot: only pause indefinitely for non-shutdown operations 2017-09-29 16:29:52 +00:00
rootdir Merge "Install ld.config.recovery.txt to $(TARGET_RECOVERY_ROOT_OUT)/system/etc." 2018-08-21 22:35:49 +00:00
run-as run-as: Migrate to blueprint 2018-06-27 11:15:23 -07:00
sdcard Add support for esdfs mounting 2018-01-19 12:58:42 -08:00
shell_and_utilities Move back to BSD grep, and make it available for recovery too. 2018-08-01 10:35:46 -07:00
storaged storaged: Cap io_history when loading stats from disk. 2018-08-21 09:20:40 -07:00
toolbox Move back to BSD grep, and make it available for recovery too. 2018-08-01 10:35:46 -07:00
trusty Switch from old style KM2 HAL to new KM3 HAL 2018-08-14 10:49:38 -07:00
usbd bpfmt. 2018-02-16 17:58:14 -08:00
watchdogd Move watchdogd out of init 2018-08-02 12:25:58 -07:00
.clang-format Add a 2 width option of clang format. 2017-03-10 13:01:39 -08:00
.clang-format-2 Remove PenaltyExcessCharacter from clang-formats. 2018-07-19 13:50:41 -07:00
.clang-format-4 Remove PenaltyExcessCharacter from clang-formats. 2018-07-19 13:50:41 -07:00
.gitignore Ignore adb/*.pyc files 2015-08-11 12:59:58 -07:00
Android.bp Export android_filesystem_config.h as a filegroup 2017-01-17 18:20:28 -08:00
Android.mk Remove the simulator target from all makefiles. 2011-07-11 22:12:32 -07:00
CleanSpec.mk Shared libs are supported in recovery mode 2018-06-10 08:32:24 +09:00
MODULE_LICENSE_APACHE2 auto import from //depot/cupcake/@135843 2013-07-30 13:56:49 -07:00
NOTICE Fix omission in NOTICE file. 2013-07-30 13:56:55 -07:00
OWNERS Move per-file OWNERS directives to their directories. 2018-06-06 11:49:40 +09:00
platform_tools_tool_version.mk Fix warning on the build servers 2017-05-25 12:35:40 -07:00
PREUPLOAD.cfg Add a PREUPLOAD.cfg file to run git-clang-format on every commit 2017-03-08 16:51:26 +08:00