In the publish function, the variable mAccumulate_pub is used to log disk performance. However, the variable mAccumulate is used to log disk stats. The variable mAccumulate is only populated during a stall event. The publish function is used to log disk stats on a periodic timer, therefore, it should not rely on stall events to log stats. Instead, it should rely on the appropriately named mAccumulate_pub variable. Test: storaged unit tests Change-Id: I30e00f2c69618705d3f308630b7e023bfc5e384e Signed-off-by: David Munoz Constantine <dmunozc@squareup.com> |
||
|---|---|---|
| .. | ||
| binder/android/os | ||
| include | ||
| tests | ||
| tools | ||
| Android.bp | ||
| EventLogTags.logtags | ||
| main.cpp | ||
| OWNERS | ||
| README.properties | ||
| storaged.cpp | ||
| storaged.proto | ||
| storaged.rc | ||
| storaged_diskstats.cpp | ||
| storaged_info.cpp | ||
| storaged_service.cpp | ||
| storaged_uid_monitor.cpp | ||
| storaged_utils.cpp | ||
| uid_info.cpp | ||
ro.storaged.event.interval # interval storaged scans for IO stats, in seconds ro.storaged.event.perf_check # check for time spent in event loop, in microseconds ro.storaged.disk_stats_pub # interval storaged publish disk stats, in seconds ro.storaged.uid_io.interval # interval storaged checks Per UID IO usage, in seconds ro.storaged.uid_io.threshold # Per UID IO usage limit, in bytes