android_system_core/adb
Spencer Low 8d8126a705 adb: logging: newlines, thread ids, error code overwriting
Add missing \n to uses of legacy D() macro. This should make the legacy
logging easier to read (and harder to miss important stuff).

On POSIX, use gettid() from libcutils instead of pthread_self() so that
the output shows a more reasonable number instead of a pointer value.
This should be ok since libbase's logging already uses gettid().

Win32:

Don't let the Win32 last error get overwritten by API calls after the
original error'ing API. When encountering an unknown error, log the
specific error code.

Change-Id: Ib8f72754efa7ba895d2f1cd914251fec2a1d894c
Signed-off-by: Spencer Low <CompareAndSwap@gmail.com>
2015-07-21 02:06:26 -07:00
..
client adb: win32: fix logging to adb.log 2015-06-02 21:04:56 +00:00
daemon Ignore ro.adb.secure in user builds. 2015-06-18 10:19:30 -07:00
tests Fix test_adb.py against production builds. 2015-06-05 13:11:43 -07:00
.clang-format Fix clang-format file for correct indent settings. 2015-03-19 13:27:20 -07:00
adb.cpp adb: logging: newlines, thread ids, error code overwriting 2015-07-21 02:06:26 -07:00
adb.h Remove subproc events when ADB_HOST. 2015-07-17 16:00:29 -04:00
adb_auth.cpp Ignore ro.adb.secure in user builds. 2015-06-18 10:19:30 -07:00
adb_auth.h Ignore ro.adb.secure in user builds. 2015-06-18 10:19:30 -07:00
adb_auth_client.cpp adb: logging: newlines, thread ids, error code overwriting 2015-07-21 02:06:26 -07:00
adb_auth_host.cpp adb: logging: newlines, thread ids, error code overwriting 2015-07-21 02:06:26 -07:00
adb_client.cpp adb: logging: newlines, thread ids, error code overwriting 2015-07-21 02:06:26 -07:00
adb_client.h Fix error handling/reporting for "adb forward" and "adb reverse". 2015-05-29 18:03:57 -07:00
adb_io.cpp Add WriteFdFmt and clean up more code. 2015-05-01 17:36:46 -07:00
adb_io.h Revert "Turn on -Wformat-nonliteral." 2015-07-09 20:35:09 +00:00
adb_io_test.cpp Add WriteFdFmt and clean up more code. 2015-05-01 17:36:46 -07:00
adb_listeners.cpp Replace HAVE_WIN32_IPC with _WIN32. 2015-07-09 10:03:18 -07:00
adb_listeners.h Fix error handling/reporting for "adb forward" and "adb reverse". 2015-05-29 18:03:57 -07:00
adb_trace.h Improve logging. 2015-05-21 16:25:57 -07:00
adb_utils.cpp Move mkdirs to adb_utils. 2015-07-15 19:37:18 +00:00
adb_utils.h Move mkdirs to adb_utils. 2015-07-15 19:37:18 +00:00
adb_utils_test.cpp Fix ' escaping in adb. 2015-05-15 12:06:00 -07:00
Android.mk Revert "Turn on -Wformat-nonliteral." 2015-07-09 20:35:09 +00:00
commandline.cpp Move mkdirs to adb_utils. 2015-07-15 19:37:18 +00:00
console.cpp adb: win32: fix adb emu command 2015-05-06 18:54:08 -07:00
CPPLINT.cfg Ignore whitespace/indent issues from cpplint. 2015-05-18 16:49:07 -07:00
fdevent.cpp adb: logging: newlines, thread ids, error code overwriting 2015-07-21 02:06:26 -07:00
fdevent.h Remove extern "C" barriers to using C++. 2015-04-17 09:47:42 -07:00
file_sync_client.cpp Move mkdirs to adb_utils. 2015-07-15 19:37:18 +00:00
file_sync_service.cpp File header cleanup. 2015-03-19 15:32:33 -07:00
file_sync_service.h Fix "adb sync" for devices without vendor and oem. 2015-04-21 10:17:07 -07:00
framebuffer_service.cpp Move adb to C++. 2015-03-09 14:06:11 -07:00
get_my_path_darwin.cpp Move get_my_path_darwin to C++. 2015-04-16 13:24:58 -07:00
get_my_path_linux.cpp Move adb to C++. 2015-03-09 14:06:11 -07:00
get_my_path_windows.cpp Move adb to C++. 2015-03-09 14:06:11 -07:00
jdwp_service.cpp adb: logging: newlines, thread ids, error code overwriting 2015-07-21 02:06:26 -07:00
MODULE_LICENSE_APACHE2 eclair snapshot 2009-11-12 18:46:23 -08:00
mutex_list.h adb: Cleanup dead code 2013-04-24 21:31:45 -07:00
NOTICE eclair snapshot 2009-11-12 18:46:23 -08:00
OVERVIEW.TXT Fixing spelling errors in adb docs 2010-04-28 11:38:39 -04:00
protocol.txt Fixed a documentation error in protocol.txt 2015-07-06 10:19:28 -07:00
qemu_tracing.cpp Move adb to C++. 2015-03-09 14:06:11 -07:00
qemu_tracing.h Revert "Turn on -Wformat-nonliteral." 2015-07-09 20:35:09 +00:00
remount_service.cpp Fix "adb remount" for when the root directory is in system.img 2015-07-08 19:36:19 +00:00
remount_service.h Failure to find an oem partition should not be a remount failure. 2015-05-11 13:28:22 -07:00
services.cpp adb: logging: newlines, thread ids, error code overwriting 2015-07-21 02:06:26 -07:00
SERVICES.TXT adb: implement "adb reverse <local> <remote>" 2014-05-27 16:42:13 +02:00
set_verity_enable_state_service.cpp Failure to find an oem partition should not be a remount failure. 2015-05-11 13:28:22 -07:00
sockets.cpp Make connection states a proper type. 2015-05-18 17:10:33 -07:00
sockets.dia auto import from //depot/cupcake/@135843 2009-03-03 19:32:55 -08:00
SYNC.TXT Adding documentation on the sync part of the adb protocol previously missing. 2014-03-20 20:36:46 +01:00
sysdeps.h adb: logging: newlines, thread ids, error code overwriting 2015-07-21 02:06:26 -07:00
sysdeps_win32.cpp adb: logging: newlines, thread ids, error code overwriting 2015-07-21 02:06:26 -07:00
test_track_devices.cpp Make test_track_devices.cpp output easier to read. 2015-05-04 15:51:50 -07:00
transport.cpp adb: logging: newlines, thread ids, error code overwriting 2015-07-21 02:06:26 -07:00
transport.h Make connection states a proper type. 2015-05-18 17:10:33 -07:00
transport_local.cpp adb server: don't close stale fd when TCP transport is closed 2015-06-09 12:32:17 -07:00
transport_test.cpp Make atransport be a real class. 2015-05-21 15:49:05 -07:00
transport_usb.cpp Make connection states a proper type. 2015-05-18 17:10:33 -07:00
usb_linux.cpp adb: fix adb_close() vs. unix_close() usage 2015-05-22 20:20:49 -07:00
usb_linux_client.cpp adb: logging: newlines, thread ids, error code overwriting 2015-07-21 02:06:26 -07:00
usb_osx.cpp Revert "Revert "Split adb_main.cpp into client and daemon."" 2015-05-08 17:33:21 -07:00
usb_windows.cpp Revert "Revert "Split adb_main.cpp into client and daemon."" 2015-05-08 17:33:21 -07:00