DigiGoon/android_kernel_xiaomi_sm8350
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

net: ieee802154: do not leave a dangling sk pointer in ieee802154_create()

Browse source 
[ Upstream commit b4fcd63f6ef79c73cafae8cf4a114def5fc3d80d ]

sock_init_data() attaches the allocated sk object to the provided sock
object. If ieee802154_create() fails later, the allocated sk object is
freed, but the dangling pointer remains in the provided sock object, which
may allow use-after-free.

Clear the sk pointer in the sock object on error.

Signed-off-by: Ignat Korchagin <ignat@cloudflare.com>
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Reviewed-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Link: https://patch.msgid.link/20241014153808.51894-6-ignat@cloudflare.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Ignat Korchagin 2024-10-14 16:38:04 +01:00 • committed by Greg Kroah-Hartman
parent 884ae8bcee
commit 1d5fe782c0
1 changed files with 7 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
net/ieee802154/socket.c
View file

@ -1055,19 +1055,21 @@ static int ieee802154_create(struct net *net, struct socket *sock,
if (sk->sk_prot->hash) { if (sk->sk_prot->hash) {
rc = sk->sk_prot->hash(sk); rc = sk->sk_prot->hash(sk);
if (rc) { if (rc)
sk_common_release(sk); goto out_sk_release;
goto out;
}
} }
if (sk->sk_prot->init) { if (sk->sk_prot->init) {
rc = sk->sk_prot->init(sk); rc = sk->sk_prot->init(sk);
if (rc) if (rc)
sk_common_release(sk); goto out_sk_release;
} }
out: out:
return rc; return rc;
out_sk_release:
sk_common_release(sk);
sock->sk = NULL;
goto out;
} }
static const struct net_proto_family ieee802154_family_ops = { static const struct net_proto_family ieee802154_family_ops = {