From 4e24aaf5856863d681cd66c8eead4b41960e5f2d Mon Sep 17 00:00:00 2001 From: Kishore Sri venkata Ganesh Bolisetty Date: Tue, 25 Jan 2022 17:56:19 -0800 Subject: [PATCH] msm_perf: fix warnings to enable msm_perf Handle error checks in reading attributes. Change-Id: I12b693e469b8a8de21a2bef36c92a012e5a2c034 Signed-off-by: Kishore Sri venkata Ganesh Bolisetty [dereference23: Backport to msm-5.4] Signed-off-by: Alexander Winkowski --- drivers/soc/qcom/msm_performance.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/soc/qcom/msm_performance.c b/drivers/soc/qcom/msm_performance.c index 544c87c70c0e..d5e9c75290ee 100644 --- a/drivers/soc/qcom/msm_performance.c +++ b/drivers/soc/qcom/msm_performance.c @@ -913,9 +913,14 @@ void msm_perf_events_update(enum evt_update_t update_typ, static int set_game_start_pid(const char *buf, const struct kernel_param *kp) { long usr_val = 0; - int ret = strlen(buf); + int ret; - kstrtol(buf, 0, &usr_val); + ret = kstrtol(buf, 0, &usr_val); + if (ret) { + pr_err("msm_perf: kstrtol failed, ret=%d\n", ret); + return ret; + } + ret = strlen(buf); atomic_set(&game_status_pid, usr_val); return ret; }