diff --git a/fs_mgr/libsnapshot/Android.bp b/fs_mgr/libsnapshot/Android.bp index acfaa84af..1c44e5344 100644 --- a/fs_mgr/libsnapshot/Android.bp +++ b/fs_mgr/libsnapshot/Android.bp @@ -182,38 +182,6 @@ cc_library_static { vendor_ramdisk_available: true, } -cc_defaults { - name: "libsnapshot_snapuserd_defaults", - defaults: [ - "fs_mgr_defaults", - ], - cflags: [ - "-D_FILE_OFFSET_BITS=64", - "-Wall", - "-Werror", - ], - export_include_dirs: ["include"], - srcs: [ - "snapuserd_client.cpp", - ], -} - -cc_library_static { - name: "libsnapshot_snapuserd", - defaults: [ - "libsnapshot_snapuserd_defaults", - ], - recovery_available: true, - static_libs: [ - "libcutils_sockets", - ], - shared_libs: [ - "libbase", - "liblog", - ], - ramdisk_available: true, -} - cc_library_static { name: "libsnapshot_test_helpers", defaults: ["libsnapshot_defaults"], @@ -412,49 +380,6 @@ cc_test { require_root: true, } -cc_defaults { - name: "snapuserd_defaults", - defaults: [ - "fs_mgr_defaults", - ], - srcs: [ - "snapuserd_server.cpp", - "snapuserd.cpp", - "snapuserd_daemon.cpp", - "snapuserd_worker.cpp", - "snapuserd_readahead.cpp", - ], - - cflags: [ - "-Wall", - "-Werror" - ], - - static_libs: [ - "libbase", - "libbrotli", - "libcutils_sockets", - "libdm", - "libgflags", - "liblog", - "libsnapshot_cow", - "libz", - ], -} - -cc_binary { - name: "snapuserd", - defaults: ["snapuserd_defaults"], - init_rc: [ - "snapuserd.rc", - ], - static_executable: true, - system_shared_libs: [], - ramdisk_available: true, - vendor_ramdisk_available: true, - recovery_available: true, -} - cc_test { name: "cow_api_test", defaults: [ @@ -556,43 +481,6 @@ cc_binary { }, } -cc_test { - name: "cow_snapuserd_test", - defaults: [ - "fs_mgr_defaults", - ], - srcs: [ - "cow_snapuserd_test.cpp", - "snapuserd.cpp", - "snapuserd_worker.cpp", - ], - cflags: [ - "-Wall", - "-Werror", - ], - shared_libs: [ - "libbase", - "liblog", - ], - static_libs: [ - "libbrotli", - "libgtest", - "libsnapshot_cow", - "libsnapshot_snapuserd", - "libcutils_sockets", - "libz", - "libfs_mgr", - "libdm", - ], - header_libs: [ - "libstorage_literals_headers", - "libfiemap_headers", - ], - test_min_api_level: 30, - auto_gen_config: true, - require_root: false, -} - cc_binary { name: "inspect_cow", host_supported: true, diff --git a/fs_mgr/libsnapshot/include/libsnapshot/snapshot.h b/fs_mgr/libsnapshot/include/libsnapshot/snapshot.h index 15882b382..e60da3121 100644 --- a/fs_mgr/libsnapshot/include/libsnapshot/snapshot.h +++ b/fs_mgr/libsnapshot/include/libsnapshot/snapshot.h @@ -38,7 +38,7 @@ #include #include #include -#include +#include #ifndef FRIEND_TEST #define FRIEND_TEST(test_set_name, individual_test) \ diff --git a/fs_mgr/libsnapshot/snapuserd/Android.bp b/fs_mgr/libsnapshot/snapuserd/Android.bp new file mode 100644 index 000000000..173994927 --- /dev/null +++ b/fs_mgr/libsnapshot/snapuserd/Android.bp @@ -0,0 +1,131 @@ +// +// Copyright (C) 2018 The Android Open Source Project +// +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. +// + +package { + default_applicable_licenses: ["Android-Apache-2.0"], +} + +cc_defaults { + name: "libsnapshot_snapuserd_defaults", + defaults: [ + "fs_mgr_defaults", + ], + cflags: [ + "-D_FILE_OFFSET_BITS=64", + "-Wall", + "-Werror", + ], + export_include_dirs: ["include"], + srcs: [ + "snapuserd_client.cpp", + ], +} + +cc_library_static { + name: "libsnapshot_snapuserd", + defaults: [ + "libsnapshot_snapuserd_defaults", + ], + recovery_available: true, + static_libs: [ + "libcutils_sockets", + ], + shared_libs: [ + "libbase", + "liblog", + ], + ramdisk_available: true, +} + +cc_defaults { + name: "snapuserd_defaults", + defaults: [ + "fs_mgr_defaults", + ], + srcs: [ + "snapuserd_server.cpp", + "snapuserd.cpp", + "snapuserd_daemon.cpp", + "snapuserd_worker.cpp", + "snapuserd_readahead.cpp", + ], + + cflags: [ + "-Wall", + "-Werror" + ], + + static_libs: [ + "libbase", + "libbrotli", + "libcutils_sockets", + "libdm", + "libgflags", + "liblog", + "libsnapshot_cow", + "libz", + ], +} + +cc_binary { + name: "snapuserd", + defaults: ["snapuserd_defaults"], + init_rc: [ + "snapuserd.rc", + ], + static_executable: true, + system_shared_libs: [], + ramdisk_available: true, + vendor_ramdisk_available: true, + recovery_available: true, +} + +cc_test { + name: "cow_snapuserd_test", + defaults: [ + "fs_mgr_defaults", + ], + srcs: [ + "cow_snapuserd_test.cpp", + "snapuserd.cpp", + "snapuserd_worker.cpp", + ], + cflags: [ + "-Wall", + "-Werror", + ], + shared_libs: [ + "libbase", + "liblog", + ], + static_libs: [ + "libbrotli", + "libgtest", + "libsnapshot_cow", + "libsnapshot_snapuserd", + "libcutils_sockets", + "libz", + "libfs_mgr", + "libdm", + ], + header_libs: [ + "libstorage_literals_headers", + "libfiemap_headers", + ], + test_min_api_level: 30, + auto_gen_config: true, + require_root: false, +} diff --git a/fs_mgr/libsnapshot/snapuserd/OWNERS b/fs_mgr/libsnapshot/snapuserd/OWNERS new file mode 100644 index 000000000..2df0a2d84 --- /dev/null +++ b/fs_mgr/libsnapshot/snapuserd/OWNERS @@ -0,0 +1,3 @@ +akailash@google.com +dvander@google.com +drosen@google.com diff --git a/fs_mgr/libsnapshot/cow_snapuserd_test.cpp b/fs_mgr/libsnapshot/snapuserd/cow_snapuserd_test.cpp similarity index 99% rename from fs_mgr/libsnapshot/cow_snapuserd_test.cpp rename to fs_mgr/libsnapshot/snapuserd/cow_snapuserd_test.cpp index 767cd049e..fc7153a7c 100644 --- a/fs_mgr/libsnapshot/cow_snapuserd_test.cpp +++ b/fs_mgr/libsnapshot/snapuserd/cow_snapuserd_test.cpp @@ -33,7 +33,7 @@ #include #include #include -#include +#include #include #include "snapuserd.h" diff --git a/fs_mgr/libsnapshot/include/libsnapshot/snapuserd_client.h b/fs_mgr/libsnapshot/snapuserd/include/snapuserd/snapuserd_client.h similarity index 100% rename from fs_mgr/libsnapshot/include/libsnapshot/snapuserd_client.h rename to fs_mgr/libsnapshot/snapuserd/include/snapuserd/snapuserd_client.h diff --git a/fs_mgr/libsnapshot/include/libsnapshot/snapuserd_kernel.h b/fs_mgr/libsnapshot/snapuserd/include/snapuserd/snapuserd_kernel.h similarity index 100% rename from fs_mgr/libsnapshot/include/libsnapshot/snapuserd_kernel.h rename to fs_mgr/libsnapshot/snapuserd/include/snapuserd/snapuserd_kernel.h diff --git a/fs_mgr/libsnapshot/snapuserd.cpp b/fs_mgr/libsnapshot/snapuserd/snapuserd.cpp similarity index 99% rename from fs_mgr/libsnapshot/snapuserd.cpp rename to fs_mgr/libsnapshot/snapuserd/snapuserd.cpp index a09b1111c..ad89b2442 100644 --- a/fs_mgr/libsnapshot/snapuserd.cpp +++ b/fs_mgr/libsnapshot/snapuserd/snapuserd.cpp @@ -20,7 +20,7 @@ #include #include -#include +#include namespace android { namespace snapshot { @@ -405,7 +405,6 @@ bool Snapuserd::ReadMetadata() { de->old_chunk = cow_op->new_block; de->new_chunk = data_chunk_id; - // Store operation pointer. chunk_vec_.push_back(std::make_pair(ChunkToSector(data_chunk_id), cow_op)); num_ops += 1; diff --git a/fs_mgr/libsnapshot/snapuserd.h b/fs_mgr/libsnapshot/snapuserd/snapuserd.h similarity index 99% rename from fs_mgr/libsnapshot/snapuserd.h rename to fs_mgr/libsnapshot/snapuserd/snapuserd.h index 5d86e4f00..95d2f7726 100644 --- a/fs_mgr/libsnapshot/snapuserd.h +++ b/fs_mgr/libsnapshot/snapuserd/snapuserd.h @@ -41,7 +41,7 @@ #include #include #include -#include +#include namespace android { namespace snapshot { diff --git a/fs_mgr/libsnapshot/snapuserd.rc b/fs_mgr/libsnapshot/snapuserd/snapuserd.rc similarity index 100% rename from fs_mgr/libsnapshot/snapuserd.rc rename to fs_mgr/libsnapshot/snapuserd/snapuserd.rc diff --git a/fs_mgr/libsnapshot/snapuserd_client.cpp b/fs_mgr/libsnapshot/snapuserd/snapuserd_client.cpp similarity index 99% rename from fs_mgr/libsnapshot/snapuserd_client.cpp rename to fs_mgr/libsnapshot/snapuserd/snapuserd_client.cpp index 41ab34409..a72cdc9aa 100644 --- a/fs_mgr/libsnapshot/snapuserd_client.cpp +++ b/fs_mgr/libsnapshot/snapuserd/snapuserd_client.cpp @@ -33,7 +33,7 @@ #include #include #include -#include +#include namespace android { namespace snapshot { diff --git a/fs_mgr/libsnapshot/snapuserd_daemon.cpp b/fs_mgr/libsnapshot/snapuserd/snapuserd_daemon.cpp similarity index 98% rename from fs_mgr/libsnapshot/snapuserd_daemon.cpp rename to fs_mgr/libsnapshot/snapuserd/snapuserd_daemon.cpp index 7fa01b78f..4152a642d 100644 --- a/fs_mgr/libsnapshot/snapuserd_daemon.cpp +++ b/fs_mgr/libsnapshot/snapuserd/snapuserd_daemon.cpp @@ -19,7 +19,7 @@ #include #include #include -#include +#include #include "snapuserd_server.h" diff --git a/fs_mgr/libsnapshot/snapuserd_daemon.h b/fs_mgr/libsnapshot/snapuserd/snapuserd_daemon.h similarity index 100% rename from fs_mgr/libsnapshot/snapuserd_daemon.h rename to fs_mgr/libsnapshot/snapuserd/snapuserd_daemon.h diff --git a/fs_mgr/libsnapshot/snapuserd_readahead.cpp b/fs_mgr/libsnapshot/snapuserd/snapuserd_readahead.cpp similarity index 99% rename from fs_mgr/libsnapshot/snapuserd_readahead.cpp rename to fs_mgr/libsnapshot/snapuserd/snapuserd_readahead.cpp index 16d5919a5..6fc26a69c 100644 --- a/fs_mgr/libsnapshot/snapuserd_readahead.cpp +++ b/fs_mgr/libsnapshot/snapuserd/snapuserd_readahead.cpp @@ -20,7 +20,7 @@ #include #include -#include +#include namespace android { namespace snapshot { diff --git a/fs_mgr/libsnapshot/snapuserd_server.cpp b/fs_mgr/libsnapshot/snapuserd/snapuserd_server.cpp similarity index 100% rename from fs_mgr/libsnapshot/snapuserd_server.cpp rename to fs_mgr/libsnapshot/snapuserd/snapuserd_server.cpp diff --git a/fs_mgr/libsnapshot/snapuserd_server.h b/fs_mgr/libsnapshot/snapuserd/snapuserd_server.h similarity index 100% rename from fs_mgr/libsnapshot/snapuserd_server.h rename to fs_mgr/libsnapshot/snapuserd/snapuserd_server.h diff --git a/fs_mgr/libsnapshot/snapuserd_worker.cpp b/fs_mgr/libsnapshot/snapuserd/snapuserd_worker.cpp similarity index 99% rename from fs_mgr/libsnapshot/snapuserd_worker.cpp rename to fs_mgr/libsnapshot/snapuserd/snapuserd_worker.cpp index 682f9da58..13d45fe4a 100644 --- a/fs_mgr/libsnapshot/snapuserd_worker.cpp +++ b/fs_mgr/libsnapshot/snapuserd/snapuserd_worker.cpp @@ -20,7 +20,7 @@ #include #include -#include +#include namespace android { namespace snapshot { diff --git a/init/snapuserd_transition.cpp b/init/snapuserd_transition.cpp index 40467b7d3..9a0b3b7fd 100644 --- a/init/snapuserd_transition.cpp +++ b/init/snapuserd_transition.cpp @@ -33,10 +33,10 @@ #include #include #include -#include #include #include #include +#include #include "block_dev_initializer.h" #include "service_utils.h"