Merge changes from topic "healthd_test"

* changes:
  Add libhealthd_charger_test to presubmit.
  Convert healthd_test to Soong
  Fix AnimationParser remove_prefix test
This commit is contained in:
Yifan Hong 2020-08-07 00:38:50 +00:00 committed by Gerrit Code Review
commit 17ed9c4fb6
6 changed files with 29 additions and 24 deletions

View file

@ -240,3 +240,20 @@ cc_test {
defaults: ["charger_defaults"],
srcs: ["charger_test.cpp"],
}
cc_test {
name: "libhealthd_charger_test",
srcs: ["AnimationParser_test.cpp"],
shared_libs: [
"liblog",
"libbase",
"libcutils",
],
static_libs: [
"libhealthd_charger",
],
test_suites: [
"general-tests",
"device-tests",
],
}

View file

@ -37,8 +37,8 @@ bool can_ignore_line(const char* str) {
return true;
}
bool remove_prefix(const std::string& line, const char* prefix, const char** rest) {
const char* str = line.c_str();
bool remove_prefix(std::string_view line, const char* prefix, const char** rest) {
const char* str = line.data();
int start;
char c;

View file

@ -17,6 +17,8 @@
#ifndef HEALTHD_ANIMATION_PARSER_H
#define HEALTHD_ANIMATION_PARSER_H
#include <string_view>
#include "animation.h"
namespace android {
@ -24,7 +26,7 @@ namespace android {
bool parse_animation_desc(const std::string& content, animation* anim);
bool can_ignore_line(const char* str);
bool remove_prefix(const std::string& str, const char* prefix, const char** rest);
bool remove_prefix(std::string_view str, const char* prefix, const char** rest);
bool parse_text_field(const char* in, animation::text_field* field);
} // namespace android

7
healthd/TEST_MAPPING Normal file
View file

@ -0,0 +1,7 @@
{
"presubmit": [
{
"name": "libhealthd_charger_test"
}
]
}

View file

@ -1,21 +0,0 @@
# Copyright 2016 The Android Open Source Project
LOCAL_PATH:= $(call my-dir)
include $(CLEAR_VARS)
LOCAL_SRC_FILES := \
AnimationParser_test.cpp \
LOCAL_MODULE := healthd_test
LOCAL_MODULE_TAGS := tests
LOCAL_STATIC_LIBRARIES := \
libhealthd_internal \
LOCAL_SHARED_LIBRARIES := \
liblog \
libbase \
libcutils \
include $(BUILD_NATIVE_TEST)