ACPR/android_system_core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

crash-reporter: Activate updated BadDirectory test

Browse source 
Activated the BadDirectory test which was breaking the build.

BUG=chromium-os:18622
TEST=Ran the unit tests locally and it succeded.

Change-Id: I439d9fb40ec37261ef839c82817d6bc67e683c7d
Signed-off-by: Sergiu Iordache <sergiu@chromium.org>
Reviewed-on: http://gerrit.chromium.org/gerrit/5433
Reviewed-by: Ken Mixter <kmixter@chromium.org>
Tested-by: Michael Krebs <mkrebs@chromium.org>
This commit is contained in:
Sergiu Iordache 2011-08-05 15:32:15 -07:00 • committed by Michael Krebs
parent 65b4c1efb0
commit ae33866aea
1 changed files with 8 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
crash_reporter/kernel_collector_test.cc
View file

@ -230,15 +230,14 @@ TEST_F(KernelCollectorTest, CollectNoCrash) {
ASSERT_EQ(0, s_crashes);
}
// Disabled for crosbug.com/18622
//TEST_F(KernelCollectorTest, CollectBadDirectory) {
// collector_.SetParameters(17, 0, 17);
// WriteStringToFile(test_kcrash_, "====1.1\nsomething");
// ASSERT_TRUE(collector_.Collect());
// ASSERT_TRUE(FindLog(
// "Unable to create appropriate crash directory"));
// ASSERT_EQ(1, s_crashes);
//}
TEST_F(KernelCollectorTest, CollectBadDirectory) {
collector_.SetParameters(17, 0, 17);
WriteStringToFile(test_kcrash_, "====1.1\nsomething");
ASSERT_TRUE(collector_.Collect());
ASSERT_TRUE(FindLog(
"Unable to create appropriate crash directory"));
ASSERT_EQ(1, s_crashes);
}
void KernelCollectorTest::SetUpSuccessfulCollect() {
collector_.ForceCrashDirectory(kTestCrashDirectory);