Commit graph

80001 commits

Author SHA1 Message Date
Kiyoung Kim
201dac162c Merge "Remove LLNDK libraries from system required" am: 5bc57325fb
Original change: https://android-review.googlesource.com/c/platform/system/core/+/2319962

Change-Id: I03c535a7cdb931b4e38b590a420a9a1a577948d9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-06 00:56:27 +00:00
Treehugger Robot
701f00fd4c Merge "init: Do not invoke the ServiceList destructor when exiting" am: dfc88362b1
Original change: https://android-review.googlesource.com/c/platform/system/core/+/2328595

Change-Id: Ie4d505be5198d258d9d77f32672850b450f8b84b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-06 00:56:08 +00:00
Kiyoung Kim
5bc57325fb Merge "Remove LLNDK libraries from system required" 2022-12-06 00:48:15 +00:00
Treehugger Robot
dfc88362b1 Merge "init: Do not invoke the ServiceList destructor when exiting" 2022-12-06 00:14:43 +00:00
Treehugger Robot
3dbaa1fc10 Merge "Suppress clang-tidy on crasher.cpp" am: a8ff9a4955
Original change: https://android-review.googlesource.com/c/platform/system/core/+/2326314

Change-Id: Iae9fd3386cb1ffaa5555aed877d606c716d7dec3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-05 21:49:18 +00:00
Treehugger Robot
a8ff9a4955 Merge "Suppress clang-tidy on crasher.cpp" 2022-12-05 21:26:39 +00:00
Chih-Hung Hsieh
3ec1e81425 Suppress clang-tidy on crasher.cpp
* Intentional crash test code with null/free/escape warnings.

Test: make tidy-system-core-debuggerd_subset
Change-Id: Ib1255c17a374729c82aa246c6a59156dbc4e1b77
2022-12-05 11:28:40 -08:00
Bart Van Assche
c41a4826d1 init: Do not invoke the ServiceList destructor when exiting
From the Google C++ style guide: "Objects with static storage duration
are forbidden unless they are trivially destructible." Hence this CL.

Bug: 213617178
Change-Id: I4c9a51618ee1eb14ed439295a5fc0101b940a63d
Signed-off-by: Bart Van Assche <bvanassche@google.com>
2022-12-05 10:45:49 -08:00
Eran Messeri
6c29c112d3 Merge "Update the KeyMint version to 3" am: 633b9ba26b
Original change: https://android-review.googlesource.com/c/platform/system/core/+/2294697

Change-Id: Ib02ac9f1e8b36c7f3ad9ecb367de271beb41de43
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-05 17:39:33 +00:00
Eran Messeri
633b9ba26b Merge "Update the KeyMint version to 3" 2022-12-05 17:16:16 +00:00
Armelle Laine
127abfa058 Merge "trusty/test/binder: Add package support for modules that have AIDL interfaces" am: c4108e917b
Original change: https://android-review.googlesource.com/c/platform/system/core/+/2166216

Change-Id: Iea999b38cb5257ff3db996d75a908a0a0956bc51
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-02 23:40:48 +00:00
Armelle Laine
c4108e917b Merge "trusty/test/binder: Add package support for modules that have AIDL interfaces" 2022-12-02 23:22:39 +00:00
Christopher Ferris
9391712450 Merge "Add myself to janitor owners." am: c444569a82
Original change: https://android-review.googlesource.com/c/platform/system/core/+/2325556

Change-Id: I896ddcafb12c93874284d8ed2231f47b8657d0e4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-02 23:06:14 +00:00
Chih-hung Hsieh
9fdeef7052 Merge "Fix "Attempt to delete released memory" warning." am: 0a5c0b4364
Original change: https://android-review.googlesource.com/c/platform/system/core/+/2323086

Change-Id: Ie731fdbc2cb9f8902e880f78ca7aa2b8e19b3cac
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-02 23:04:51 +00:00
Christopher Ferris
c444569a82 Merge "Add myself to janitor owners." 2022-12-02 23:01:59 +00:00
Chih-hung Hsieh
0a5c0b4364 Merge "Fix "Attempt to delete released memory" warning." 2022-12-02 22:36:39 +00:00
Christopher Ferris
6a907a10aa Add myself to janitor owners.
Since I have to go around the tree modifying code when updating
kernel headers, it seems to make sense to get on this list.

Test: NA
Change-Id: I714b1cbacd336deef1d0e37576d2ab500832eb1a
2022-12-02 12:50:43 -08:00
Chih-Hung Hsieh
c76bc32d95 Fix "Attempt to delete released memory" warning.
EXPECT_NONFATAL_FAILURE(statement, ...) expands to
  do {
    ... statement ...
  } while (::testing::internal::AlwaysFalse());

Clang analyzer cannot see into AlwaysFalse(),
and gives a false warning assuming that the
do loop can be done twice.

Use a unique_ptr::reset to call delete,
because reset can be called multiple times..

Bug: 259999410
Test: make tidy-system-core-fastboot_subset
Change-Id: Ie536f76635dd55f4e47b80eed6498fd1193b88ee
2022-12-02 12:38:41 -08:00
David Anekstein
d12c75f531 trusty/test/binder: Add package support for modules that have AIDL interfaces
Bug: 240461931
Change-Id: Ia88303a4b806be860cac5a324d55d0ab87dce189
2022-12-02 20:27:28 +00:00
Treehugger Robot
9d1460be06 Merge "Fix nullptr access when cow reader open fails" am: 9e6005ada4
Original change: https://android-review.googlesource.com/c/platform/system/core/+/2325397

Change-Id: Ic8cc95b0548039f6c04c24e6f4209a71c878c00a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-02 20:06:50 +00:00
Treehugger Robot
9e6005ada4 Merge "Fix nullptr access when cow reader open fails" 2022-12-02 19:25:32 +00:00
Kelvin Zhang
bc1a5b1393 Fix nullptr access when cow reader open fails
Bug: 260805150
Test: th
Change-Id: Id945cc4fa0fce141e3d52b8259241e22ba590ebd
2022-12-02 09:50:44 -08:00
Daeho Jeong
69525ba396 Merge "set iostat_period_ms to 1 sec" am: eff9050ccf
Original change: https://android-review.googlesource.com/c/platform/system/core/+/2321866

Change-Id: I084930cf8ff40a317622b32e5acbaf93e69c935c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-02 05:20:58 +00:00
Daeho Jeong
eff9050ccf Merge "set iostat_period_ms to 1 sec" 2022-12-02 05:05:12 +00:00
Daeho Jeong
2accf5bd79 set iostat_period_ms to 1 sec
Current period of this is 3 sec and it is used when Perfetto profiling is running on Android. Without Perfetto profiling, it doesn't affect the system at all. However, 3 sec doesn't provide enough granularity to understand F2FS I/O behaviors. To make F2FS I/O profiling ftrace effective, set the ftrace period to 1 sec.

Test: check f2fs iostat_period_ms sysfs node value
Change-Id: I2d418795613dfbd1aea6c4f13c9a39af3deb1c4d
Signed-off-by: Daeho Jeong <daehojeong@google.com>
2022-12-01 22:27:09 +00:00
Bart Van Assche
ee599c860d Merge "Revert "init: Add more diagnostics for signalfd hangs."" am: fa4926a9de
Original change: https://android-review.googlesource.com/c/platform/system/core/+/2254119

Change-Id: If6230e00484ec556b5f55298b4d239936ecd437b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-01 18:08:47 +00:00
Bart Van Assche
fa4926a9de Merge "Revert "init: Add more diagnostics for signalfd hangs."" 2022-12-01 17:50:27 +00:00
Treehugger Robot
bb033fc503 Merge "fs_mgr/OWNERS: Update bug component" am: 2e2fed7668
Original change: https://android-review.googlesource.com/c/platform/system/core/+/2319185

Change-Id: I3987b0ef2f48e245e12111118a929380df451745
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-01 17:33:00 +00:00
Treehugger Robot
2e2fed7668 Merge "fs_mgr/OWNERS: Update bug component" 2022-12-01 17:16:57 +00:00
Yi-Yo Chiang
701d643b2a fs_mgr/OWNERS: Update bug component
Fix: 261015598
Test: none
Change-Id: I52c6cca5d46f7c6f02e6b4ca608e14ef3a3de81b
2022-12-01 23:47:02 +08:00
Eran Messeri
e345066058 Update the KeyMint version to 3
Part of the change to support 2nd IMEI attestation.

Bug: 244732345
Test: atest keystore2_test android.keystore.cts.DeviceOwnerKeyManagementTest
Change-Id: I59544e1e8019869cadeb7b46800c9b519048934c
2022-12-01 11:00:16 +00:00
Treehugger Robot
97f5b24c94 Merge "init: Fix and re-enable the init#StartConsole test" am: 7bc5a7ef5f
Original change: https://android-review.googlesource.com/c/platform/system/core/+/2313501

Change-Id: I011da24acae1e06f2435c2778f0dcbd189ad169b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-01 05:20:40 +00:00
Treehugger Robot
7bc5a7ef5f Merge "init: Fix and re-enable the init#StartConsole test" 2022-12-01 04:56:09 +00:00
Kiyoung Kim
62a307ab61 Remove LLNDK libraries from system required
Remove LLNDK libraries from system required libs as those libraries will
be appended to the configuration from the build.

Bug: 251782700
Test: Cuttlefish build and boot succeeded
Change-Id: I81d508a5e15a9dd1919935f07569271609738710
2022-12-01 11:36:45 +09:00
David Anderson
0f1a36d9f8 Merge "libsnapshot: Disable 32-bit VTS tests on 64-bit systems." am: 85b7bbf41f
Original change: https://android-review.googlesource.com/c/platform/system/core/+/2280311

Change-Id: Id80191c6ade03b3d0f28c95a195bc027ce64bd96
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-01 00:55:27 +00:00
David Anderson
85b7bbf41f Merge "libsnapshot: Disable 32-bit VTS tests on 64-bit systems." 2022-12-01 00:25:24 +00:00
Treehugger Robot
c8d405ebd8 Merge "trusty/storage: Add property indicating when fs is ready" am: a3e605486d
Original change: https://android-review.googlesource.com/c/platform/system/core/+/2310114

Change-Id: I096c47014cc8911c26cc06a7a02627ccb7c99966
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-30 21:35:14 +00:00
Bart Van Assche
3b21d95a0e init: Fix and re-enable the init#StartConsole test
Skip the test if /dev/console does not exist. Fix the console service
security label. Fix the getsid() test.

Bug: 260104465
Test: atest 'CtsInitTestCases:init#StartConsole' on a P2023 development board
Change-Id: If2533a3f205f922a9b04a748cb558a09c5925986
Signed-off-by: Bart Van Assche <bvanassche@google.com>
2022-11-30 13:25:47 -08:00
Treehugger Robot
a3e605486d Merge "trusty/storage: Add property indicating when fs is ready" 2022-11-30 21:06:13 +00:00
Bart Van Assche
29d8a42d14 Revert "init: Add more diagnostics for signalfd hangs."
Revert commit 14f9c15e05 ("init: Add more diagnostics for signalfd
hangs") because:
* That commit was intented to help with root-causing b/223076262.
* The root cause of b/223076262 has been fixed (not blocking SIGCHLD
  in all threads in the init process).

Test: Treehugger
Change-Id: I586663ec0588e74a9d58512f7f31155398cf4f52
Signed-off-by: Bart Van Assche <bvanassche@google.com>
2022-11-30 09:17:16 -08:00
Max Bires
57d837ac95 Merge "Add TEST_MAPPING files." am: f9e6c5104d
Original change: https://android-review.googlesource.com/c/platform/system/core/+/2321462

Change-Id: I2c4240ab4a5587ccdbbd3c1bcc3a9406efa86541
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-29 18:14:22 +00:00
Max Bires
f9e6c5104d Merge "Add TEST_MAPPING files." 2022-11-29 17:53:18 +00:00
Martin Stjernholm
147a6b3aae Merge "Remove dalvik.vm.usejitprofiles system property." am: 84681d34f6
Original change: https://android-review.googlesource.com/c/platform/system/core/+/2317956

Change-Id: I90c0e2dcd5761f3439e3f75f4c3a3152fc608044
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-29 11:51:25 +00:00
Martin Stjernholm
84681d34f6 Merge "Remove dalvik.vm.usejitprofiles system property." 2022-11-29 11:15:45 +00:00
Max Bires
065a7207a2 Add TEST_MAPPING files.
These TEST_MAPPING definitions ensure that the VTS tests for the
respective HAL services will be executed upon any changes committed to
the HAL services.

Test: hopefully this is the test
Change-Id: Icfaf3621f2c7b9608deb998ba4b5cfd6621a7310
2022-11-29 02:50:45 -08:00
Treehugger Robot
11c22fcc00 Merge "libutils: Fix missing definition of shared_ptr and unique_ptr" am: dfdcc31d03
Original change: https://android-review.googlesource.com/c/platform/system/core/+/2318113

Change-Id: I37fdc24c266ffb2dd7506bf70c366d96f75fc4d0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-29 02:16:45 +00:00
Treehugger Robot
dfdcc31d03 Merge "libutils: Fix missing definition of shared_ptr and unique_ptr" 2022-11-29 01:51:25 +00:00
Martin Stjernholm
b46b947597 Remove dalvik.vm.usejitprofiles system property.
Disabling profiles is no longer supported. Most of the profile support
has been active even when this property was false, and it won't be
supported in the ART Service.

Test: atest -a propertyinfoserializer_tests
Bug: 254434433
Change-Id: I49272b0976f71fcd2e18d04a5b6cc3548a5f9d3f
2022-11-25 12:27:37 +00:00
Biswapriyo Nath
890f064990 libutils: Fix missing definition of shared_ptr and unique_ptr
This includes memory header for shared_ptr and unique_ptr templates.
Fixes the following errors:

RefBase.h:803:1: error: ‘shared_ptr’ does not name a type
RefBase.h:810:1: error: ‘unique_ptr’ does not name a type

Change-Id: I6a7a67333c9ef05250c5a3c6199d7fac288f946b
2022-11-25 12:15:53 +05:30
Stephen Crane
319f4618a7 trusty/storage: Add property indicating when fs is ready
Adds a system vendor property (ro.vendor.trusty.storage.fs_ready) to
indicate when backing storage on the Android filesystem (e.g. /data) is
ready for use. Before this property is set, the Trusty storage proxy may
restart causing connections in Trusty to the storage service to be
disconnected. All Trusty operations that may require storage and can
wait until the device filesystems are ready should wait on this
property.

Bug: 258018785
Test: manual
Change-Id: I9b1408b72df34a0d0cbcc1b99e9617f15bc47558
2022-11-23 17:55:12 +00:00