Adding meta files also:
1) ensures atomically added crash reports
2) allows us to remove orphaned crash report payload files
(such as core files)
3) gives us better control over the number of reports in
crash directory
While we're here, also made these minor changes
1) send board (x86-generic, x86-mario, etc) to crash server
2) send hwclass to crash server
3) Only record crash reports when metrics are enabled.
4) No longer allow crash reporting to staging server.
BUG=6100,5805,5624,6865
TEST=unit tests plus UserCrash,CrashSender,KernelCrash autotests
Change-Id: Ieea9bdc8e0680b379c65b91cc56ca0611dd0f31c
Review URL: http://codereview.chromium.org/3436029
There's no need to write to a file since we only log messages for commandline parameter validations (ie. usage errors).
BUG=6446
TEST=unit test
Change-Id: I0e55d569534f953526a6b788dbc6b3e284ff8b4f
Review URL: http://codereview.chromium.org/3464008
Up to 32 crashes per spool and 32 sends per day.
BUG=6355,6782
Change-Id: I99e86265c035ad62937aa135467681be8ef70f9a
TEST=UserCrash and CrashSender
Review URL: http://codereview.chromium.org/3414006
logging_KernelCrashServer and logging_UserCrash tests fail on an Official
image, because crash_sender's is_official() test leaks the "Official" line:
grep needs the quiet option (and does not need a cut).
BUG=837
TEST=logging_UserCrash
Signed-off-by: Hugh Dickins <hughd@chromium.org>
Review URL: http://codereview.chromium.org/3357010
No kcrash was collected because the IsEnabled() test always failed:
we must do the kernel_collector->Enable() first. I've not checked
if this might break the Override path (for local testing): it's more
important for the feature to work for real than in an artificial test.
BUG=837,5865
TEST=logging_KernelCrashServer or manual procedure
Signed-off-by: Hugh Dickins <hughd@chromium.org>
Review URL: http://codereview.chromium.org/3317007
BUG=6134
TEST=Run CrashSender and UserCrash, also test starting those tests while crash_sender is already running.
Change-Id: Ie80c450f6b0da1b67398aa67fd9b74903abc430b
Review URL: http://codereview.chromium.org/3197024
