Commit graph

79470 commits

Author SHA1 Message Date
Christopher Ferris
63fa82da36 Merge "Fix thread unwind in CallStack." am: 16909c5fc7 am: 4cea1cd5ce am: 05009ec97a am: 34194c8de6
Original change: https://android-review.googlesource.com/c/platform/system/core/+/2215567

Change-Id: I67c7d5ed446567db8c532208ed617125ed2c43db
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-13 23:04:22 +00:00
Christopher Ferris
34194c8de6 Merge "Fix thread unwind in CallStack." am: 16909c5fc7 am: 4cea1cd5ce am: 05009ec97a
Original change: https://android-review.googlesource.com/c/platform/system/core/+/2215567

Change-Id: I36b3a6a5674d7a8e57bdfd6fd051ac64e0919e41
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-13 22:38:10 +00:00
Christopher Ferris
05009ec97a Merge "Fix thread unwind in CallStack." am: 16909c5fc7 am: 4cea1cd5ce
Original change: https://android-review.googlesource.com/c/platform/system/core/+/2215567

Change-Id: Id2ea1211f04abc535fb8238f69173ef932483ebc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-13 22:10:48 +00:00
Christopher Ferris
4cea1cd5ce Merge "Fix thread unwind in CallStack." am: 16909c5fc7
Original change: https://android-review.googlesource.com/c/platform/system/core/+/2215567

Change-Id: I9b652f9d0e3b93b8fd0cf32aac641847977bf680
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-13 21:41:34 +00:00
Christopher Ferris
16909c5fc7 Merge "Fix thread unwind in CallStack." 2022-09-13 21:14:02 +00:00
Pete Bentley
5db5919f7f Merge "init: Add option to listen on sockets before starting service." am: 39fee4c4c0 am: fbf5cb06ba am: 669bdbef9d am: fddb6279ac
Original change: https://android-review.googlesource.com/c/platform/system/core/+/2215044

Change-Id: Iee9f7766d1152d5c41d369853cec28ce301ea5f7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-13 13:21:20 +00:00
Pete Bentley
fddb6279ac Merge "init: Add option to listen on sockets before starting service." am: 39fee4c4c0 am: fbf5cb06ba am: 669bdbef9d
Original change: https://android-review.googlesource.com/c/platform/system/core/+/2215044

Change-Id: Ie44eae0f3113c71e4212d38cecbdca0a8596f63a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-13 12:54:30 +00:00
Pete Bentley
669bdbef9d Merge "init: Add option to listen on sockets before starting service." am: 39fee4c4c0 am: fbf5cb06ba
Original change: https://android-review.googlesource.com/c/platform/system/core/+/2215044

Change-Id: I00e34d5e812cff1b66c4af37107414d1504aeb2c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-13 12:23:54 +00:00
Pete Bentley
fbf5cb06ba Merge "init: Add option to listen on sockets before starting service." am: 39fee4c4c0
Original change: https://android-review.googlesource.com/c/platform/system/core/+/2215044

Change-Id: I3172a5c089e86a4715ae60689bc980fd09271259
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-13 11:53:26 +00:00
Pete Bentley
39fee4c4c0 Merge "init: Add option to listen on sockets before starting service." 2022-09-13 11:32:27 +00:00
Treehugger Robot
069908a1bd Merge "Explain how to get a tombstone proto." am: 8c8df2284b am: 4ab113b8fd am: a11fd621bd am: 9b3927f490
Original change: https://android-review.googlesource.com/c/platform/system/core/+/2215564

Change-Id: Ic18c2b63425ff2de6b4ef90abb3bb5b53c894495
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-13 03:44:12 +00:00
Treehugger Robot
9b3927f490 Merge "Explain how to get a tombstone proto." am: 8c8df2284b am: 4ab113b8fd am: a11fd621bd
Original change: https://android-review.googlesource.com/c/platform/system/core/+/2215564

Change-Id: I1fe2e1a0fa58bb0e4fac9c0964305430a0f1e8a2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-13 03:14:59 +00:00
Treehugger Robot
a11fd621bd Merge "Explain how to get a tombstone proto." am: 8c8df2284b am: 4ab113b8fd
Original change: https://android-review.googlesource.com/c/platform/system/core/+/2215564

Change-Id: I5e7155bafae6558d84816476253f2ed40ff89544
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-13 02:45:46 +00:00
Treehugger Robot
4ab113b8fd Merge "Explain how to get a tombstone proto." am: 8c8df2284b
Original change: https://android-review.googlesource.com/c/platform/system/core/+/2215564

Change-Id: Id209c8e176cd89ea90b713a41d4fa6a3c69b1d69
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-13 02:15:10 +00:00
Treehugger Robot
8c8df2284b Merge "Explain how to get a tombstone proto." 2022-09-13 01:42:12 +00:00
Christopher Ferris
15fee82247 Fix thread unwind in CallStack.
The CallStack unwind of a different thread was broken since it
wasn't properly setting the tid value.

Fix this problem and add new unit tests to verify the behavior.

Bug: 246405269

Test: New unit tests pass.
Test: Ran unit tests for 1000 operations to verify not flaky.
Change-Id: I00342e6cdcdb4bcb68f29734dadee6c987c98040
2022-09-12 18:37:22 -07:00
Elliott Hughes
df2e7eb3cc Explain how to get a tombstone proto.
There's a link here from the javadoc, but a link to the javadoc from
here seems like a good idea.

Test: N/A
Change-Id: I89a29f72d086d08174e72f7d0aa0421fe417f733
2022-09-12 22:24:18 +00:00
Automerger Merge Worker
90a7b9b26e Merge "Merge "libsnapshot: Remove flaky image creation test." into android13-tests-dev am: 220d4aba05" am: 61c82abe24 am: 576de022fa am: 31e99d0b2a am: 7499fdce07
Original change: https://android-review.googlesource.com/c/platform/system/core/+/2190056

Change-Id: I9cadcc7d083c9e31aece939e4e92b955f65df70d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-12 21:42:05 +00:00
Automerger Merge Worker
7499fdce07 Merge "Merge "libsnapshot: Remove flaky image creation test." into android13-tests-dev am: 220d4aba05" am: 61c82abe24 am: 576de022fa am: 31e99d0b2a
Original change: https://android-review.googlesource.com/c/platform/system/core/+/2190056

Change-Id: I4c15f2ef3c342ee52788cf61dbb7c592ead6e6b9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-12 21:14:29 +00:00
Automerger Merge Worker
31e99d0b2a Merge "Merge "libsnapshot: Remove flaky image creation test." into android13-tests-dev am: 220d4aba05" am: 61c82abe24 am: 576de022fa
Original change: https://android-review.googlesource.com/c/platform/system/core/+/2190056

Change-Id: I0abe039f54ab8ca9ca680faf9a34d33cc24eeff7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-12 20:39:30 +00:00
Automerger Merge Worker
576de022fa Merge "Merge "libsnapshot: Remove flaky image creation test." into android13-tests-dev am: 220d4aba05" am: 61c82abe24
Original change: https://android-review.googlesource.com/c/platform/system/core/+/2190056

Change-Id: I552eb6d4eb07944f9ff644d040f2799ba070cee6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-12 20:05:22 +00:00
Automerger Merge Worker
61c82abe24 Merge "Merge "libsnapshot: Remove flaky image creation test." into android13-tests-dev am: 220d4aba05" 2022-09-12 18:31:04 +00:00
David Anderson
430867e7cc Merge "libsnapshot: Remove flaky image creation test." into android13-tests-dev am: 220d4aba05
Original change: https://android-review.googlesource.com/c/platform/system/core/+/2190056

Change-Id: I91ca9d97ba751e292dd8f68188470ab6735e68eb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-12 18:31:00 +00:00
Adam Langley
ecc14a5958 init: Add option to listen on sockets before starting service.
Review note: Original change was a p-o-c by agl in
https://r.android.com/2094350 which I think is actually
production quality.  I'm just taking it over so that he doesn't
get spammed by any review comments as that's not a good use
of his time.

Needed for the hardware entropy daemon (see bug).

Original commit message:
If one needs to create a service that synchronously starts listening on
a socket then there are currently no good options.

The traditional UNIX solution is to have the service create the socket
and then daemonise. In this situation, init could start the service with
`exec_start` and yet not block forever because the service forks and
exits. However, when the initial child process exits, init kills the
daemon process:

> init: Killed 1 additional processes from a oneshot process group for
> service 'foo'. This is new behavior, previously child processes
> would not be killed in this case.

Next, there is a `socket` option for services and (although the
documentation didn't nail this down), the socket is created
synchronously by `start`. However, init doesn't call `listen` on the
socket so, until the service starts listening on the socket itself,
clients will get ECONNREFUSED.

This this change adds a `+listen` option, similar to `+passcred` which
allows a socket service to reliably handle connections.

Bug: 243933553
Test: Started prng_seeder from init using the new listen flag
Change-Id: I91b3b2b1fd38cc3d96e19e92b76c8e95788191d5
2022-09-12 15:16:35 +01:00
Suren Baghdasaryan
f09461e2fd Merge "init: Change extra_free_kbytes.sh to add margin relative to the default watermark level" am: 633ce78b94 am: 65a9da7612 am: c26e034424 am: 8f76cbd5f5
Original change: https://android-review.googlesource.com/c/platform/system/core/+/2194880

Change-Id: Ic52f212b816657a23bdbaf612cab58a8ea5d8d05
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-09 18:27:31 +00:00
Deyao Ren
c182fff76c Merge "Clean up services created after running test" am: 2880afb77f am: f71d80a154 am: 88a54e3bca am: da869fbab7
Original change: https://android-review.googlesource.com/c/platform/system/core/+/2209900

Change-Id: I0d282266c2656af173eca534491f4ab9d3cee4a1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-09 18:13:05 +00:00
Suren Baghdasaryan
8f76cbd5f5 Merge "init: Change extra_free_kbytes.sh to add margin relative to the default watermark level" am: 633ce78b94 am: 65a9da7612 am: c26e034424
Original change: https://android-review.googlesource.com/c/platform/system/core/+/2194880

Change-Id: Id7a7fdc6afe9794b03816830de8ebc4cd80a5781
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-09 17:47:30 +00:00
Deyao Ren
da869fbab7 Merge "Clean up services created after running test" am: 2880afb77f am: f71d80a154 am: 88a54e3bca
Original change: https://android-review.googlesource.com/c/platform/system/core/+/2209900

Change-Id: I40ffd1db7523e3e5ac8d18513e0ababf654a5a0d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-09 17:47:19 +00:00
Suren Baghdasaryan
c26e034424 Merge "init: Change extra_free_kbytes.sh to add margin relative to the default watermark level" am: 633ce78b94 am: 65a9da7612
Original change: https://android-review.googlesource.com/c/platform/system/core/+/2194880

Change-Id: Ie1e77baaf7db9c9d4766f81d5e1e615ac427ccda
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-09 17:20:15 +00:00
Deyao Ren
88a54e3bca Merge "Clean up services created after running test" am: 2880afb77f am: f71d80a154
Original change: https://android-review.googlesource.com/c/platform/system/core/+/2209900

Change-Id: I70e1049752ad959d7704ed7790fd36c0fbddddb2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-09 17:19:37 +00:00
Suren Baghdasaryan
65a9da7612 Merge "init: Change extra_free_kbytes.sh to add margin relative to the default watermark level" am: 633ce78b94
Original change: https://android-review.googlesource.com/c/platform/system/core/+/2194880

Change-Id: I35745072b0108994cf084cda46dd994f9279c4a0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-09 17:17:33 +00:00
Suren Baghdasaryan
633ce78b94 Merge "init: Change extra_free_kbytes.sh to add margin relative to the default watermark level" 2022-09-09 16:55:25 +00:00
Deyao Ren
f71d80a154 Merge "Clean up services created after running test" am: 2880afb77f
Original change: https://android-review.googlesource.com/c/platform/system/core/+/2209900

Change-Id: I2c9a38b428d8264e1904b73a904d8b82f865b40e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-09 16:50:11 +00:00
Deyao Ren
2880afb77f Merge "Clean up services created after running test" 2022-09-09 16:20:31 +00:00
deyaoren@google.com
909bc47536 Clean up services created after running test
Services created during new tests weren't properly cleaned up after tests. It caused slowdown of subsequent tests as described in b/244486404.
This change kills/terminates services after test with apex services.

To provide some context, original change is at https://android-review.googlesource.com/q/topic:vapex_stop_service. The issue was discovered by android test monitor and filed as a P0 bug.

Bug: 244486404
Change-Id: Ie64e0eb1686e94ef543a457ea49d1d7aeab38c97
2022-09-09 04:15:26 +00:00
Spandan Das
905ee94942 Merge "Declare the headers of the ndk_library" am: a23b5467dc am: dad50f950b am: 37b81deefb am: bd9fdd2df2
Original change: https://android-review.googlesource.com/c/platform/system/core/+/2211949

Change-Id: Ib34d49052b9e65b6a3676893c8448019b4bc78e0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-09 01:51:10 +00:00
Spandan Das
bd9fdd2df2 Merge "Declare the headers of the ndk_library" am: a23b5467dc am: dad50f950b am: 37b81deefb
Original change: https://android-review.googlesource.com/c/platform/system/core/+/2211949

Change-Id: I641e4bcf227db0ac7c84e960840a05901116df45
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-09 01:25:13 +00:00
Spandan Das
37b81deefb Merge "Declare the headers of the ndk_library" am: a23b5467dc am: dad50f950b
Original change: https://android-review.googlesource.com/c/platform/system/core/+/2211949

Change-Id: I7ec37d672163351fd0b50fe8755b02549100c08b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-09 00:55:58 +00:00
Spandan Das
dad50f950b Merge "Declare the headers of the ndk_library" am: a23b5467dc
Original change: https://android-review.googlesource.com/c/platform/system/core/+/2211949

Change-Id: Ifcbd2661f15817318fe882329b501b5b7b4fb182
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-09 00:27:24 +00:00
Spandan Das
a23b5467dc Merge "Declare the headers of the ndk_library" 2022-09-08 23:53:18 +00:00
Spandan Das
9b4bc28b43 Declare the headers of the ndk_library
This creates a dependency edge between the ndk_library and its headers,
which should be a no-op in regular Soong builds. This dependency edge
will be used in the Multi-tree project to export the relevant .h files into a well
known location

Test: m nothing
Bug: 239044713
Change-Id: I374b1529456c4c71ac419b4684f2fd215c68e791
2022-09-08 21:59:20 +00:00
David Anderson
51749de382 Merge "vts_libsnapshot_test: Fix test flakiness." am: 0dfbdc5bdb am: 9b60fd39e5 am: 386169c320 am: 43ef6d4264
Original change: https://android-review.googlesource.com/c/platform/system/core/+/2199352

Change-Id: I2d7334cc9a4dbe055bc1eda875639dc41913526d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-08 21:56:32 +00:00
David Anderson
43ef6d4264 Merge "vts_libsnapshot_test: Fix test flakiness." am: 0dfbdc5bdb am: 9b60fd39e5 am: 386169c320
Original change: https://android-review.googlesource.com/c/platform/system/core/+/2199352

Change-Id: Ifb553dd86269b1612c412813c79e284c51c09e56
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-08 21:29:07 +00:00
David Anderson
386169c320 Merge "vts_libsnapshot_test: Fix test flakiness." am: 0dfbdc5bdb am: 9b60fd39e5
Original change: https://android-review.googlesource.com/c/platform/system/core/+/2199352

Change-Id: I4ff6b8dda8f15d8ed150d41c90fcd585f8f9815d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-08 20:46:16 +00:00
David Anderson
9b60fd39e5 Merge "vts_libsnapshot_test: Fix test flakiness." am: 0dfbdc5bdb
Original change: https://android-review.googlesource.com/c/platform/system/core/+/2199352

Change-Id: I83eb0010991c945233bf9dbff56e5322736d8311
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-08 20:16:21 +00:00
David Anderson
0dfbdc5bdb Merge "vts_libsnapshot_test: Fix test flakiness." 2022-09-08 19:44:05 +00:00
Suren Baghdasaryan
cfd8864f9a init: Change extra_free_kbytes.sh to add margin relative to the default watermark level
extra_free_kbytes.sh accepts a parameter representing the number of KB
to add to low and high watermarks. It adds this margin to the current
watermark levels, however this is not how /proc/sys/vm/extra_free_kbytes
knob that it replaces used to work. The old knob would add the margin
relative to the original and not the current level of the watermarks.
Change extra_free_kbytes.sh to add the specified margin to the original
watermark levels to act as correct replacement of the old knob.

Bug: 242837506
Fixes: 642048d969 ("init: Add extra_free_kbytes.sh script to adjust watermark_scale_factor")
Test: repeatedly run 'setprop sys.sysctl.extra_free_kbytes 30375'
Signed-off-by: Suren Baghdasaryan <surenb@google.com>
Change-Id: I8af603ba00bd4fb8182b80b3c0969fa96cdd7311
2022-09-08 19:34:43 +00:00
Treehugger Robot
b14d9415ed Merge "[LSC] Add LOCAL_LICENSE_KINDS to system/core" am: a5d944f67d am: 7ce0d570e8 am: f815fe979d am: 7c2722d33d
Original change: https://android-review.googlesource.com/c/platform/system/core/+/2210342

Change-Id: I6c0e0fa6f2456afe8ac70c3ee7168c95312833d9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-08 19:34:41 +00:00
Treehugger Robot
7c2722d33d Merge "[LSC] Add LOCAL_LICENSE_KINDS to system/core" am: a5d944f67d am: 7ce0d570e8 am: f815fe979d
Original change: https://android-review.googlesource.com/c/platform/system/core/+/2210342

Change-Id: I0a04b4a4dfe807b3ad7809fb68df6230156d8dcd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-08 18:49:44 +00:00
Treehugger Robot
f815fe979d Merge "[LSC] Add LOCAL_LICENSE_KINDS to system/core" am: a5d944f67d am: 7ce0d570e8
Original change: https://android-review.googlesource.com/c/platform/system/core/+/2210342

Change-Id: I946412ba45b2a59723fc8d6c6b52052429a150fb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-08 18:07:27 +00:00