Commit graph

89619 commits

Author SHA1 Message Date
Owner Cleanup Bot
8896d29c5f Remove alanstokes@google.com from mini_keyctl/OWNERS
This suggested change is automatically generated based on group
memberships and affiliations.
If this change is unnecessary or in error, vote the lowest CR value
(i.e. reject the CL) and the bot will abandon it. Vote the highest CR to
approve this change. You may also abandon this change.

See the owner's recent activity for context:
https://android-review.googlesource.com/q/alanstokes@google.com

To report an issue, file a bug in the Infra>Codereview component.

Change-Id: I1b8637979a8206e6f8d1e56a7a9a4c84b7896739
2024-07-09 21:12:32 +00:00
Hans Boehm
1b251d441e Merge "Make timeout messages distinct" into main 2024-07-08 18:19:33 +00:00
Jiyong Park
e563c3f48a Merge "Use no_full_install: true instead of installable: false" into main 2024-07-04 00:37:39 +00:00
Hans Boehm
d9d7f7a8c3 Make timeout messages distinct
... so that we can confirm that it's actually the poll() call that's
timing out.

Bug: 332593241
Test: Treehugger
Change-Id: I529be76a268d7ba1f7f26a953eb84945f3ac4924
2024-07-03 17:33:08 -07:00
Jiyong Park
0bdd68bb06 Use no_full_install: true instead of installable: false
This is a follow-up on I37380c19232f2c497bdf492a83cdc16616f0ae8d.

Bug: 338160898
Bug: 345110999
Test: Microdroid boots even with BOARD_USES_RECOVERY_AS_BOOT
Change-Id: I41c1e40aeaffd5499fb6bd25e80b5be83470bc6b
2024-07-03 18:42:59 +09:00
Treehugger Robot
a22e44dead Merge "Make snapuserd recovery_available." into main 2024-07-02 20:07:38 +00:00
Treehugger Robot
24d7b0f193 Merge "Skip test that unmounts/remounts metadata partition" into main 2024-07-02 20:00:55 +00:00
David Anderson
dcc81d427a Make snapuserd recovery_available.
Bug: 349287459
Test: adb reboot recovery
      adb root
      adb shell ls -l /system/bin/snapuserd
Change-Id: I69a3f8d2fd2d7dc157d14a0f743650881eec473d
2024-07-02 11:01:13 -07:00
Ted Bauer
ef0f5bbcf1 Skip test that unmounts/remounts metadata partition
Aconfig flagging is migrating to a new storage backend that makes heavy
use of the /metadata partition. It is causing failures in tests like
vts_libsnapshot_test, which unmount and remount this partition. The
failed unmounts are due to the partition being busy.

The test should be reworked to not unmount and remount the partition;
linked bug in GSKIP_TEST for followup.

Bug: 349807180
Bug: 350715463
Test: m vts_libsnapshot_test
Change-Id: Ie4f8cadcad189b13b9eba1eb15c5251002e8138a
2024-07-02 15:05:23 +00:00
Michael Hoisie
a79e3d4c0f Merge "Add support for ashmem-host for host Windows" into main 2024-07-02 14:50:45 +00:00
Treehugger Robot
470e186547 Merge "Add length parameter to format /data" into main 2024-07-02 02:25:11 +00:00
Elliott Hughes
58a64a4d5d Merge "Insulate against log spam." into main 2024-07-01 17:32:21 +00:00
Elliott Hughes
ab772110c7 Insulate against log spam.
We may as well check the entire log. The previous bump seems to have made this test less flaky, so why not go all the way?

Change-Id: I26b7524731ec755b724b9363fc9151f6a6d9116d
2024-07-01 13:21:36 +00:00
Akilesh Kailash
9418c6712c Merge "libsnapshot: Check if the vendor is updated from Android S for GRF" into main 2024-06-29 00:11:19 +00:00
Tomasz Wasilczyk
e4cc38fa27 Merge "Migrate pthread to std::thread" into main 2024-06-28 23:34:45 +00:00
Akilesh Kailash
1bbf8f042f libsnapshot: Check if the vendor is updated from Android S for GRF
In a GRF config, if Vendor partition is updated from Android 12; post
OTA reboot, first stage init will communicate to daemon to check if the
daemon can support socket handoff. If that succeeds, then it is a signal
that the vendor has been updated from Android 12. Use a marker in
/metadata to signal that the vendor was updated. If the marker is present,
then post OTA reboot, userspace snapshot will be used.

Bug: 333854394
Test: OTA
Android U (system) + S (vendor) -> Android V (system) + V (Vendor)

Change-Id: Ie38c4379010789a84e5b44529b407f9f82135271
Signed-off-by: Akilesh Kailash <akailash@google.com>
2024-06-28 15:34:41 -07:00
Tomasz Wasilczyk
d41c0f4a9e Migrate pthread to std::thread
Bug: 341997808
Test: atest --host libutils_test
Change-Id: I4f435d5d85efcbcc351b7620811c172badc2276d
2024-06-28 12:46:11 -07:00
Ashok Mutyala
dfd7b88fb4 Add length parameter to format /data
With metadata encryption, if partition is wiped (or) cryptfs failed , it will do format without length which make partition size is grown large to occupy remaining space instead of restricting the Android defined partition size

Bug: 343159184
Test: Add length flag in fstab && fastboot erase userdata && fastboot reboot && df -h /data

Signed-off-by: Ashok Mutyala <quic_amutyala@quicinc.com>
Change-Id: Ifce4b78df5edb899c84a032004895802766cd5cf
2024-06-28 18:13:29 +05:30
Treehugger Robot
2d4d60cccb Merge "Call sync() to guarantee blocks were released by unlink" into main 2024-06-28 00:18:23 +00:00
Treehugger Robot
59a11e37aa Merge "Revert^2 "Move StagedRollbackTest from postsubmit to presubmit"" into main 2024-06-27 20:02:24 +00:00
Jaegeuk Kim
a7b4a9d4f9 Call sync() to guarantee blocks were released by unlink
Otherwise, the cached inode does not release the blocks which causes next
allocation for pinning fails.

Bug: 349270107
Change-Id: I4c2886683ea1949c1999e551a80b56dc37459dba
Signed-off-by: Jaegeuk Kim <jaegeuk@google.com>
2024-06-27 17:29:28 +00:00
T.J. Mercier
36e2a44710 Revert^2 "Move StagedRollbackTest from postsubmit to presubmit"
This reverts commit 104d3cc4b9.

Reason for revert: change from presubmit to presubmit-large
Bug: 349693967

Change-Id: I47ea41162aea0140bc460521d0638ce9ca8a96a3
2024-06-27 01:59:14 +00:00
T.J. Mercier
95a9a432be Merge "Revert "Move StagedRollbackTest from postsubmit to presubmit"" into main 2024-06-27 01:57:58 +00:00
Pechetty Sravani
104d3cc4b9 Revert "Move StagedRollbackTest from postsubmit to presubmit"
This reverts commit 0509c71cc4.

Reason for revert: Droidmonitor triggered revert due to Test breakage in b/349693967. Will be verifying through ABTD before submission.

Change-Id: I66a706b8b4f9bf802f7ea1a6b50bb4847b915c92
2024-06-27 01:49:59 +00:00
Treehugger Robot
40fd5beb0d Merge "Move StagedRollbackTest from postsubmit to presubmit" into main 2024-06-27 00:46:30 +00:00
T.J. Mercier
0509c71cc4 Move StagedRollbackTest from postsubmit to presubmit
Bug: 324596460
Change-Id: Iad7bfd7cb56f0c16366a9aa61b9466545ee4c661
2024-06-26 23:09:03 +00:00
T.J. Mercier
3d54c32e33 Merge "libprocessgroup: Add MaxActivationDepth" into main 2024-06-26 22:57:45 +00:00
Jahin Imtiaz
969888c1a5 Merge "Opt out of gtest error if no binary found" into main 2024-06-26 22:50:27 +00:00
Elliott Hughes
25ad0cae8a Merge "fs_mgr_remount.cpp: pedantic grammar fixes." into main 2024-06-26 22:40:30 +00:00
jahinimtiaz
5c8a0f6752 Opt out of gtest error if no binary found
Bug: 348446766
Test: Presubmit
Change-Id: If1aaa9726529453fc612fe4dec31f334460436d4
2024-06-26 21:01:38 +00:00
Steven Moreland
3be1a10d9f Merge "libutils: CallStackTest log_stack check more log" into main 2024-06-26 20:42:02 +00:00
Elliott Hughes
791663022e fs_mgr_remount.cpp: pedantic grammar fixes.
In my defense, I genuinely thought it was telling me to try again.

Change-Id: I613cd076a13de440bc98a8385022dd9f4b74311c
2024-06-26 20:22:37 +00:00
Steven Moreland
47fde793b1 libutils: CallStackTest log_stack check more log
Check last 10,000 instead of last 1,000 log entries.

Fixes: 348793356
Test: presubmit

Change-Id: I08c660ddd7e49466a4b55d96e46a402ee8912a24
2024-06-26 17:52:47 +00:00
T.J. Mercier
b2bd7ae863 Merge "libutils: Remove unused dependency on libprocessgroup_headers" into main 2024-06-26 12:42:39 +00:00
Liana Kazanova
4056420015 Merge "Revert "Migrate vts_libsnapshot_test and friends to general-tests zip"" into main 2024-06-25 21:03:33 +00:00
Daniel Zheng
b5c9eb5c13 Merge "reupload^2: libsnapshot: set thread priority" into main 2024-06-25 20:42:58 +00:00
Priyanka Advani
8abaa8442f Revert "Migrate vts_libsnapshot_test and friends to general-tests zip"
This reverts commit 9fbe526622.

Reason for revert: Droidmonitor created revert due to b/349278999. Will be verifying through ABTD before submission.

Change-Id: I9eae3b5ce729e0efdc092c814cbe225bcd43d32f
2024-06-25 18:11:53 +00:00
Treehugger Robot
69833ff06b Merge "Rewrite init_vendor using select syntax" into main 2024-06-25 05:51:55 +00:00
Julien Desprez
ce2e552c52 Merge "Migrate vts_libsnapshot_test and friends to general-tests zip" into main 2024-06-25 04:47:08 +00:00
Treehugger Robot
01d04dc5e3 Merge "libcutils: Add missing dependency on libprocessgroup_headers" into main 2024-06-25 02:27:11 +00:00
Daniel Zheng
7b55fbc6d4 reupload^2: libsnapshot: set thread priority
It looks like the previous error was due to a missing include that
somehow my LSP didn't catch. The build failure isn't reproducible on
aosp-main but is on git_main. Confirmed this new patch with the #include
builds correctly on git_main.

Read merge thread + worker thread priority from build configurations. In
the case of low memory devices, a lower priority will reduce CPU
utilization post OTA reboot.

Test: th
Change-Id: I7fd398c4688cf78abe738e7320b9f27f5f7d1e13
2024-06-24 14:11:40 -07:00
Julien Desprez
9fbe526622 Migrate vts_libsnapshot_test and friends to general-tests zip
for things that works in VTS, they should be buildable in general-tests
zip rather than device-tests. Which is cheaper in term of build resources.

Change-Id: If12442bf88cb5dd2b503e8023f925015890a39e2
Test: presubmit
Bug: None
2024-06-24 20:37:20 +00:00
T.J. Mercier
6f13d115eb libutils: Remove unused dependency on libprocessgroup_headers
Bug: 349105928
Test: m
Change-Id: Ic3e64b073c0ba087c3db19fb428c8c9132c8211f
2024-06-24 20:18:55 +00:00
T.J. Mercier
1fd7993f85 libcutils: Add missing dependency on libprocessgroup_headers
cutils/sched_policy.h redirects to processgroup/sched_policy.h, but
libcutils does not export the libprocessgroup headers. So users have to
know about the hidden redirect to libprocessgroup and include a
libprocessgroup dependency in their Android.bp files in addition to
libcutils. Fix that.

Bug: 349105928
Test: m
Change-Id: I516bdf2cdeff980c1fcd18883ef8a2f0a9beb629
2024-06-24 19:09:02 +00:00
Treehugger Robot
5bba244398 Merge "Make libexpresslog apex available" into main 2024-06-21 23:04:59 +00:00
Nelson Li
c2970dd06f Rewrite init_vendor using select syntax
The `select` syntax rewrite makes it more concise and easier to
understand.

Bug: 347605145
Test: m init_vendor
Change-Id: I866bbe9360fdbdf69cac3c6a24bbe37306227755
2024-06-19 02:14:23 +00:00
Daniel Zheng
116a713383 Merge "Revert "reupload: libsnapshot: set thread priority"" into main 2024-06-18 22:21:39 +00:00
Liana Kazanova
a8f130693d Revert "reupload: libsnapshot: set thread priority"
This reverts commit 00e1b61bb9.

Reason for revert: DroidMonitor: Potential culprit for b/348041418 - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.

Change-Id: Ib7422cc7bfb7815ede814fb5f0ee1d4537fe52d2
2024-06-18 22:20:43 +00:00
Daniel Zheng
76bf29a8ae Merge "reupload: libsnapshot: set thread priority" into main 2024-06-18 22:04:16 +00:00
T.J. Mercier
28b37f2704 libprocessgroup: Add MaxActivationDepth
Cgroup v2 controllers can be enabled in a subtree of the shared
hierarchy. That allows users to limit the number of cgroups with a
controller enabled to less than the total number of cgroups. [1]

There are costs for each cgroup. Kernel memory is used for each cgroup,
plus additional memory for each active controller in each cgroup. Some
kernel operations scale with the number of cgroups (with a given
controller enabled), so it can be desirable to minimize the number of
cgroups with that controller enabled.

This change allows each v2 controller configuration to specify a maximum
activation depth, past which the controller will not be activated deeper
in the Android cgroup v2 hierarchy. The hierarchy root is defined as
depth 0. MaxActivationDepth is the field name for this purpose for
controllers in the Controllers array under Cgroups2 in cgroups.json.

Here are two examples:

"MaxActivationDepth": 1
This will activate the controller in every per-application cgroup, but
not in the per-process cgroups below.

/sys/fs/cgroup                depth=0  active=true  (controller listed in cgroup.subtree_control)
/sys/fs/cgroup/uid_0          depth=1  active=true  (controller NOT listed in cgroup.subtree_control)
/sys/fs/cgroup/uid_0/pid_100  depth=2  active=false (controller NOT listed in cgroup.subtree_control)

This can also be used with
PRODUCT_CGROUP_V2_SYS_APP_ISOLATION_ENABLED := true.

"MaxActivationDepth": 1
This will activate the controller only at the app / system level, but
not in per-application cgroups below. This results in a total of only
3 cgroups with the controller enabled (root, apps, system).

/sys/fs/cgroup                         depth=0  active=true  (controller listed in cgroup.subtree_control)
/sys/fs/cgroup/apps                    depth=1  active=true  (controller NOT listed in cgroup.subtree_control)
/sys/fs/cgroup/apps/uid_10000          depth=2  active=false (controller NOT listed in cgroup.subtree_control)
/sys/fs/cgroup/apps/uid_10000/pid_100  depth=3  active=false (controller NOT listed in cgroup.subtree_control)

[1] https://www.kernel.org/doc/html/latest/admin-guide/cgroup-v2.html#enabling-and-disabling

Bug: 346584259
Test: Cuttlefish with memcg v2
Change-Id: I62109ea935261c51fc30b2054c4d28d0360f7985
2024-06-18 15:50:21 +00:00