ACPR/android_system_core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
58721 commits 1 branch 0 tags 217 MiB
Commit graph

58721 commits

This branch
This branch
All branches
Author SHA1 Message Date
Elliott Hughes
c9ca928f3f Merge "libdebuggerd: do a to-do." am: 5c2c72b44b 
Original change: https://android-review.googlesource.com/c/platform/system/core/+/1386256

Change-Id: I5ff9003b566f684c22a53513cf8819652ebf71b9
 2020-08-03 19:32:46 +00:00
Elliott Hughes
5c2c72b44b Merge "libdebuggerd: do a to-do." 2020-08-03 18:56:46 +00:00
Elliott Hughes
713ec25103 libdebuggerd: do a to-do. 
Until 77fdb22cf6, logd started as
AID_ROOT and then dropped its privileges. Since then, there's been no
reason to use string comparisons rather than checking the uid.

Test: pkill -SEGV logd
Test: treehugger
Change-Id: Ia709f8f59cb0ab9abac7df84c96c701b5d0a83ea
 2020-08-03 18:56:35 +00:00
Tom Cherry
10e45c1dc1 Merge "liblog: disable property tag tests" am: 86adfc7b0b 
Original change: https://android-review.googlesource.com/c/platform/system/core/+/1385695

Change-Id: Id9736173f3e278c5085dc2d1371a7b3e0b2da662
 2020-08-03 17:18:33 +00:00
Tom Cherry
86adfc7b0b Merge "liblog: disable property tag tests" 2020-08-03 16:58:06 +00:00
Tom Cherry
d836a61bb8 Merge "SocketClient: don't ignore SIGPIPE" am: 037292424e 
Original change: https://android-review.googlesource.com/c/platform/system/core/+/1383960

Change-Id: I74c594003f6d54955accb78ed0cd876ac7b099a2
 2020-08-03 16:03:58 +00:00
Tom Cherry
037292424e Merge "SocketClient: don't ignore SIGPIPE" 2020-08-03 15:55:47 +00:00
Elliott Hughes
78e66dbf7d Merge "Update language to comply with Android's inclusive language guidance" am: 9d7657b62e 
Original change: https://android-review.googlesource.com/c/platform/system/core/+/1382610

Change-Id: I0674880834a94a4987eeedc7e7fe53e5c1bbe72e
 2020-08-03 15:51:47 +00:00
Elliott Hughes
9d7657b62e Merge "Update language to comply with Android's inclusive language guidance" 2020-08-03 15:38:00 +00:00
Tom Cherry
3232957a93 Merge "logd: Add 'print_all_logs' to replay_messages" am: 3e967861da 
Original change: https://android-review.googlesource.com/c/platform/system/core/+/1382614

Change-Id: Ib3371ce6855dd1293b4836978234a64013e6c00c
 2020-08-03 15:37:50 +00:00
Tom Cherry
031d433472 liblog: disable property tag tests 
Disable:
liblog_global_state.is_loggable_both_set
liblog_global_state.is_loggable_tag_log_priority_only

Bug: 162633089
Bug: 162669552
Test: these tests don't run
Change-Id: I82b8e6685a321ae03374e86ffbe845608aec93b5
 2020-08-03 08:27:54 -07:00
Tom Cherry
3e967861da Merge "logd: Add 'print_all_logs' to replay_messages" 2020-08-03 15:19:05 +00:00
Treehugger Robot
220e60b1be Merge "Make the udev vs plugdev distinction a bit clearer." am: 9597f27e1b 
Original change: https://android-review.googlesource.com/c/platform/system/core/+/1383959

Change-Id: I348e7807565adb531ce73359806492a6b77b8ac1
 2020-08-01 02:09:30 +00:00
Treehugger Robot
9597f27e1b Merge "Make the udev vs plugdev distinction a bit clearer." 2020-08-01 01:47:56 +00:00
Treehugger Robot
e98bfc0d9d Merge "libsnapshot: Properly set partial_update_" am: 86313d6fdb 
Original change: https://android-review.googlesource.com/c/platform/system/core/+/1383957

Change-Id: I644ffdd48ac35e70cc67187c46086ad4611fa594
 2020-07-31 23:35:39 +00:00
Treehugger Robot
86313d6fdb Merge "libsnapshot: Properly set partial_update_" 2020-07-31 23:02:05 +00:00
Tom Cherry
2b3ebaf5c0 SocketClient: don't ignore SIGPIPE 
1) All current users are better off ignoring SIGPIPE at the beginning
   of their process instead of ignoring it just for SocketClient
2) This isn't thread safe if users did want it, since sigaction()
   ignores SIGPIPE for the entire process
3) This costs 5-10% of logd CPU time when logcat is reading logs

Also clean up the error handling in SocketClient::sendDataLockedv().

Test: kill logcat and see that logd doesn't crash
Test: run simpleperf and see that no cycles are going to sigaction
Change-Id: I6532c8a0d71338e534411707b9a9bd785145c730
 2020-07-31 15:53:18 -07:00
Jeff Sharkey
7b21637782 Update language to comply with Android's inclusive language guidance 
See https://source.android.com/setup/contribute/respectful-code for reference

Bug: 161896447
Change-Id: Iafcccbdbdf3ff1078e87000e2ce560ff09b43f68
 2020-07-31 16:36:06 -06:00
Tom Cherry
f1d938a5a4 logd: Add 'print_all_logs' to replay_messages 
Add 'print_all_logs' which is equivalent to running `logcat` from the
beginning of the captured log buffers.

Test: all logs can be replayed from the start
Change-Id: If0e25513fb294e61c834f82fbf90468c4b767424
 2020-07-31 15:30:52 -07:00
Elliott Hughes
e7edfbc916 Make the udev vs plugdev distinction a bit clearer. 
Bug: http://b/162109763
Test: treehugger
Change-Id: Id392d0d87dd6ba098382436062b90e3a5ed79025
 2020-07-31 15:09:35 -07:00
Yifan Hong
0403d8d2d5 libsnapshot: Properly set partial_update_ 
On GKI updates, has_dynamic_partition_metadata() may be false. Even if
it is the case, partial_update_ should be set properly.

Test: apply GKI update
Bug: 162616968

Change-Id: Icf055d8eb3060e36b3e977541a24f62f9fe11a6f
 2020-07-31 14:42:14 -07:00
Treehugger Robot
23caedd74f Merge "logd: disable flaky tests" am: fcaed0effa 
Original change: https://android-review.googlesource.com/c/platform/system/core/+/1383956

Change-Id: I3e142614096eaaad2ea3fde54c403a5dcda9c5f5
 2020-07-31 20:47:39 +00:00
Treehugger Robot
fcaed0effa Merge "logd: disable flaky tests" 2020-07-31 20:18:40 +00:00
Tom Cherry
bd5a283ccd logd: disable flaky tests 
Bug: 162600780
Test: build
Change-Id: I1da7531ab1c64d77ba228096913fc23d36ef5793
 2020-07-31 11:48:33 -07:00
Treehugger Robot
fbcc431f56 Merge "[incremental/adb] fix signature size check" am: 1c5a205fda 
Original change: https://android-review.googlesource.com/c/platform/system/core/+/1373276

Change-Id: I676de9e59f89c8711268afaf4b9a3caf705f7cab
 2020-07-30 22:50:44 +00:00
Treehugger Robot
1c5a205fda Merge "[incremental/adb] fix signature size check" 2020-07-30 22:27:27 +00:00
Tom Cherry
9fc97b8549 Merge "liblog: don't use a cache for __android_log_is_debuggable()" am: 88066a87bf 
Original change: https://android-review.googlesource.com/c/platform/system/core/+/1373469

Change-Id: I87aab47349d9237b4e52c2e67786ee5571bd51b4
 2020-07-30 15:43:08 +00:00
Tom Cherry
88066a87bf Merge "liblog: don't use a cache for __android_log_is_debuggable()" 2020-07-30 15:20:22 +00:00
Tom Cherry
f83640d65e liblog: don't use a cache for __android_log_is_debuggable() 
ro.debuggable is set by init before other processes would possibly
call __android_log_is_debuggable(), so this property can be checked
once and stored without liblog's property caching mechanisms.

Test: this function returns accurately
Change-Id: Idb1e5e10e53ca809b7f9a75164a4982f39827d4e
 2020-07-29 14:49:54 -07:00
Tom Cherry
04f4b02abf Merge "liblog: remove __android_logger_property_get_bool()" am: 3b8b444fce 
Original change: https://android-review.googlesource.com/c/platform/system/core/+/1374741

Change-Id: Ibb873f316efe4da4052136ebefbe73c6e7b1d221
 2020-07-29 21:38:45 +00:00
Tom Cherry
3b8b444fce Merge "liblog: remove __android_logger_property_get_bool()" 2020-07-29 21:22:38 +00:00
Treehugger Robot
b939c5602c Merge "Update language to comply with Android's inclusive language guidance" am: 98ea1340fb 
Original change: https://android-review.googlesource.com/c/platform/system/core/+/1373460

Change-Id: If9c37d71cb4e174f5292a527d877c60ae4ee9eb3
 2020-07-29 20:39:18 +00:00
Tom Cherry
3ffb78990b Merge "Run liblog and logd CTS tests in presubmit" am: 5a8d11af58 
Original change: https://android-review.googlesource.com/c/platform/system/core/+/1374752

Change-Id: I13c3b6ce237a81a5ff3c542462310463a808a4ba
 2020-07-29 20:38:43 +00:00
Treehugger Robot
98ea1340fb Merge "Update language to comply with Android's inclusive language guidance" 2020-07-29 20:32:34 +00:00
Tom Cherry
5a8d11af58 Merge "Run liblog and logd CTS tests in presubmit" 2020-07-29 20:18:25 +00:00
Tom Cherry
62068bfb4a liblog: remove __android_logger_property_get_bool() 
All users have been moved to other, more suitable, interfaces.

Test: build
Merged-In: Ic4eb1f0ed6e35d8d6f7e63b80546f4e8bbe163e2
Change-Id: Ic4eb1f0ed6e35d8d6f7e63b80546f4e8bbe163e2
 2020-07-29 19:58:30 +00:00
Tom Cherry
b4bc99e873 Run liblog and logd CTS tests in presubmit 
And sort the rest of the CTS tests.

Test: these tests run
Change-Id: I8eeb7b8acac2ed658b36da8463112fe1da8437a9
 2020-07-29 08:02:52 -07:00
Tom Cherry
bc72a26e5a Merge "logd: remove users of __android_logger_property_get_bool()" am: 898db00675 
Original change: https://android-review.googlesource.com/c/platform/system/core/+/1374736

Change-Id: I3d053ebc09468b64aea820b2dc8517d9e0280b61
 2020-07-29 14:55:24 +00:00
Tom Cherry
898db00675 Merge "logd: remove users of __android_logger_property_get_bool()" 2020-07-29 14:38:57 +00:00
Dan Albert
ac4500e67d Update language to comply with Android's inclusive language guidance 
See https://source.android.com/setup/contribute/respectful-code for reference

Bug: http://b/161896447
Test: None
Change-Id: I9e5a37a20012b2f7a8eac55701df03f7b7a9ab6c
 2020-07-28 15:58:25 -07:00
Christopher Ferris
c2f47347bc Merge "Cleanup for #inclusivefixit." am: 0d3dde2d97 
Original change: https://android-review.googlesource.com/c/platform/system/core/+/1374746

Change-Id: I84bbe21b670095088fec4eb3a1511b82ff6abfcd
 2020-07-28 21:17:29 +00:00
Christopher Ferris
0d3dde2d97 Merge "Cleanup for #inclusivefixit." 2020-07-28 21:01:52 +00:00
Tom Cherry
68261eec24 logd: remove users of __android_logger_property_get_bool() 
__android_logger_property_get_bool() has a clunky API and doesn't
belong in liblog, since a vast majority of liblog users will never
query this property.

Specifically
1) Replace with GetBoolProperty() when completely equivalent.
2) Remove checking if property values are 'eng' or 'svelte', since
   there's no evidence that those values were ever used.
3) Remove checking 'persist.logd.statistics' and 'ro.logd.statistics',
   since there's no evidence that those values were ever used.
4) Set ro.logd.kernel explicitly, so other processes don't need to
   replicate the defaults that logd uses.

Test: build
Change-Id: I7c37af64ba7754e839185f46da66bf077f09d9c3
 2020-07-28 13:16:11 -07:00
Elliott Hughes
7563eaffa4 Merge "Cleanup for #inclusivefixit." am: b0a9d0e703 
Original change: https://android-review.googlesource.com/c/platform/system/core/+/1373452

Change-Id: Ieb80a83978bfafd9531597ff1fd927ebfed18a89
 2020-07-28 19:50:37 +00:00
Treehugger Robot
ba9eef8708 Merge "Cleanup for #inclusivefixit." am: 6949036229 
Original change: https://android-review.googlesource.com/c/platform/system/core/+/1373453

Change-Id: I37de1f6dab8f8ee79dc6647f34b3797249ce4016
 2020-07-28 19:50:21 +00:00
Elliott Hughes
b0a9d0e703 Merge "Cleanup for #inclusivefixit." 2020-07-28 19:33:58 +00:00
Treehugger Robot
6949036229 Merge "Cleanup for #inclusivefixit." 2020-07-28 19:33:41 +00:00
Christopher Ferris
4f7a0f8c7c Cleanup for #inclusivefixit. 
Bug: 161896447

Test: NA
Change-Id: I8bc5b4be29f91b1884017aa3b4f28d91d9cac419
 2020-07-28 12:08:03 -07:00
Elliott Hughes
2c89f97f0a Cleanup for #inclusivefixit. 
Test: treehugger
Change-Id: I44f710cbda4497c9d01a1ff7c1dcdb8f0eda6acc
 2020-07-28 11:11:55 -07:00
Elliott Hughes
e79b8c2092 Cleanup for #inclusivefixit. 
Test: treehugger
Change-Id: I651689e2d59c017a9bde44251d95b57e594f0b5b
 2020-07-28 11:09:03 -07:00