James Hawkins
cefdacef3c
Merge "Revert "bootstat: Remove custom uptime parser in favor of elapsedRealtime.""
...
am: 23f4e6b0a5
Change-Id: Ibef66ccd1a1fe362692ee45cb86cd9c0212c1f85
2017-02-09 02:31:44 +00:00
James Hawkins
23f4e6b0a5
Merge "Revert "bootstat: Remove custom uptime parser in favor of elapsedRealtime.""
2017-02-09 00:12:54 +00:00
James Hawkins
0e3167e203
Revert "bootstat: Remove custom uptime parser in favor of elapsedRealtime."
...
This reverts commit 26f40c04c3 .
This change broke the Darwin SDK target.
Test: none
Change-Id: Ia54fe2c31da8d8fa2825e023b035fb8321dcd457
2017-02-08 14:16:51 -08:00
Josh Gao
c2d9b60e0a
Merge changes I1a28c21c,I02faec3b,I16a2050b
...
am: ec5d6cb8fd
Change-Id: I77a30bdf59ae0ec156d8ab2b9ad69b050e3e9ec2
2017-02-08 19:37:12 +00:00
Josh Gao
db22633766
crash_dump: collect open files before dropping caps.
...
am: c24cc8a9e5
Change-Id: Ic27d13c1132e8dc6f3a36757e56eff4af65c55c4
2017-02-08 19:37:11 +00:00
Josh Gao
1255609232
debuggerd_test: improve error when crasher fails to exec.
...
am: 7a0ee64f9d
Change-Id: I6c07c11094e67f502c7d2cd71dac0cbf78e7d422
2017-02-08 19:37:06 +00:00
Josh Gao
8c1ebc6037
debuggerd_test: fix crasher path.
...
am: a7d7eb6d2a
Change-Id: Ie87aa723909ea7eb9ce7fef17c9145fc8ce11b42
2017-02-08 19:37:00 +00:00
Josh Gao
ec5d6cb8fd
Merge changes I1a28c21c,I02faec3b,I16a2050b
...
* changes:
crash_dump: collect open files before dropping caps.
debuggerd_test: improve error when crasher fails to exec.
debuggerd_test: fix crasher path.
2017-02-08 19:31:57 +00:00
James Hawkins
cdfe67f575
Merge "bootstat: Remove custom uptime parser in favor of elapsedRealtime."
...
am: 914955ae9e
Change-Id: I5565b341338f75e9dbdd8405b07419219f61a940
2017-02-08 17:32:47 +00:00
Ting-Yuan Huang
68a6676c77
Merge "liblog: fix an undefined-behavor in __write_to_log_daemon()"
...
am: a3b6d30ba7
Change-Id: I5a50c19876333dfec5445838e6bcd3c406cdc5b2
2017-02-08 17:32:32 +00:00
Treehugger Robot
914955ae9e
Merge "bootstat: Remove custom uptime parser in favor of elapsedRealtime."
2017-02-08 17:28:12 +00:00
Treehugger Robot
a3b6d30ba7
Merge "liblog: fix an undefined-behavor in __write_to_log_daemon()"
2017-02-08 17:21:58 +00:00
Ting-Yuan Huang
161953f49c
Merge "liblog: fix a memory leak in __android_log_pmsg_file_write()"
...
am: a8629e8e15
Change-Id: I9eabd9930467bd540dbc603e68c3dcca4ba452df
2017-02-08 17:20:49 +00:00
Treehugger Robot
a8629e8e15
Merge "liblog: fix a memory leak in __android_log_pmsg_file_write()"
2017-02-08 16:50:09 +00:00
Ting-Yuan Huang
6efb877973
liblog: fix an undefined-behavor in __write_to_log_daemon()
...
The behavior of passing NULL to c-string functions is undefined.
Test: passed clang-tidy checks
Bug: none
Change-Id: Ie7bcc43cd19bc4a1c314381af3929eae0a6154b9
2017-02-07 16:42:53 -08:00
Ting-Yuan Huang
106c3e6189
liblog: fix a memory leak in __android_log_pmsg_file_write()
...
Free the strdup()-ed filename before returning error.
Test: passed clang-tidy checks
Bug: none
Change-Id: I555492cb4e50400db758f7c721647a8747874a01
2017-02-07 15:53:32 -08:00
James Hawkins
26f40c04c3
bootstat: Remove custom uptime parser in favor of elapsedRealtime.
...
Refactored init/utils/boot_clock into base/chrono_utils.
Bug: 34352037
Test: none
Change-Id: Ied0c00867336b85922369d7ff37520e3d28fc61e
2017-02-07 15:43:32 -08:00
Mark Salyzyn
a8c7b6e24f
Merge "liblog: logger.h fortify comments"
...
am: 8eb237ad57
Change-Id: Ifedfe4ab79a915c712e4e4f967e6dd5514dbd6ff
2017-02-07 23:42:31 +00:00
Mark Salyzyn
8eb237ad57
Merge "liblog: logger.h fortify comments"
2017-02-07 23:36:55 +00:00
Mark Salyzyn
7048f0b1cb
liblog: logger.h fortify comments
...
Test: none
Bug: 27405083
Change-Id: I88ae9f33daa457454edfc5e95cb9e9e74e8cd5f0
2017-02-07 14:16:09 -08:00
Josh Gao
c24cc8a9e5
crash_dump: collect open files before dropping caps.
...
/proc/<pid>/fd is also limited by ptrace_may_access.
Test: manual inspection of "debuggerd -b `pidof zygote`"
Change-Id: I1a28c21c0438fe8729bd8e041c6b418d6a84c586
2017-02-07 13:36:08 -08:00
Josh Gao
7a0ee64f9d
debuggerd_test: improve error when crasher fails to exec.
...
Bug: http://b/35100742
Test: rm /system/bin/crasher && /data/nativetest/debugerd_test/debuggerd_test32
Change-Id: I02faec3b7f7ef62bb8a2ac2af730506e3d28e03e
2017-02-07 13:36:08 -08:00
Josh Gao
a7d7eb6d2a
debuggerd_test: fix crasher path.
...
https://android-review.googlesource.com/#/c/331200 moved crasher to
using soong, which changed its location from /system/xbin/crasher to
/system/bin/crasher.
Bug: http://b/35100742
Test: /data/nativetest/debuggerd_test/debuggerd_test32
Test: /data/nativetest64/debuggerd_test/debuggerd_test64
Change-Id: I16a2050b257277023773cc0c960b5ab36e0c7cd4
2017-02-07 13:13:48 -08:00
Elliott Hughes
fde95b8844
Merge "Don't print 168^W143 lines of help when someone makes a typo."
...
am: 887b6b9a4b
Change-Id: I2fbdad1f5ec9d7b7084384a01ad34679cf74bd09
2017-02-07 20:54:09 +00:00
Elliott Hughes
887b6b9a4b
Merge "Don't print 168^W143 lines of help when someone makes a typo."
2017-02-07 20:51:41 +00:00
Josh Gao
2eefb47ae3
Merge "crash_dump: read /proc/<pid>/maps before dropping capabilities."
...
am: 59b8e35939
Change-Id: I5ee0d4d791ae17b4f3c3eff985d8f94938dbbe19
2017-02-07 20:44:38 +00:00
Josh Gao
59b8e35939
Merge "crash_dump: read /proc/<pid>/maps before dropping capabilities."
2017-02-07 20:41:16 +00:00
Josh Gao
347164cc59
crash_dump: read /proc/<pid>/maps before dropping capabilities.
...
Reading /proc/<pid>/maps does a ptrace_may_access check, which will
fail if we have fewer capabilities than the target, even if we've
already ptraced it.
Bug: http://b/35070339
Test: debuggerd -b `pidof zygote`
Change-Id: I984a061022bd945a7950b88f6d579e1bd735e893
2017-02-07 12:35:51 -08:00
Elliott Hughes
ad2927d744
Merge "Make __android_log_assert behave more like libc asserts."
...
am: 9df286012c
Change-Id: I20003b781eb402d4cc3420d1d2b20aeca8faf978
2017-02-07 17:04:02 +00:00
Elliott Hughes
9df286012c
Merge "Make __android_log_assert behave more like libc asserts."
2017-02-07 17:01:16 +00:00
Josh Gao
f18d64b2d6
Merge "debuggerd_handler: fix prctl return value check."
...
am: 36b8ccb9b2
Change-Id: Ic4ede60f39dc5802d51f682cd69e88534087886a
2017-02-07 06:42:20 +00:00
Josh Gao
36b8ccb9b2
Merge "debuggerd_handler: fix prctl return value check."
2017-02-07 06:37:09 +00:00
Josh Gao
54ef57d0b8
debuggerd_handler: fix prctl return value check.
...
Fixed this when I tested on internal, but failed to copy the fix over
when submitting to AOSP.
Bug: http://b/35070339
Test: `adb bugreport` on angler
Change-Id: Ib84d212e5f890958cd21f5c018fbc6f368138d1e
2017-02-06 21:10:48 -08:00
Elliott Hughes
2ec36b0da0
Don't print 168^W143 lines of help when someone makes a typo.
...
Print actual usage messages in most cases.
Add --help and --version.
Bug: http://b/28054087
Test: manual
Change-Id: I39c1cb7a84f52e0c35d24f140ec55c3a181283fb
2017-02-06 16:20:30 -08:00
Dimitry Ivanov
1508020656
Merge "Log errors from loading public libraries"
...
am: 6b74258818
Change-Id: I3f55cdcb6c1dd194a62f6074501ebd97a7312d85
2017-02-06 21:10:43 +00:00
Dimitry Ivanov
6b74258818
Merge "Log errors from loading public libraries"
2017-02-06 21:05:02 +00:00
Evan Ralston
15a264e65c
Log errors from loading public libraries
...
Prevent the boot from failing silently if one of the public libraries
does not exist.
Test: Add invalid element to public libraries and observe log is emited
during boot failure.
Change-Id: I0425085a1cc081068954f327f15be853a3ccd553
2017-02-06 11:05:35 -08:00
Elliott Hughes
5bae1b866d
Make __android_log_assert behave more like libc asserts.
...
If we don't output to stderr too, not only is it annoying to shell users (who
won't see anything), it prevents us from writing better gtests that actually
make assertions about the assert message.
Bug: http://b/23675822
Test: libutils tests still pass
Change-Id: I62b3144c385cba4dde485f0b0f9b42aeaef51e9a
2017-02-06 10:54:00 -08:00
Josh Gao
124fe65738
Merge changes from topic 'debuggerd_ambient'
...
am: 279cb8b39a
Change-Id: I431dd9d950e8f802098835465ef7d018699f7b61
2017-02-06 18:45:38 +00:00
Josh Gao
6e121639ca
debuggerd_handler: don't use clone(..., SIGCHLD, ...)
...
am: b3ee52e4d0
Change-Id: Ib26a3160392ef1fc3c90aad1cb6e6daaeed29cb4
2017-02-06 18:45:23 +00:00
Josh Gao
49ddc037c1
crash_dump: drop capabilities after we ptrace attach.
...
am: 85bcaf68d3
Change-Id: I8b057f646375743a9646a10a0e72bbe5da017eaa
2017-02-06 18:45:09 +00:00
Josh Gao
cde1bb5902
crash_dump: use /proc/<pid> fd to check tid process membership.
...
am: fe90276aee
Change-Id: Ifd461812b24f11c82668231aee2e684465f5e168
2017-02-06 18:45:01 +00:00
Josh Gao
0adfda8468
debuggerd_handler: raise ambient capset before execing.
...
am: 7ae426c731
Change-Id: I117db086166fa3b0588eba0494fb92e25890d09b
2017-02-06 18:44:54 +00:00
Josh Gao
c49f8f3e3d
Revert "Give crash_dump CAP_SYS_PTRACE."
...
am: ac91b0c452
Change-Id: I86cab7adaf34cddaffc7631c0dd946f3424f4006
2017-02-06 18:42:59 +00:00
Josh Gao
279cb8b39a
Merge changes from topic 'debuggerd_ambient'
...
* changes:
debuggerd_handler: don't use clone(..., SIGCHLD, ...)
crash_dump: drop capabilities after we ptrace attach.
crash_dump: use /proc/<pid> fd to check tid process membership.
debuggerd_handler: raise ambient capset before execing.
Revert "Give crash_dump CAP_SYS_PTRACE."
2017-02-06 18:37:55 +00:00
Wei Wang
b1a519a2bd
Merge "init: clean up exec command"
...
am: 564aeca94e
Change-Id: Id6424ec342a66d3f2b75a45a9988e399d35a0859
2017-02-03 20:48:45 +00:00
Treehugger Robot
564aeca94e
Merge "init: clean up exec command"
2017-02-03 20:45:59 +00:00
James Hawkins
c740363341
Merge "bootstat: Log bootloader timing metrics to Tron."
...
am: 01b25ab149
Change-Id: Ie5b4555f212a4f02211ad991b4d0ccf0af789db7
2017-02-03 19:20:42 +00:00
James Hawkins
01b25ab149
Merge "bootstat: Log bootloader timing metrics to Tron."
2017-02-03 19:18:36 +00:00
Elliott Hughes
eaaca58053
Merge "Revert "Get fastboot working on OS X""
...
am: c8cad2cbfc
Change-Id: I75a48102a1f06b215d5522f2a5c4f7b09322ef64
2017-02-03 18:46:12 +00:00