Commit graph

58739 commits

Author SHA1 Message Date
Tom Cherry
daa14e59cd Merge "libmodprobe: remove SetMinimumLogSeverity() from constructor" am: 03325fb854
Original change: https://android-review.googlesource.com/c/platform/system/core/+/1387857

Change-Id: Ifed528d6dfaaebe116b6b0714a77def969b76a27
2020-08-04 21:57:12 +00:00
Tom Cherry
03325fb854 Merge "libmodprobe: remove SetMinimumLogSeverity() from constructor" 2020-08-04 21:30:09 +00:00
Steven Moreland
b76d1b8873 Merge "perfboot: significant figures + units for summary" am: fe8dec0447
Original change: https://android-review.googlesource.com/c/platform/system/core/+/1386892

Change-Id: I0c3c4c09a23c9a9dd041b0d4d822d885bf1047b0
2020-08-04 18:28:54 +00:00
Steven Moreland
fe8dec0447 Merge "perfboot: significant figures + units for summary" 2020-08-04 18:10:32 +00:00
Tom Cherry
3085d957e8 libmodprobe: remove SetMinimumLogSeverity() from constructor
Only the parent executable, not libraries should set this value.

Note that `modprobe` in toolbox and first stage init, the two primary
users of this library already set this same minimum log severity.

Test: build
Change-Id: I888968deede3323cc270efc3cfd1b40fc521d2da
2020-08-04 08:28:36 -07:00
Jaegeuk Kim
ec91233684 Merge "support f2fs casefolding formatting tool" am: ef2c28bf71
Original change: https://android-review.googlesource.com/c/platform/system/core/+/1367758

Change-Id: I5b7c3e91f42832db1186f8b10064f96cac0d2ee3
2020-08-04 04:49:13 +00:00
Jaegeuk Kim
ef2c28bf71 Merge "support f2fs casefolding formatting tool" 2020-08-04 04:18:07 +00:00
Steven Moreland
18b73dd0b6 perfboot: significant figures + units for summary
This is correct significant figures/units based on the precision of our
measurements, but it does not reflect our actual certainty re the output
data, since in reality, confidence is diminished by temperature, device,
hardware revision, time of day/month/year, spurious activity, data
connectivity, app install list, inherent randomness of multiprogramming,
sensor activity, user interaction, /data caches, build-by-build
differences, charging state, data fragmentation, race-driven sleeps,
cosmic radiation, factory defects, local magnetic or gravitational field
differences, changes in device momentum, or other known and unknown
causes.

Bug: N/A
Test: run perfboot.py, and output has:
    mean: 10801 ms
    median: 10801 ms
    standard deviation: 18 ms
Change-Id: I796396acc203b29e9a14e4d6dffa58db7b8cd9fb
2020-08-04 00:58:40 +00:00
Tom Cherry
6c33a55292 Merge "liblog: don't cache property size values and move to own file" am: 001a5df898
Original change: https://android-review.googlesource.com/c/platform/system/core/+/1386258

Change-Id: If8240d3cc1761a201e80592a2bc5a84cb5bd773d
2020-08-03 23:18:36 +00:00
Tom Cherry
001a5df898 Merge "liblog: don't cache property size values and move to own file" 2020-08-03 22:59:03 +00:00
Tom Cherry
51d1bb3504 Merge "liblog: use unique log tags for is_loggable tests" am: d851b2ab07
Original change: https://android-review.googlesource.com/c/platform/system/core/+/1385942

Change-Id: I236cf6bfa72a32213a0ade3fa870867619113c65
2020-08-03 21:13:16 +00:00
Tom Cherry
d851b2ab07 Merge "liblog: use unique log tags for is_loggable tests" 2020-08-03 20:46:30 +00:00
Tom Cherry
d2743ef5c9 liblog: don't cache property size values and move to own file
Don't cache the property size values since they're only queried at the
start of logd and only once during dumpstate.  Initializing
SerializedLogBuffer, which includes all of the logd queries, takes
under 100us without the cache, certainly fast enough that this cache
is unneeded.

Move these functions to their own file in preparation for removing
them from liblog.

Test: log sizes set appropriately
Change-Id: I15a2fd687dcffb4eab2f22ee0825ca86e40cdba3
2020-08-03 13:17:12 -07:00
Matthew Maurer
7ae978ca0d Merge "Add support for tipc_send()" am: 0b9a329303
Original change: https://android-review.googlesource.com/c/platform/system/core/+/1339493

Change-Id: I6c9bb3cdef14ff187420004db4f6703b20c124f5
2020-08-03 19:44:22 +00:00
Matthew Maurer
0b9a329303 Merge "Add support for tipc_send()" 2020-08-03 19:35:55 +00:00
Elliott Hughes
c9ca928f3f Merge "libdebuggerd: do a to-do." am: 5c2c72b44b
Original change: https://android-review.googlesource.com/c/platform/system/core/+/1386256

Change-Id: I5ff9003b566f684c22a53513cf8819652ebf71b9
2020-08-03 19:32:46 +00:00
Elliott Hughes
5c2c72b44b Merge "libdebuggerd: do a to-do." 2020-08-03 18:56:46 +00:00
Elliott Hughes
713ec25103 libdebuggerd: do a to-do.
Until 77fdb22cf6, logd started as
AID_ROOT and then dropped its privileges. Since then, there's been no
reason to use string comparisons rather than checking the uid.

Test: pkill -SEGV logd
Test: treehugger
Change-Id: Ia709f8f59cb0ab9abac7df84c96c701b5d0a83ea
2020-08-03 18:56:35 +00:00
Tom Cherry
50d021ca7b liblog: use unique log tags for is_loggable tests
Apparently these tests are run in parallel, which causes errors since
they use the same log tag.  Use unique log tags based on pid to fix
this.

Also re-enable the previously disabled tests.

Bug: 162669552
Test: run these tests 100x+ and see that they no longer fail
Change-Id: Ib20d638e5e559bca23adec479a5dcf64075e376e
2020-08-03 11:38:59 -07:00
Tom Cherry
10e45c1dc1 Merge "liblog: disable property tag tests" am: 86adfc7b0b
Original change: https://android-review.googlesource.com/c/platform/system/core/+/1385695

Change-Id: Id9736173f3e278c5085dc2d1371a7b3e0b2da662
2020-08-03 17:18:33 +00:00
Tom Cherry
86adfc7b0b Merge "liblog: disable property tag tests" 2020-08-03 16:58:06 +00:00
Matthew Maurer
e251fa32fd Add support for tipc_send()
* Supports sending memfds in addition to data from an iovec
* Also add a basic test called send-fd

Bug: 117221195
Test: Run send-fd with corresponding Trusty application.
Change-Id: I562d2ff744938c868323a016659ca1332f6a576b
2020-08-03 09:30:37 -07:00
Tom Cherry
d836a61bb8 Merge "SocketClient: don't ignore SIGPIPE" am: 037292424e
Original change: https://android-review.googlesource.com/c/platform/system/core/+/1383960

Change-Id: I74c594003f6d54955accb78ed0cd876ac7b099a2
2020-08-03 16:03:58 +00:00
Tom Cherry
037292424e Merge "SocketClient: don't ignore SIGPIPE" 2020-08-03 15:55:47 +00:00
Elliott Hughes
78e66dbf7d Merge "Update language to comply with Android's inclusive language guidance" am: 9d7657b62e
Original change: https://android-review.googlesource.com/c/platform/system/core/+/1382610

Change-Id: I0674880834a94a4987eeedc7e7fe53e5c1bbe72e
2020-08-03 15:51:47 +00:00
Elliott Hughes
9d7657b62e Merge "Update language to comply with Android's inclusive language guidance" 2020-08-03 15:38:00 +00:00
Tom Cherry
3232957a93 Merge "logd: Add 'print_all_logs' to replay_messages" am: 3e967861da
Original change: https://android-review.googlesource.com/c/platform/system/core/+/1382614

Change-Id: Ib3371ce6855dd1293b4836978234a64013e6c00c
2020-08-03 15:37:50 +00:00
Tom Cherry
031d433472 liblog: disable property tag tests
Disable:
liblog_global_state.is_loggable_both_set
liblog_global_state.is_loggable_tag_log_priority_only

Bug: 162633089
Bug: 162669552
Test: these tests don't run
Change-Id: I82b8e6685a321ae03374e86ffbe845608aec93b5
2020-08-03 08:27:54 -07:00
Tom Cherry
3e967861da Merge "logd: Add 'print_all_logs' to replay_messages" 2020-08-03 15:19:05 +00:00
Treehugger Robot
220e60b1be Merge "Make the udev vs plugdev distinction a bit clearer." am: 9597f27e1b
Original change: https://android-review.googlesource.com/c/platform/system/core/+/1383959

Change-Id: I348e7807565adb531ce73359806492a6b77b8ac1
2020-08-01 02:09:30 +00:00
Treehugger Robot
9597f27e1b Merge "Make the udev vs plugdev distinction a bit clearer." 2020-08-01 01:47:56 +00:00
Treehugger Robot
e98bfc0d9d Merge "libsnapshot: Properly set partial_update_" am: 86313d6fdb
Original change: https://android-review.googlesource.com/c/platform/system/core/+/1383957

Change-Id: I644ffdd48ac35e70cc67187c46086ad4611fa594
2020-07-31 23:35:39 +00:00
Treehugger Robot
86313d6fdb Merge "libsnapshot: Properly set partial_update_" 2020-07-31 23:02:05 +00:00
Tom Cherry
2b3ebaf5c0 SocketClient: don't ignore SIGPIPE
1) All current users are better off ignoring SIGPIPE at the beginning
   of their process instead of ignoring it just for SocketClient
2) This isn't thread safe if users did want it, since sigaction()
   ignores SIGPIPE for the entire process
3) This costs 5-10% of logd CPU time when logcat is reading logs

Also clean up the error handling in SocketClient::sendDataLockedv().

Test: kill logcat and see that logd doesn't crash
Test: run simpleperf and see that no cycles are going to sigaction
Change-Id: I6532c8a0d71338e534411707b9a9bd785145c730
2020-07-31 15:53:18 -07:00
Jeff Sharkey
7b21637782 Update language to comply with Android's inclusive language guidance
See https://source.android.com/setup/contribute/respectful-code for reference

Bug: 161896447
Change-Id: Iafcccbdbdf3ff1078e87000e2ce560ff09b43f68
2020-07-31 16:36:06 -06:00
Tom Cherry
f1d938a5a4 logd: Add 'print_all_logs' to replay_messages
Add 'print_all_logs' which is equivalent to running `logcat` from the
beginning of the captured log buffers.

Test: all logs can be replayed from the start
Change-Id: If0e25513fb294e61c834f82fbf90468c4b767424
2020-07-31 15:30:52 -07:00
Elliott Hughes
e7edfbc916 Make the udev vs plugdev distinction a bit clearer.
Bug: http://b/162109763
Test: treehugger
Change-Id: Id392d0d87dd6ba098382436062b90e3a5ed79025
2020-07-31 15:09:35 -07:00
Yifan Hong
0403d8d2d5 libsnapshot: Properly set partial_update_
On GKI updates, has_dynamic_partition_metadata() may be false. Even if
it is the case, partial_update_ should be set properly.

Test: apply GKI update
Bug: 162616968

Change-Id: Icf055d8eb3060e36b3e977541a24f62f9fe11a6f
2020-07-31 14:42:14 -07:00
Treehugger Robot
23caedd74f Merge "logd: disable flaky tests" am: fcaed0effa
Original change: https://android-review.googlesource.com/c/platform/system/core/+/1383956

Change-Id: I3e142614096eaaad2ea3fde54c403a5dcda9c5f5
2020-07-31 20:47:39 +00:00
Treehugger Robot
fcaed0effa Merge "logd: disable flaky tests" 2020-07-31 20:18:40 +00:00
Tom Cherry
bd5a283ccd logd: disable flaky tests
Bug: 162600780
Test: build
Change-Id: I1da7531ab1c64d77ba228096913fc23d36ef5793
2020-07-31 11:48:33 -07:00
Treehugger Robot
fbcc431f56 Merge "[incremental/adb] fix signature size check" am: 1c5a205fda
Original change: https://android-review.googlesource.com/c/platform/system/core/+/1373276

Change-Id: I676de9e59f89c8711268afaf4b9a3caf705f7cab
2020-07-30 22:50:44 +00:00
Treehugger Robot
1c5a205fda Merge "[incremental/adb] fix signature size check" 2020-07-30 22:27:27 +00:00
Tom Cherry
9fc97b8549 Merge "liblog: don't use a cache for __android_log_is_debuggable()" am: 88066a87bf
Original change: https://android-review.googlesource.com/c/platform/system/core/+/1373469

Change-Id: I87aab47349d9237b4e52c2e67786ee5571bd51b4
2020-07-30 15:43:08 +00:00
Tom Cherry
88066a87bf Merge "liblog: don't use a cache for __android_log_is_debuggable()" 2020-07-30 15:20:22 +00:00
Tom Cherry
f83640d65e liblog: don't use a cache for __android_log_is_debuggable()
ro.debuggable is set by init before other processes would possibly
call __android_log_is_debuggable(), so this property can be checked
once and stored without liblog's property caching mechanisms.

Test: this function returns accurately
Change-Id: Idb1e5e10e53ca809b7f9a75164a4982f39827d4e
2020-07-29 14:49:54 -07:00
Tom Cherry
04f4b02abf Merge "liblog: remove __android_logger_property_get_bool()" am: 3b8b444fce
Original change: https://android-review.googlesource.com/c/platform/system/core/+/1374741

Change-Id: Ibb873f316efe4da4052136ebefbe73c6e7b1d221
2020-07-29 21:38:45 +00:00
Tom Cherry
3b8b444fce Merge "liblog: remove __android_logger_property_get_bool()" 2020-07-29 21:22:38 +00:00
Treehugger Robot
b939c5602c Merge "Update language to comply with Android's inclusive language guidance" am: 98ea1340fb
Original change: https://android-review.googlesource.com/c/platform/system/core/+/1373460

Change-Id: If9c37d71cb4e174f5292a527d877c60ae4ee9eb3
2020-07-29 20:39:18 +00:00
Tom Cherry
3ffb78990b Merge "Run liblog and logd CTS tests in presubmit" am: 5a8d11af58
Original change: https://android-review.googlesource.com/c/platform/system/core/+/1374752

Change-Id: I13c3b6ce237a81a5ff3c542462310463a808a4ba
2020-07-29 20:38:43 +00:00