Commit graph

58591 commits

Author SHA1 Message Date
Steven Moreland
fe8dec0447 Merge "perfboot: significant figures + units for summary" 2020-08-04 18:10:32 +00:00
Jaegeuk Kim
ef2c28bf71 Merge "support f2fs casefolding formatting tool" 2020-08-04 04:18:07 +00:00
Steven Moreland
18b73dd0b6 perfboot: significant figures + units for summary
This is correct significant figures/units based on the precision of our
measurements, but it does not reflect our actual certainty re the output
data, since in reality, confidence is diminished by temperature, device,
hardware revision, time of day/month/year, spurious activity, data
connectivity, app install list, inherent randomness of multiprogramming,
sensor activity, user interaction, /data caches, build-by-build
differences, charging state, data fragmentation, race-driven sleeps,
cosmic radiation, factory defects, local magnetic or gravitational field
differences, changes in device momentum, or other known and unknown
causes.

Bug: N/A
Test: run perfboot.py, and output has:
    mean: 10801 ms
    median: 10801 ms
    standard deviation: 18 ms
Change-Id: I796396acc203b29e9a14e4d6dffa58db7b8cd9fb
2020-08-04 00:58:40 +00:00
Tom Cherry
001a5df898 Merge "liblog: don't cache property size values and move to own file" 2020-08-03 22:59:03 +00:00
Tom Cherry
d851b2ab07 Merge "liblog: use unique log tags for is_loggable tests" 2020-08-03 20:46:30 +00:00
Tom Cherry
d2743ef5c9 liblog: don't cache property size values and move to own file
Don't cache the property size values since they're only queried at the
start of logd and only once during dumpstate.  Initializing
SerializedLogBuffer, which includes all of the logd queries, takes
under 100us without the cache, certainly fast enough that this cache
is unneeded.

Move these functions to their own file in preparation for removing
them from liblog.

Test: log sizes set appropriately
Change-Id: I15a2fd687dcffb4eab2f22ee0825ca86e40cdba3
2020-08-03 13:17:12 -07:00
Matthew Maurer
0b9a329303 Merge "Add support for tipc_send()" 2020-08-03 19:35:55 +00:00
Elliott Hughes
5c2c72b44b Merge "libdebuggerd: do a to-do." 2020-08-03 18:56:46 +00:00
Elliott Hughes
713ec25103 libdebuggerd: do a to-do.
Until 77fdb22cf6, logd started as
AID_ROOT and then dropped its privileges. Since then, there's been no
reason to use string comparisons rather than checking the uid.

Test: pkill -SEGV logd
Test: treehugger
Change-Id: Ia709f8f59cb0ab9abac7df84c96c701b5d0a83ea
2020-08-03 18:56:35 +00:00
Tom Cherry
50d021ca7b liblog: use unique log tags for is_loggable tests
Apparently these tests are run in parallel, which causes errors since
they use the same log tag.  Use unique log tags based on pid to fix
this.

Also re-enable the previously disabled tests.

Bug: 162669552
Test: run these tests 100x+ and see that they no longer fail
Change-Id: Ib20d638e5e559bca23adec479a5dcf64075e376e
2020-08-03 11:38:59 -07:00
Tom Cherry
86adfc7b0b Merge "liblog: disable property tag tests" 2020-08-03 16:58:06 +00:00
Matthew Maurer
e251fa32fd Add support for tipc_send()
* Supports sending memfds in addition to data from an iovec
* Also add a basic test called send-fd

Bug: 117221195
Test: Run send-fd with corresponding Trusty application.
Change-Id: I562d2ff744938c868323a016659ca1332f6a576b
2020-08-03 09:30:37 -07:00
Tom Cherry
037292424e Merge "SocketClient: don't ignore SIGPIPE" 2020-08-03 15:55:47 +00:00
Elliott Hughes
9d7657b62e Merge "Update language to comply with Android's inclusive language guidance" 2020-08-03 15:38:00 +00:00
Tom Cherry
031d433472 liblog: disable property tag tests
Disable:
liblog_global_state.is_loggable_both_set
liblog_global_state.is_loggable_tag_log_priority_only

Bug: 162633089
Bug: 162669552
Test: these tests don't run
Change-Id: I82b8e6685a321ae03374e86ffbe845608aec93b5
2020-08-03 08:27:54 -07:00
Tom Cherry
3e967861da Merge "logd: Add 'print_all_logs' to replay_messages" 2020-08-03 15:19:05 +00:00
Treehugger Robot
9597f27e1b Merge "Make the udev vs plugdev distinction a bit clearer." 2020-08-01 01:47:56 +00:00
Treehugger Robot
86313d6fdb Merge "libsnapshot: Properly set partial_update_" 2020-07-31 23:02:05 +00:00
Tom Cherry
2b3ebaf5c0 SocketClient: don't ignore SIGPIPE
1) All current users are better off ignoring SIGPIPE at the beginning
   of their process instead of ignoring it just for SocketClient
2) This isn't thread safe if users did want it, since sigaction()
   ignores SIGPIPE for the entire process
3) This costs 5-10% of logd CPU time when logcat is reading logs

Also clean up the error handling in SocketClient::sendDataLockedv().

Test: kill logcat and see that logd doesn't crash
Test: run simpleperf and see that no cycles are going to sigaction
Change-Id: I6532c8a0d71338e534411707b9a9bd785145c730
2020-07-31 15:53:18 -07:00
Jeff Sharkey
7b21637782 Update language to comply with Android's inclusive language guidance
See https://source.android.com/setup/contribute/respectful-code for reference

Bug: 161896447
Change-Id: Iafcccbdbdf3ff1078e87000e2ce560ff09b43f68
2020-07-31 16:36:06 -06:00
Tom Cherry
f1d938a5a4 logd: Add 'print_all_logs' to replay_messages
Add 'print_all_logs' which is equivalent to running `logcat` from the
beginning of the captured log buffers.

Test: all logs can be replayed from the start
Change-Id: If0e25513fb294e61c834f82fbf90468c4b767424
2020-07-31 15:30:52 -07:00
Elliott Hughes
e7edfbc916 Make the udev vs plugdev distinction a bit clearer.
Bug: http://b/162109763
Test: treehugger
Change-Id: Id392d0d87dd6ba098382436062b90e3a5ed79025
2020-07-31 15:09:35 -07:00
Yifan Hong
0403d8d2d5 libsnapshot: Properly set partial_update_
On GKI updates, has_dynamic_partition_metadata() may be false. Even if
it is the case, partial_update_ should be set properly.

Test: apply GKI update
Bug: 162616968

Change-Id: Icf055d8eb3060e36b3e977541a24f62f9fe11a6f
2020-07-31 14:42:14 -07:00
Treehugger Robot
fcaed0effa Merge "logd: disable flaky tests" 2020-07-31 20:18:40 +00:00
Tom Cherry
bd5a283ccd logd: disable flaky tests
Bug: 162600780
Test: build
Change-Id: I1da7531ab1c64d77ba228096913fc23d36ef5793
2020-07-31 11:48:33 -07:00
Treehugger Robot
1c5a205fda Merge "[incremental/adb] fix signature size check" 2020-07-30 22:27:27 +00:00
Tom Cherry
88066a87bf Merge "liblog: don't use a cache for __android_log_is_debuggable()" 2020-07-30 15:20:22 +00:00
Tom Cherry
f83640d65e liblog: don't use a cache for __android_log_is_debuggable()
ro.debuggable is set by init before other processes would possibly
call __android_log_is_debuggable(), so this property can be checked
once and stored without liblog's property caching mechanisms.

Test: this function returns accurately
Change-Id: Idb1e5e10e53ca809b7f9a75164a4982f39827d4e
2020-07-29 14:49:54 -07:00
Tom Cherry
3b8b444fce Merge "liblog: remove __android_logger_property_get_bool()" 2020-07-29 21:22:38 +00:00
Treehugger Robot
98ea1340fb Merge "Update language to comply with Android's inclusive language guidance" 2020-07-29 20:32:34 +00:00
Tom Cherry
5a8d11af58 Merge "Run liblog and logd CTS tests in presubmit" 2020-07-29 20:18:25 +00:00
Tom Cherry
62068bfb4a liblog: remove __android_logger_property_get_bool()
All users have been moved to other, more suitable, interfaces.

Test: build
Merged-In: Ic4eb1f0ed6e35d8d6f7e63b80546f4e8bbe163e2
Change-Id: Ic4eb1f0ed6e35d8d6f7e63b80546f4e8bbe163e2
2020-07-29 19:58:30 +00:00
Tom Cherry
b4bc99e873 Run liblog and logd CTS tests in presubmit
And sort the rest of the CTS tests.

Test: these tests run
Change-Id: I8eeb7b8acac2ed658b36da8463112fe1da8437a9
2020-07-29 08:02:52 -07:00
Tom Cherry
898db00675 Merge "logd: remove users of __android_logger_property_get_bool()" 2020-07-29 14:38:57 +00:00
Dan Albert
ac4500e67d Update language to comply with Android's inclusive language guidance
See https://source.android.com/setup/contribute/respectful-code for reference

Bug: http://b/161896447
Test: None
Change-Id: I9e5a37a20012b2f7a8eac55701df03f7b7a9ab6c
2020-07-28 15:58:25 -07:00
Christopher Ferris
0d3dde2d97 Merge "Cleanup for #inclusivefixit." 2020-07-28 21:01:52 +00:00
Tom Cherry
68261eec24 logd: remove users of __android_logger_property_get_bool()
__android_logger_property_get_bool() has a clunky API and doesn't
belong in liblog, since a vast majority of liblog users will never
query this property.

Specifically
1) Replace with GetBoolProperty() when completely equivalent.
2) Remove checking if property values are 'eng' or 'svelte', since
   there's no evidence that those values were ever used.
3) Remove checking 'persist.logd.statistics' and 'ro.logd.statistics',
   since there's no evidence that those values were ever used.
4) Set ro.logd.kernel explicitly, so other processes don't need to
   replicate the defaults that logd uses.

Test: build
Change-Id: I7c37af64ba7754e839185f46da66bf077f09d9c3
2020-07-28 13:16:11 -07:00
Elliott Hughes
b0a9d0e703 Merge "Cleanup for #inclusivefixit." 2020-07-28 19:33:58 +00:00
Treehugger Robot
6949036229 Merge "Cleanup for #inclusivefixit." 2020-07-28 19:33:41 +00:00
Christopher Ferris
4f7a0f8c7c Cleanup for #inclusivefixit.
Bug: 161896447

Test: NA
Change-Id: I8bc5b4be29f91b1884017aa3b4f28d91d9cac419
2020-07-28 12:08:03 -07:00
Elliott Hughes
2c89f97f0a Cleanup for #inclusivefixit.
Test: treehugger
Change-Id: I44f710cbda4497c9d01a1ff7c1dcdb8f0eda6acc
2020-07-28 11:11:55 -07:00
Elliott Hughes
e79b8c2092 Cleanup for #inclusivefixit.
Test: treehugger
Change-Id: I651689e2d59c017a9bde44251d95b57e594f0b5b
2020-07-28 11:09:03 -07:00
Jaegeuk Kim
c69d79fe77 Merge "add generic symlink to access userdata sysfs" 2020-07-28 17:03:35 +00:00
Treehugger Robot
5ce349927d Merge "Use more inclusive language for #inclusivefixit" 2020-07-28 13:28:52 +00:00
Treehugger Robot
71db317340 Merge "Use more inclusive language for #inclusivefixit" 2020-07-28 12:03:43 +00:00
Treehugger Robot
1d098a7db5 Merge "Use more inclusive language for #inclusivefixit" 2020-07-28 11:49:42 +00:00
Treehugger Robot
ab89a928d1 Merge "Cleanup for #inclusivefixit." 2020-07-28 09:46:41 +00:00
Mohammad Islam
ccc3ddda99 Merge "Add StagedInstallInternalTest to adb TEST_MAPPING file" 2020-07-28 08:49:40 +00:00
Hongguang Chen
f79b6ab2dd Use more inclusive language for #inclusivefixit
Updating language to comply with Android’s inclusive language guidance.

See https://source.android.com/setup/contribute/respectful-code for reference.

Bug: 161896447
Test: make
Change-Id: If9a382c33703c8508a8ec9b4219c487e0ff9a79d
2020-07-28 00:22:59 +00:00
Jaegeuk Kim
43dca3c8be add generic symlink to access userdata sysfs
This patch adds fixed location to access sysfs entries by introducing:
/dev/sys/fs/by-name/userdata -> /sys/fs/f2fs/dm-<num>
/dev/sys/block/by-name/userdata -> /sys/block/dm-<num>

Bug: 144277579
Signed-off-by: Jaegeuk Kim <jaegeuk@google.com>
Change-Id: I1b3768005fc8720694bace05292a1b1171d60e3c
2020-07-27 23:58:36 +00:00