ACPR/android_system_core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Revert "crash-reporter: Activate updated BadDirectory test"

Browse source 
This reverts commit 4a029228b93edcd9cf79c2578acd27eb56be5bce

Although this passes in my local checkout, it broke the buildbots.  Will investigate more.

Change-Id: Ib6e33bb916b43b1a42f8f8e4c0c69eb360c3181c
Reviewed-on: http://gerrit.chromium.org/gerrit/8332
Reviewed-by: Michael Krebs <mkrebs@chromium.org>
Tested-by: Michael Krebs <mkrebs@chromium.org>
This commit is contained in:
Michael Krebs 2011-09-26 20:04:04 -07:00
parent ae33866aea
commit b1ac89bb1f
1 changed files with 9 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
crash_reporter/kernel_collector_test.cc
View file

@ -230,14 +230,15 @@ TEST_F(KernelCollectorTest, CollectNoCrash) {
ASSERT_EQ(0, s_crashes);
}
TEST_F(KernelCollectorTest, CollectBadDirectory) {
collector_.SetParameters(17, 0, 17);
WriteStringToFile(test_kcrash_, "====1.1\nsomething");
ASSERT_TRUE(collector_.Collect());
ASSERT_TRUE(FindLog(
"Unable to create appropriate crash directory"));
ASSERT_EQ(1, s_crashes);
}
// Disabled for crosbug.com/18622
//TEST_F(KernelCollectorTest, CollectBadDirectory) {
// collector_.SetParameters(17, 0, 17);
// WriteStringToFile(test_kcrash_, "====1.1\nsomething");
// ASSERT_TRUE(collector_.Collect());
// ASSERT_TRUE(FindLog(
// "Unable to create appropriate crash directory"));
// ASSERT_EQ(1, s_crashes);
//}
void KernelCollectorTest::SetUpSuccessfulCollect() {
collector_.ForceCrashDirectory(kTestCrashDirectory);